On Tue, 8 Oct 2024 18:16:34 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains nine commits: >> >> - class or interface descriptor renamed for clarity >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/array-cd >> - Cleanup after merge >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/array-cd >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/array-cd >> - Compile error >> - Redundant import >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/array-cd >> - 8338544: Dedicated Array class descriptor implementation > > src/java.base/share/classes/jdk/internal/constant/ArrayClassDescImpl.java > line 81: > >> 79: throw new IllegalStateException( >> 80: "Cannot create an array type descriptor with more than " >> 81: + MAX_ARRAY_TYPE_DESC_DIMENSIONS + " >> dimensions"); > > Suggestion: > > ConstantUtils.validateArrayDepth(rank + 1); Unfortunately, this has to throw ISE while `validateArrayDepth` throws IAE. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20665#discussion_r1792386369
