On Fri, 16 Aug 2024 12:10:32 GMT, Doug Lea wrote:
> It would also be OK to just drop that "s" -> InterruptedException.
True, but there are other similar cases in that same file, maybe it's okay to
leave it like that. Similar cases: ForkJoinTasks, Futures, CountedCompleters,
InterruptibleTasks,
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote:
>> This PR fixes a few trivial grammar issues and typos in documentation.
>>
>> The main issue is the use of the word "timeout". To my mind, timeout, a
>> duration, is not the same as deadline, which is a point in time, an instant,
>> which
On Fri, 16 Aug 2024 12:15:47 GMT, Doug Lea wrote:
> The overall inconsistency addressed here is that sometime "timeout" refers to
> a duration, and sometimes an event. Which is pretty common, but reworking
> docs to only mean duration seems reasonable.
Am I correct reading your comment as an e
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote:
>> This PR fixes a few trivial grammar issues and typos in documentation.
>>
>> The main issue is the use of the word "timeout". To my mind, timeout, a
>> duration, is not the same as deadline, which is a point in time, an instant,
>> which
On Thu, 15 Aug 2024 15:41:21 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 858:
>>
>>> 856: * usages of ForkJoinTasks ignore interrupt status when executing
>>> 857: * or awaiting completion. Otherwise, reporting task results or
>>>
On Thu, 15 Aug 2024 15:29:22 GMT, Alexey Ivanov wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix grammatical tense
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 858:
>
>> 856:
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote:
>> This PR fixes a few trivial grammar issues and typos in documentation.
>>
>> The main issue is the use of the word "timeout". To my mind, timeout, a
>> duration, is not the same as deadline, which is a point in time, an instant,
>> which
On Thu, 15 Aug 2024 08:58:46 GMT, David Holmes wrote:
>> I assume you both mean I should change "elapses" to "elapsed" throughout the
>> PR, not just in that particular occurrence.
>
> No, elsewhere you don't have an existing tense to match - I only want the
> sentence to be self-consistent. Th
On Thu, 15 Aug 2024 08:24:30 GMT, Pavel Rappo wrote:
>> Use "elapsed" here to match "completed".
>
> I assume you both mean I should change "elapses" to "elapsed" throughout the
> PR, not just in that particular occurrence.
No, elsewhere you don't have an existing tense to match - I only want t
On Thu, 15 Aug 2024 04:07:19 GMT, David Holmes wrote:
>> I admit I had doubts about the sequence of tenses too. That's a pretty
>> complex sentence, and I'm a non-native English speaker. It's hard to
>> re-tense it while retaining its conditional nature.
>
> Use "elapsed" here to match "complet
> This PR fixes a few trivial grammar issues and typos in documentation.
>
> The main issue is the use of the word "timeout". To my mind, timeout, a
> duration, is not the same as deadline, which is a point in time, an instant,
> which allows "before" and "after". While one can think of timeout
On Wed, 14 Aug 2024 22:11:39 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java line 1075:
>>
>>> 1073: /**
>>> 1074: * Tries to join this task, returning true if it completed
>>> 1075: * (possibly exceptionally) before the given timeout e
On Wed, 14 Aug 2024 21:03:05 GMT, Kevin Bourrillion wrote:
>> This PR fixes a few trivial grammar issues and typos in documentation.
>>
>> The main issue is the use of the word "timeout". To my mind, timeout, a
>> duration, is not the same as deadline, which is a point in time, an instant,
>>
On Wed, 14 Aug 2024 13:38:34 GMT, Pavel Rappo wrote:
> This PR fixes a few trivial grammar issues and typos in documentation.
>
> The main issue is the use of the word "timeout". To my mind, timeout, a
> duration, is not the same as deadline, which is a point in time, an instant,
> which allow
This PR fixes a few trivial grammar issues and typos in documentation.
The main issue is the use of the word "timeout". To my mind, timeout, a
duration, is not the same as deadline, which is a point in time, an instant,
which allows "before" and "after". While one can think of timeout as of an
15 matches
Mail list logo
