On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> This PR fixes a few trivial grammar issues and typos in documentation. >> >> The main issue is the use of the word "timeout". To my mind, timeout, a >> duration, is not the same as deadline, which is a point in time, an instant, >> which allows "before" and "after". While one can think of timeout as of an >> event, which can occur, it usually expires, or elapses. An activity can also >> "time out" (phrasal verb). >> >> I think the proposed change might read better and match wording already used >> throughout `java.util.concurrent.**`, for example, here: >> >> * >> https://github.com/openjdk/jdk/blob/00e6c63cd12e3f92d0c1d007aab4f74915616ffb/src/java.base/share/classes/java/util/concurrent/ExecutorService.java#L211-L223 >> * >> https://github.com/openjdk/jdk/blob/fbe4cc96e223882a18c7ff666fe6f68b3fa2cfe4/src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java#L1019-L1036 >> >> >> @DougLea, thoughts? > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Fix grammatical tense The overall inconsistency addressed here is that sometime "timeout" refers to a duration, and sometimes an event. Which is pretty common, but reworking docs to only mean duration seems reasonable. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20584#issuecomment-2293401618
