On Wed, 14 Aug 2024 22:11:39 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java line 1075: >> >>> 1073: /** >>> 1074: * Tries to join this task, returning true if it completed >>> 1075: * (possibly exceptionally) before the given timeout elapses and >> >> Seems like mixed tense now: do we want completes/elapses or >> completed/elapsed? > > I admit I had doubts about the sequence of tenses too. That's a pretty > complex sentence, and I'm a non-native English speaker. It's hard to re-tense > it while retaining its conditional nature. Use "elapsed" here to match "completed". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20584#discussion_r1717850485
