On Thu, 5 Sep 2024 07:42:26 GMT, Jatin Bhateja wrote:
>> src/hotspot/share/opto/vectornode.hpp line 634:
>>
>>> 632: virtual int Opcode() const;
>>> 633: };
>>> 634:
>>
>> This could also be a separate PR. Or are they somehow inseparable from the
>> "saturation" changes?
>
> Not applicable
On Thu, 5 Sep 2024 08:34:36 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Thu, 5 Sep 2024 08:34:36 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB:
On Tue, 3 Sep 2024 22:18:20 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolved
>
> src/hotspot/cpu/x86/x86.ad line 10684:
>
>> 10682: match(Set dst (SaturatingSub
On Tue, 3 Sep 2024 13:09:13 GMT, Emanuel Peter wrote:
> You did in fact add `java/lang` methods. I think you need to add tests for
> all of those. As well. That's going to be even more code to review.
Hi @eme64 , As Paul suggested in offline mail chain, lets restrict the changes
with this patc
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB:
On Tue, 3 Sep 2024 16:23:56 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolved
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 8470:
>
>> 8468: void Assembler::vpmax
On Mon, 2 Sep 2024 12:15:10 GMT, Jatin Bhateja wrote:
>> If the aim is to reduce the number of nodes, we could merge the
>> Op_SaturatingAddVB, Op_SaturatingAddVS, Op_SaturatingAddVI, and
>> Op_SaturatingAddVL into one Op_SaturatingAddV. Likewise for unsigned
>> saturating add into Op_Saturati
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 2 Sep 2024 12:17:08 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/x86.ad line 10656:
>>
>>> 10654: match(Set dst (SaturatingSubVI src1 src2));
>>> 10655: match(Set dst (SaturatingSubVL src1 src2));
>>> 10656: effect(TEMP ktmp);
>>
>> This needs TEMP dst as well.
>
> There is no
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 2 Sep 2024 12:20:59 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Wed, 28 Aug 2024 16:05:45 GMT, Sandhya Viswanathan
wrote:
>> Wonder if it would have been simpler if we added unsigned vector operators
>> like Op_SaturatingUnsignedAddVB etc. We are not adding unsigned data types
>> to Java, only supporting unsigned (saturating) operations on existing sign
On Mon, 26 Aug 2024 22:17:55 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolutions.
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 10229:
>
>> 10227: InstructionM
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB:
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Wed, 28 Aug 2024 00:12:26 GMT, Sandhya Viswanathan
wrote:
>> Hey @jaskarth , Central idea behind introducing VectorReinterpretNode after
>> unsigned vector IR is to facilitate unboxing-boxing optimization, this
>> explicit reinterpretation ensures type compatibility between value being
>>
On Thu, 15 Aug 2024 06:59:53 GMT, Jatin Bhateja wrote:
>>> its usage in existing patch is limited to [type
>>> comparison.](https://github.com/openjdk/jdk/pull/20507/files#diff-3559dcf23b719805be5fd06fd5c1851dbd8f53e47afe6d99cba13a3de0ebc6b2R1542)
>>
>> Ah, that makes sense to me. I took a clos
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB:
On Wed, 14 Aug 2024 04:59:23 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Thu, 15 Aug 2024 03:01:00 GMT, Jasmine Karthikeyan
wrote:
>> @jaskarth , its usage in existing patch is limited to [type
>> comparison.](https://github.com/openjdk/jdk/pull/20507/files#diff-3559dcf23b719805be5fd06fd5c1851dbd8f53e47afe6d99cba13a3de0ebc6b2R1542).
>>
>>
>> My plan is to addr
On Mon, 12 Aug 2024 06:29:03 GMT, Jatin Bhateja wrote:
> its usage in existing patch is limited to [type
> comparison.](https://github.com/openjdk/jdk/pull/20507/files#diff-3559dcf23b719805be5fd06fd5c1851dbd8f53e47afe6d99cba13a3de0ebc6b2R1542)
Ah, that makes sense to me. I took a closer look an
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SATURATING_UADD : Saturating unsigned addition.
> . SATURATING_ADD: Saturating signed addition.
> . SATURATING_USUB : Saturating unsigned
On Thu, 8 Aug 2024 17:20:06 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SATURATING_UADD : Saturating unsigned addition.
>> . SATURATING_ADD: Saturating sig
On Fri, 9 Aug 2024 03:28:53 GMT, Jasmine Karthikeyan
wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>
On Thu, 8 Aug 2024 17:20:06 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SATURATING_UADD : Saturating unsigned addition.
>> . SATURATING_ADD: Saturating sig
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SATURATING_UADD : Saturating unsigned addition.
> . SATURATING_ADD: Saturating signed addition.
> . SATURATING_USUB : Saturating unsigned
Hi All,
As per the discussion on panama-dev mailing list[1], patch adds the support
following new vector operators.
. SATURATING_UADD : Saturating unsigned addition.
. SATURATING_ADD: Saturating signed addition.
. SATURATING_USUB : Saturating unsigned subtraction.
38 matches
Mail list logo
