On Tue, 3 Sep 2024 16:23:56 GMT, Sandhya Viswanathan <sviswanat...@openjdk.org>
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolved
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 8470:
>
>> 8468: void Assembler::vpmaxud(XMMRegister dst, XMMRegister nds, XMMRegister
>> src, int vector_len) {
>> 8469: assert(vector_len == AVX_128bit ? VM_Version::supports_avx() :
>> 8470: (vector_len == AVX_256bit ? VM_Version::supports_avx2() :
>> VM_Version::supports_avx512bw()), "");
>
> avx512bw check here seems wrong.
If this is indeed wrong, then we are missing tests, and you should add some
more.
> src/hotspot/cpu/x86/assembler_x86.cpp line 8479:
>
>> 8477: void Assembler::vpmaxud(XMMRegister dst, XMMRegister nds, Address src,
>> int vector_len) {
>> 8478: assert(vector_len == AVX_128bit ? VM_Version::supports_avx() :
>> 8479: (vector_len == AVX_256bit ? VM_Version::supports_avx2() :
>> VM_Version::supports_avx512bw()), "");
>
> avx512bw check here seems wrong.
If this is indeed wrong, then we are missing tests, and you should add some
more.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1743283892
PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1743284116
