On Wed, 28 Aug 2024 16:05:45 GMT, Sandhya Viswanathan <sviswanat...@openjdk.org> wrote:
>> Wonder if it would have been simpler if we added unsigned vector operators >> like Op_SaturatingUnsignedAddVB etc. We are not adding unsigned data types >> to Java, only supporting unsigned (saturating) operations on existing signed >> integral types. > > If the aim is to reduce the number of nodes, we could merge the > Op_SaturatingAddVB, Op_SaturatingAddVS, Op_SaturatingAddVI, and > Op_SaturatingAddVL into one Op_SaturatingAddV. Likewise for unsigned > saturating add into Op_SaturatingUnsignedAddV. Hey @sviswa7, our concern was around value ranges of new unsigned scalar type, which as mentioned will be addressed when I support intrinsification of new core lib APIs and associated range constraining / folding optimization in a follow up patch. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1740817837
