On Tue, 27 Jun 2023 15:20:33 GMT, Glavo wrote:
>> When the default Locale is `tr`, the jmod and jimage commands have the
>> following problems:
>>
>> * The jmod command does not correctly recognize the `list` mode typed in
>> lowercase;
>> * The jimage command cannot obtain the help informatio
On Tue, 27 Jun 2023 15:20:33 GMT, Glavo wrote:
>> When the default Locale is `tr`, the jmod and jimage commands have the
>> following problems:
>>
>> * The jmod command does not correctly recognize the `list` mode typed in
>> lowercase;
>> * The jimage command cannot obtain the help informatio
On Tue, 27 Jun 2023 07:45:51 GMT, Glavo wrote:
>> When the default Locale is `tr`, the jmod and jimage commands have the
>> following problems:
>>
>> * The jmod command does not correctly recognize the `list` mode typed in
>> lowercase;
>> * The jimage command cannot obtain the help informatio
> When the default Locale is `tr`, the jmod and jimage commands have the
> following problems:
>
> * The jmod command does not correctly recognize the `list` mode typed in
> lowercase;
> * The jimage command cannot obtain the help information of the `list` mode.
Glavo has updated the pull reque
On Wed, 7 Jun 2023 06:32:31 GMT, Jaikiran Pai wrote:
> Sounds fine to me and as other have agreed `Locale.ROOT` would be more
> appropriate. Would you be willing to update this PR to update the few other
> occurences in some classes (`JImageTask`, `JlinkTask` and
> `VersionPropsPlugin`) as not
On Tue, 27 Jun 2023 07:45:51 GMT, Glavo wrote:
>> When the default Locale is `tr`, the jmod and jimage commands have the
>> following problems:
>>
>> * The jmod command does not correctly recognize the `list` mode typed in
>> lowercase;
>> * The jimage command cannot obtain the help informatio
> When the default Locale is `tr`, the jmod and jimage commands have the
> following problems:
>
> * The jmod command does not correctly recognize the `list` mode typed in
> lowercase;
> * The jimage command cannot obtain the help information of the `list` mode.
Glavo has updated the pull reque
> When the default Locale is `tr`, the jmod and jimage commands have the
> following problems:
>
> * The jmod command does not correctly recognize the `list` mode typed in
> lowercase;
> * The jimage command cannot obtain the help information of the `list` mode.
Glavo has updated the pull reque
On Wed, 31 May 2023 19:46:57 GMT, Glavo wrote:
> > Hello @Glavo, I see you reopened this PR, so I'm guessing you are still
> > interested in pursuing this further. Are you considering updating this PR
> > to implement Alan's suggestion to do similar changes in `JImageTask.java`
> > and `JlinkT
On Sun, 29 Jan 2023 23:54:21 GMT, Glavo wrote:
>> When the default Locale is `tr`, the jmod and jimage commands have the
>> following problems:
>>
>> * The jmod command does not correctly recognize the `list` mode typed in
>> lowercase;
>> * The jimage command cannot obtain the help informatio
On Sun, 29 Jan 2023 15:37:28 GMT, Glavo wrote:
> When the default Locale is `tr`, the jmod and jimage commands have the
> following problems:
>
> * The jmod command does not correctly recognize the `list` mode typed in
> lowercase;
> * The jimage command cannot obtain the help information of t
On Sun, 29 Jan 2023 23:54:21 GMT, Glavo wrote:
>> When the default Locale is `tr`, the jmod and jimage commands have the
>> following problems:
>>
>> * The jmod command does not correctly recognize the `list` mode typed in
>> lowercase;
>> * The jimage command cannot obtain the help informatio
On Wed, 1 Feb 2023 09:26:17 GMT, Glavo wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java line 1474:
>>
>>> 1472: String verb = words.get(0);
>>> 1473: try {
>>> 1474: options.mode = Enum.valueOf(Mode.class,
>>> verb.toUpperCase(Locale.ROO
On Wed, 1 Feb 2023 07:20:17 GMT, Alan Bateman wrote:
> This is the lookup of the main.usage.list resource (`jimage list --help`)
> rather than the `list` option but good to fix this anyway.
Sorry, I found the problem with text search, but didn't look at them carefully.
-
PR: https
On Wed, 1 Feb 2023 07:20:13 GMT, Alan Bateman wrote:
> The equivalent in jlink and jimage are using Locale.ENGLISH, I guess we
> should try to keep them consistent.
This class is using `Locale.ROOT` to convert modifiers to lowercase, and there
is no reference to `Locale.ENGLISH`.
On Sun, 29 Jan 2023 15:37:28 GMT, Glavo wrote:
> When the default Locale is `tr`, the jmod and jimage commands have the
> following problems:
>
> * The jmod command does not correctly recognize the `list` mode typed in
> lowercase;
> * The jimage command cannot obtain the help information of t
On Sun, 29 Jan 2023 15:37:28 GMT, Glavo wrote:
> When the default Locale is `tr`, the jmod and jimage commands have the
> following problems:
>
> * The jmod command does not correctly recognize the `list` mode typed in
> lowercase;
> * The jimage command cannot obtain the help information of t
When the default Locale is `tr`, the jmod and jimage commands have the
following problems:
* The jmod command does not correctly recognize the `list` mode typed in
lowercase;
* The jimage command cannot obtain the help information of the `list` mode.
-
Commit messages:
- list mode
18 matches
Mail list logo
