On Wed, 31 May 2023 19:46:57 GMT, Glavo <d...@openjdk.org> wrote: > > Hello @Glavo, I see you reopened this PR, so I'm guessing you are still > > interested in pursuing this further. Are you considering updating this PR > > to implement Alan's suggestion to do similar changes in `JImageTask.java` > > and `JlinkTask.java` to use `Locale.ROOT` or update this proposed change to > > use `Locale.ENGLISH`? > > @jaikiran Hi Jaikiran, as my previous reply, I do not agree that > `Locale.ENGLISH` should be used here, I think `Locale.ROOT` is more > reasonable.
Sounds fine to me and as other have agreed `Locale.ROOT` would be more appropriate. Would you be willing to update this PR to update the few other occurences in some classes (`JImageTask`, `JlinkTask` and `VersionPropsPlugin`) as noted by Mandy and Alan in their comments? ------------- PR Comment: https://git.openjdk.org/jdk/pull/12281#issuecomment-1579985432
