On Sun, 29 Jan 2023 23:54:21 GMT, Glavo <d...@openjdk.org> wrote:

>> When the default Locale is `tr`, the jmod and jimage commands have the 
>> following problems:
>> 
>> * The jmod command does not correctly recognize the `list` mode typed in 
>> lowercase;
>> * The jimage command cannot obtain the help information of the `list` mode.
>
> There are some similar hidden dangers in OpenJDK. I hope to clean them up.
> 
> These hidden dangers are scattered in many modules. Should I solve them in 
> multiple PRs?

> Hello @Glavo, I see you reopened this PR, so I'm guessing you are still 
> interested in pursuing this further. Are you considering updating this PR to 
> implement Alan's suggestion to do similar changes in `JImageTask.java` and 
> `JlinkTask.java` to use `Locale.ROOT` or update this proposed change to use 
> `Locale.ENGLISH`?

@jaikiran Hi Jaikiran, as my previous reply, I do not agree that 
`Locale.ENGLISH` should be used here, I think `Locale.ROOT` is more reasonable.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12281#issuecomment-1570842199

Reply via email to