On Tue, 6 Dec 2022 18:10:38 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 99:
>>
>>> 97: */
>>> 98:
>>> 99: public class Console implements Flushable
>>
>> Should we perhaps `seal` this class and only `permit` `ProxyingConsole` to
>> `extend` it?
>
> Right.
On Wed, 7 Dec 2022 19:19:25 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Wed, 7 Dec 2022 18:57:19 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/java/io/ProxyingConsole.java line 167:
>
>> 165: @Over
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Wed, 7 Dec 2022 17:09:53 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Wed, 7 Dec 2022 11:54:11 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Making the wrapper classes static
>
> src/java.base/share/classes/java/io/Console.java line 625:
>
>> 623: };
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Tue, 6 Dec 2022 19:17:44 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Tue, 6 Dec 2022 07:34:45 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/Console.java line 616:
>>
>>> 614:
>>> JdkConsoleProvider.DEFAULT_PROVIDER_MODULE_NAME);
>>> 615: return
>>> ServiceLoader.load(JdkConsoleProvider.class).stream()
On Tue, 6 Dec 2022 06:19:37 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed the copyright year
>
> src/java.base/share/classes/java/io/Console.java line 99:
>
>> 97: */
>> 98:
>> 99: public
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Tue, 6 Dec 2022 07:35:44 GMT, Jaikiran Pai wrote:
> So the `Console` instance returned from `System.console()`, thus far, follows
> these semantics. However, with the change proposed in this PR, the default
> implementation will now be the jline backed `JdkConsoleImpl` implementation.
> Fro
On Tue, 6 Dec 2022 07:08:55 GMT, Jaikiran Pai wrote:
> Furthermore, I think in its current form it means that this will
> load/instantiate any `JdkConsoleProvider` implementations that are accessible
> to the thread context classloader but may not have been from the module
> configured through
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Sun, 4 Dec 2022 17:09:15 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed the expected behavior when the SecurityManager is enabled
>
> src/java.base/share/classes/java/io/Console.java lin
On Mon, 5 Dec 2022 18:33:10 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Sat, 3 Dec 2022 19:18:48 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Sat, 3 Dec 2022 19:18:48 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Fri, 2 Dec 2022 15:21:40 GMT, Weijun Wang wrote:
>> Naoto has confirmed that the password prompt from keytool does not echo,
>> good!
>>
>> The intention is that Console be usable in jshell so I think the issue is
>> that readPassword is echo'ing when used in jshell. Maybe someone
>> exper
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Fri, 2 Dec 2022 08:18:35 GMT, Alan Bateman wrote:
>> If the console cannot be used anyway inside jshell, then this is good enough.
>
> Naoto has confirmed that the password prompt from keytool does not echo, good!
>
> The intention is that Console be usable in jshell so I think the issue is
On Thu, 1 Dec 2022 23:38:40 GMT, Weijun Wang wrote:
>> I confirmed that the standalone `keytool` did not echo the input, which
>> should be OK for this IMO.
>
> If the console cannot be used anyway inside jshell, then this is good enough.
Naoto has confirmed that the password prompt from keytoo
On Thu, 1 Dec 2022 19:30:29 GMT, Naoto Sato wrote:
>> What's the expected behavior?
>
> I confirmed that the standalone `keytool` did not echo the input, which
> should be OK for this IMO.
If the console cannot be used anyway inside jshell, then this is good enough.
-
PR: https://
On Thu, 1 Dec 2022 17:53:58 GMT, Weijun Wang wrote:
>> I can still see the password on screen. Here `in` is a
>> `jdk.jshell.execution.Util` so the updated check on line 58 above failed.
>>
>> $ jshell -C--add-exports -Cjava.base/sun.security.tools.keytool=ALL-UNNAMED
>> -R--add-exports -Rjava
On Thu, 1 Dec 2022 16:08:39 GMT, Weijun Wang wrote:
>> Sure. Trying out now...
>
> I can still see the password on screen. Here `in` is a
> `jdk.jshell.execution.Util` so the updated check on line 58 above failed.
>
> $ jshell -C--add-exports -Cjava.base/sun.security.tools.keytool=ALL-UNNAMED
On Thu, 1 Dec 2022 15:49:30 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/util/Password.java line 63:
>>
>>> 61: // readPassword returns "" if you just press ENTER with
>>> the built-in Console,
>>> 62: // to be compatible with old Password
On Thu, 1 Dec 2022 15:16:29 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Adds a test
>> - Removed JavaIOAccess.charset() which is no longer needed
>
> src/java.base/share/classes/sun/security/
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inte
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inte
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inte
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inte
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Wed, 30 Nov 2022 17:07:35 GMT, Jim Laskey wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inte
On Tue, 29 Nov 2022 19:38:02 GMT, Naoto Sato wrote:
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal
This is to allow Console to be used even when it is not attached to the
platform provided terminal, such as the case when the standard input is
redirected. `System.console()` now returns a Console implementation based on
`jdk.internal.le` terminal by default, or jshell implementation if availabl
52 matches
Mail list logo
