On Tue, 29 Nov 2022 19:38:02 GMT, Naoto Sato <na...@openjdk.org> wrote:

> This is to allow Console to be used even when it is not attached to the 
> platform provided terminal, such as the case when the standard input is 
> redirected. `System.console()` now returns a Console implementation based on 
> `jdk.internal.le` terminal by default, or jshell implementation if available. 
> A corresponding CSR has been drafted.

Looks good otherwise. Add tests.

src/java.base/share/classes/java/io/Console.java line 617:

> 615: 
> 616:             public Charset charset() {
> 617:                 return cons.charset();

What happens when cons is null?

-------------

PR: https://git.openjdk.org/jdk/pull/11421

Reply via email to