On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.internal.le` terminal by default, or jshell implementation if
>> available. A corresponding CSR has been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed the copyright year
src/java.base/share/classes/java/io/Console.java line 625:
> 623: };
> 624: return AccessController.doPrivileged(pa);
> 625: } catch (ServiceConfigurationError ignore) {
Should we perhaps just catch `Throwable` here since it's possible that the
`PrivelegedAction` code could throw unchecked exception (for example the call
to `JdkConsoleProvider.console()` could, in theory, lead to any kind of
unchecked exceptions or errors like `NoClassDefFoundError`).
-------------
PR: https://git.openjdk.org/jdk/pull/11421
