On Tue, 16 Aug 2022 02:08:43 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Tue, 16 Aug 2022 02:08:43 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Thu, 11 Aug 2022 14:16:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the hashcode depending on the
> order of iteration of the
On Mon, 15 Aug 2022 16:07:45 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> incorporate review comments and add more testing
>
> test/jdk/java/lang/module/ModuleDescriptorHashCodeTest.java line 1
On Thu, 11 Aug 2022 14:16:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Wed, 10 Aug 2022 15:23:12 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> incorporate review comments and add more testing
>
> test/jdk/java/lang/module/ModuleDescriptorHashCodeTest.java line 7
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the hashcode depending on the
> order of iteration of the
On 8/9/2022 11:56 PM, Peter Levart wrote:
On Sun, 7 Aug 2022 08:14:58 GMT, Alan Bateman wrote:
Sorry for joining late. I noticed that modsHashCode is a private method and it
takes Iterable as a parameter. But everywhere it is called, a Set is passed to
it. So why not just calling the set.h
On Sun, 7 Aug 2022 07:55:26 GMT, Peter Levart wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value o
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
On Sun, 7 Aug 2022 08:14:58 GMT, Alan Bateman wrote:
> > Sorry for joining late. I noticed that modsHashCode is a private method and
> > it takes Iterable as a parameter. But everywhere it is called, a Set is
> > passed to it. So why not just calling the set.hashCode() and be done with
> > it?
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
Can I please get a review of this change which proposes to fix
https://bugs.openjdk.org/browse/JDK-8290041?
As noted by the reporter, the current implementation is buggy since the
calculation can result in a different value of the hashcode depending on the
order of iteration of the `Modifier`s
17 matches
Mail list logo
