Re: RFR: 8041488: Locale-Dependent List Patterns [v17]

2023-09-08 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v16]

2023-09-08 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v15]

2023-09-08 Thread Naoto Sato
On Fri, 8 Sep 2023 14:43:59 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits since

Re: RFR: 8041488: Locale-Dependent List Patterns [v15]

2023-09-08 Thread Roger Riggs
On Thu, 7 Sep 2023 18:20:28 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-general

Re: RFR: 8041488: Locale-Dependent List Patterns [v14]

2023-09-08 Thread Naoto Sato
On Thu, 7 Sep 2023 16:57:20 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporating suggested changes > > src/java.base/share/classes/java/text/ListFormat.java line 95: > >> 93: * On parsing,

Re: RFR: 8041488: Locale-Dependent List Patterns [v15]

2023-09-07 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v14]

2023-09-07 Thread Roger Riggs
On Tue, 5 Sep 2023 22:47:01 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-general

Re: RFR: 8041488: Locale-Dependent List Patterns [v14]

2023-09-06 Thread Joe Wang
On Tue, 5 Sep 2023 22:47:01 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-general

Re: RFR: 8041488: Locale-Dependent List Patterns [v14]

2023-09-05 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v13]

2023-09-05 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Naoto Sato
On Tue, 5 Sep 2023 21:14:00 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary commas > > src/java.base/share/classes/java/text/ListFormat.java line 90: > >> 88: * method specifie

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Roger Riggs
On Tue, 29 Aug 2023 16:51:49 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-genera

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Joe Wang
On Tue, 5 Sep 2023 19:50:26 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/ListFormat.java line 560: >> >>> 558: * The {@code UNIT} ListFormat style. This style concatenates >>> 559: * elements, useful for enumerating units. >>> 560: */ >> >> The word

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Naoto Sato
On Tue, 5 Sep 2023 20:25:52 GMT, Roger Riggs wrote: >> Good point. Will add some kind of limitation. > > I can't see what arbitrary limit would make sense. > But perhaps an APINote that formatting the string from an excessively long > list may exceed memory or string sizes. (Without being speci

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Naoto Sato
On Tue, 5 Sep 2023 20:29:53 GMT, Joe Wang wrote: >> Type and Style select a pattern defined for the locale. (for the zero arg >> and three arg getInstance methods). >> I think I would avoid the term "concatenation", the type defines a pattern >> that contains punctuation and connecting words. T

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Joe Wang
On Tue, 5 Sep 2023 20:15:26 GMT, Roger Riggs wrote: >> I think that Type/Style/Locale forming a specific pattern is an >> implementation detail, so I would not describe it in the spec (although as >> you say they form a specific pattern in the impl). It could be that an impl >> of 3-arg getIns

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Roger Riggs
On Tue, 5 Sep 2023 19:50:29 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/ListFormat.java line 521: >> >>> 519: var sb = new StringBuilder(256).append(patterns[START]); >>> 520: IntStream.range(2, count - 1).forEach(i -> >>> sb.append(middleBetween).append("{")

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Joe Wang
On Tue, 5 Sep 2023 20:17:14 GMT, Naoto Sato wrote: >> I'd stick to the general first sentence structure used by DateFormat, >> Format, and MessageFormat. >> ("tools" in OpenJDK are standalone programs.) >> >> For example, >> "ListFormat formats and parses lists of strings." > > I agree, Roger.

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Roger Riggs
On Tue, 5 Sep 2023 19:50:23 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/ListFormat.java line 48: >> >>> 46: * List Patterns. >>> 47: * >>> 48: * Three types of concatenation are provided: {@link Type#STANDARD >>> STANDARD}, >> >> A "Type" and "Style" together make up a

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Naoto Sato
On Tue, 5 Sep 2023 20:04:57 GMT, Roger Riggs wrote: >> Thanks. Will modify the wording in the next revision. I think we should >> stick to the wording `format`/`parse` here. > > I'd stick to the general first sentence structure used by DateFormat, Format, > and MessageFormat. > ("tools" in Open

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Roger Riggs
On Tue, 5 Sep 2023 19:50:20 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/ListFormat.java line 46: >> >>> 44: * defined in Unicode Consortium's LDML specification for >>> 45: * >> href="https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns";> >>> 46: * List Pat

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-05 Thread Naoto Sato
On Sun, 3 Sep 2023 05:05:49 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary commas > > src/java.base/share/classes/java/text/ListFormat.java line 46: > >> 44: * defined in Unicode

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-09-02 Thread Joe Wang
On Tue, 29 Aug 2023 16:51:49 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-genera

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-08-29 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v11]

2023-08-28 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v10]

2023-08-28 Thread Naoto Sato
On Mon, 28 Aug 2023 20:05:41 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-genera

Re: RFR: 8041488: Locale-Dependent List Patterns [v10]

2023-08-28 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v9]

2023-08-28 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v8]

2023-08-18 Thread Roger Riggs
On Thu, 10 Aug 2023 17:31:28 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-genera

Re: RFR: 8041488: Locale-Dependent List Patterns [v8]

2023-08-18 Thread Roger Riggs
On Thu, 10 Aug 2023 17:31:28 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-genera

Re: RFR: 8041488: Locale-Dependent List Patterns [v7]

2023-08-10 Thread Joe Wang
On Thu, 10 Aug 2023 16:59:14 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/ListFormat.java line 58: >> >>> 56: * .format(List.of("Foo", "Bar", "Baz")) >>> 57: * } >>> 58: * This will produce the concatenated list string, "Foo, Bar, and Baz" >>> as seen in >> >> With th

Re: RFR: 8041488: Locale-Dependent List Patterns [v8]

2023-08-10 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v7]

2023-08-10 Thread Naoto Sato
On Wed, 9 Aug 2023 23:39:24 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Small cleanup > > src/java.base/share/classes/java/text/ListFormat.java line 58: > >> 56: * .format(List.of("Foo", "Bar"

Re: RFR: 8041488: Locale-Dependent List Patterns [v7]

2023-08-09 Thread Joe Wang
On Wed, 9 Aug 2023 00:46:58 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-general

Re: RFR: 8041488: Locale-Dependent List Patterns [v7]

2023-08-08 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v6]

2023-08-08 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v5]

2023-08-08 Thread Naoto Sato
On Tue, 8 Aug 2023 19:49:19 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits sin

Re: RFR: 8041488: Locale-Dependent List Patterns [v5]

2023-08-08 Thread Roger Riggs
On Tue, 8 Aug 2023 17:19:55 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-general

Re: RFR: 8041488: Locale-Dependent List Patterns [v5]

2023-08-08 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v4]

2023-08-04 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v3]

2023-08-03 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v2]

2023-08-02 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

RFR: 8041488: Locale-Dependent List Patterns

2023-08-02 Thread Naoto Sato
Introducing a new formatting class for locale-dependent list patterns. The class is to provide the functionality from the Unicode Consortium's LDML specification for [list patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). For example, given a list of String as "Mon