On Tue, 5 Sep 2023 20:29:53 GMT, Joe Wang <jo...@openjdk.org> wrote:

>> Type and Style select a pattern defined for the locale. (for the zero arg 
>> and three arg getInstance methods).
>> I think I would avoid the term "concatenation", the type defines a pattern 
>> that contains punctuation and connecting words. The style selects among the 
>> full, short, and narrow patterns.
>
> I thought they're already a part of the public API described in the current 
> javadoc, e.g. ListFormat.Style and ListFormat.Type 
> (https://cr.openjdk.org/~naoto/JDK-8041488-ListPatterns-PR/api.00/java.base/java/text/ListFormat.html).
>  I thought you meant to support general patterns (the List Patterns) and a 
> few (specific) "type attributes" as in the LDML spec.

Yes, they are public API. My intention was to keep those patterns exposure as 
minimal as possible, as they are complicated so that users who just wish to 
acquire formats only with Type/Style/Locale need not know it. Only those who 
want to customize their own patterns can do so with the 1-arg getInstance(), 
thus I wanted the description in that method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15130#discussion_r1316388330

Reply via email to