On Tue, 5 Sep 2023 20:15:26 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> I think that Type/Style/Locale forming a specific pattern is an >> implementation detail, so I would not describe it in the spec (although as >> you say they form a specific pattern in the impl). It could be that an impl >> of 3-arg getInstance() can be independent of patterns described in 1-arg >> getInstance(). > > Type and Style select a pattern defined for the locale. (for the zero arg and > three arg getInstance methods). > I think I would avoid the term "concatenation", the type defines a pattern > that contains punctuation and connecting words. The style selects among the > full, short, and narrow patterns. I thought they're already a part of the public API described in the current javadoc, e.g. ListFormat.Style and ListFormat.Type (https://cr.openjdk.org/~naoto/JDK-8041488-ListPatterns-PR/api.00/java.base/java/text/ListFormat.html). I thought you meant to support general patterns (the List Patterns) and a few (specific) "type attributes" as in the LDML spec. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15130#discussion_r1316375403