On Thu, 6 Jun 2024 12:41:17 GMT, Alexey Semenyuk wrote:
> jpackage allows override of main WiX source file (main.wxs), do you know what
> will happen if user will add main.wxs with format features available only in
> WiX 5 and will have WiX 5 toolkit installed?
@alexeysemenyukoracle Related qu
On Wed, 30 Aug 2023 19:07:53 GMT, Oliver Kopp wrote:
> Fixes https://bugs.openjdk.org/browse/JDK-8315383
This pull request has now been integrated.
Changeset: ea5aa61c
Author: Oliver Kopp
Committer: Mandy Chung
URL:
https://git.openjdk.org/jdk/com
> Fixes https://bugs.openjdk.org/browse/JDK-8315383
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
Remove obsolete imports
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15495/files
- new: ht
Fixes https://bugs.openjdk.org/browse/JDK-8315383
-
Commit messages:
- 8315383: jlink SystemModulesPlugin incorrectly parses the options
Changes: https://git.openjdk.org/jdk/pull/15495/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15495&range=00
Issue: https://bugs.openj
On Thu, 10 Aug 2023 21:42:41 GMT, Christoph wrote:
> Add new test case with sample modules that contains some
> requires/exports/uses/provides.
>
> We are just unsure if and how we should add some last step of verificaiton
> with the extracted and decompiled class.
>
> Follow up task from htt
On Wed, 5 Jul 2023 23:30:03 GMT, Oliver Kopp wrote:
>> It's looking pretty good.
>>
>> About the test, I don't see `ArrayList::add` in the generated bytecode of
>> `sub2-13`. The dedup string set is used for the targets of qualified
>> exports an
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
&g
On Wed, 5 Jul 2023 23:37:28 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 30 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into fix-8
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The pu
On Wed, 5 Jul 2023 17:25:03 GMT, Mandy Chung wrote:
> It's looking pretty good.
Thank you!
> About the test, I don't see `ArrayList::add` in the generated bytecode of
> `sub2-13`. The dedup string set is used for the targets of qualified exports
> and opens and uses. The modifiers set of `req
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The pu
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revisi
On Mon, 3 Jul 2023 20:22:30 GMT, Mandy Chung wrote:
> Thanks for the update. Some comments below.
Thank you for the feedback! I didn't see the "proper" usage of effectively
final variables.
> The test you add does not cause new locals be defined in the helper methods.
> Do you think you can
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with one additional
commit since the las
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The pu
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revisi
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with two additional
commits since the last r
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last r
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revisi
On Mon, 3 Jul 2023 17:09:35 GMT, Mandy Chung wrote:
>> What I meant here is to change the `configure` method to allow the plugin to
>> take an argument for example
>>
>> --system-modules batch-size=100
>>
>>
>> This argument is optional. If not specified, the default value is 75.
>>
On Mon, 3 Jul 2023 20:00:40 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix test
>> - Fix ArrayList initialization and off-by-one errors
>
> src/jdk
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The pu
On Sat, 1 Jul 2023 18:36:10 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 6
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with two additional
commits since the last revis
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with two additional
commits since the last revi
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with one additional
commit since the la
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revisi
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The pu
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with three additional
commits since the last re
On Thu, 29 Jun 2023 20:58:53 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/System
On Thu, 29 Jun 2023 20:26:58 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> test/jdk/tools/jlink/JLink100Modules.java line 40:
>
>> 38
On Thu, 29 Jun 2023 17:37:02 GMT, Alan Bateman wrote:
> The size of the generated moduleDescriptors is a function of the number of
> modules, the number of packages in the modules, number of exports, ... I
> think your approach is okay for now, meaning pick some threshold that you are
> confid
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with one additional
commit since t
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The increme
On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five addi
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The increme
On Mon, 12 Jun 2023 05:47:41 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 6
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The increme
On Mon, 12 Jun 2023 05:02:07 GMT, Alan Bateman wrote:
> Do you mind fixing all the comments as these 160+ lines
Done. I copied the (for me) important comments to the GitHub reply
https://github.com/openjdk/jdk/pull/14408#issuecomment-1586615579.
> You had fixed that in the original PR but it l
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
&g
n several smaller methods
>
> This is a follow-up to https://github.com/openjdk/jdk/pull/10704. GitHub did
> not allow me to re-open the PR, because I did a force-push to have one commit.
Oliver Kopp has updated the pull request incrementally with two additional
commits since the la
Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
"MethodTooLargeException thrown while creating a jlink image".
Java still has a 64kb limit: A method may not be longer than 64kb. The idea of
the fix is to split up the generated methods in several smaller methods
This is a fol
On Thu, 13 Oct 2022 21:15:16 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
&g
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote:
> This refs [8306038](https://bugs.openjdk.org/browse/JDK-8306038)
>
> (Before this referenced 8240567)
>
> Although this change is rather small, I think, it's good to have a "more
> clean" SystemModulesPlu
On Mon, 17 Apr 2023 08:21:11 GMT, Alan Bateman wrote:
> This looks right. I assume you've checked `java
> -XX:+UnlockDiagnosticVMOptions -XX:+BytecodeVerificationLocal -version` as
> this code is not normally verified
koppor@DESKTOP-KAK953S
/cygdrive/c/git-repositories/jdk/jdk/build/windows-
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote:
> This refs [https://bugs.openjdk.org/browse/JDK-8306038](8306038).
>
> (Before this referenced 8240567)
>
> Although this change is rather small, I think, it's good to have a "more
> clean" SystemModule
On Wed, 12 Apr 2023 09:43:11 GMT, Alan Bateman wrote:
> I think you've got the wrong JBS issue, JDK-8240567 is about changing the
> SystemModulesPlugin to avoid the 64k limit on method size.
For me, it's the correct one. I was not sure which one to link. I can also drop
the reference.
More ba
This refs [https://bugs.openjdk.org/browse/JDK-82405679](8240567). Does NOT fix
it, but cleanup `SystemModulesPlugin` a bit to ease working on the bug itself.
Although this change is rather small, I think, it's good to have a "more clean"
SystemModulesPlugin available.
-
Commit mes
n several smaller methods
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
Try other way
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10704/files
- new: https://git.openjdk.org/jdk/pull/10704/files/2a381bde..f33fff2b
n several smaller methods
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
remove whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10704/files
- new: https://git.openjdk.org/jdk/pull/10704/files/5fc6e3d5..2
n several smaller methods
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
Readd creation of helper methods for splitting up modules
Co-authored-by: Oliver Kopp
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
n several smaller methods
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
use jlinktask assertSuccess
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10704/files
- new: https://git.openjdk.org/jdk/pull/10704/files/76
n several smaller methods
Oliver Kopp has updated the pull request incrementally with two additional
commits since the last revision:
- remove debug output
- Fix inner loop, now we get the method too large exception
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
n several smaller methods
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 18 additional commits since the
last revision:
- Merge remote-
n several smaller methods
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 13 additional commits since the
last revision:
- More recurs
n several smaller methods
Oliver Kopp has updated the pull request incrementally with two additional
commits since the last revision:
- Refine tests
Co-authored-by: Christoph
Co-authored-by: Carl Christian Snethlage
<50491877+calix...@users.noreply.github.com>
- Revert to origina
n several smaller methods
Oliver Kopp has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains ten additional commits since the
last revision:
- Merge remote-track
On Tue, 6 Dec 2022 16:46:02 GMT, Alan Bateman wrote:
> Would it be possible to paste in a summary on the VerifyError with the
> previous iteration?
Isn't this https://github.com/openjdk/jdk/pull/10704#issuecomment-1286106503?
Type top (current frame, locals[15]) is not assignable to refere
n several smaller methods
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
Refine test
Co-authored-by: Christoph
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10704/files
- new: https://git.openjdk.org/jdk/
n several smaller methods
Oliver Kopp has updated the pull request incrementally with two additional
commits since the last revision:
- Adapt number to have javac working (and refine test)
- Remove obsolete comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
On Sun, 16 Oct 2022 16:22:44 GMT, Alan Bateman wrote:
> I think there are still issues. As a quick test, set the maximum number of
> descriptors to generate per method to less than 70, so that you get Sub0,
> Sub1, ... generated. Then try `java -Xlog:init=debug
> -XX:+UnlockDiagnosticVMOptions
On Fri, 14 Oct 2022 16:07:44 GMT, Alan Bateman wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reduce number of included ModuleDescriptors
>
> src/jdk.jlink/share/classes/jd
On Fri, 14 Oct 2022 12:25:43 GMT, Alan Bateman wrote:
> Can you look at the tests in test/jdk/tools/jlink, that is where we will need
> to add the test for this.
I looked and started to create some Java files at [`7c39bd3`
(#10704)](https://github.com/openjdk/jdk/pull/10704/commits/7c39bd3ec82
n several smaller methods
Oliver Kopp has updated the pull request incrementally with two additional
commits since the last revision:
- Begin to craft test
- Reduce comment text
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10704/files
- new: https://git.openjdk.org/jdk/
n several smaller methods
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
Reduce number of included ModuleDescriptors
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10704/files
- new: https://git.openjdk.org/jdk/
n several smaller methods
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
Fix generated RETURN statement
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10704/files
- new: https://git.openjdk.org/jdk/pull/10704/files/44
Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
"MethodTooLargeException thrown while creating a jlink image".
Java still has a 64kb limit: A method may not be longer than 64kb. The idea of
the fix is to split up the generated methods in several smaller methods
-
67 matches
Mail list logo
