On Thu, 6 Jun 2024 12:41:17 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
> jpackage allows override of main WiX source file (main.wxs), do you know what > will happen if user will add main.wxs with format features available only in > WiX 5 and will have WiX 5 toolkit installed? @alexeysemenyukoracle Related question: Generation of `main.wxs` was moved from `prepareMainProjectFile` to `buildMSI`. This breaks [our patches to](https://github.com/JabRef/jabref/blob/95dcbe64659ced52627e012f2b6b5a60a9bb21b1/buildres/windows/JabRef-post-image.wsf#L18) `main.wxs` (which used to work for 6+ years now) Quoting https://docs.oracle.com/en/java/javase/24/jpackage/override-jpackage-resources.html#GUID-62412365-821D-4736-A20D-70F2D47136D8, the `post-image` script is executed before `buildMSI` (which is right). > Custom script that is **executed after the application image** is created and > **before the MSI installer is built** for both .msi and .exe packages. No > default script is provided. I would expect that all files are available before the "Post-image script" are available - and not generated **after** any **Post**-image script is run. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19318#issuecomment-2832153958
