On Fri, 14 Oct 2022 16:07:44 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reduce number of included ModuleDescriptors > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > line 705: > >> 703: // Here the method is "manually split" based on the >> heuristics that 99 ModuleDescriptors are smaller than 64kb >> 704: // The other implementation possibility is to use msplit >> (https://github.com/cretz/msplit). However, this seemed too much effort. >> 705: for (int index = 0; index < moduleInfos.size(); index++) { > > This comment will need to be cleaned up a bit to remove the reference to the > "msplit" project and changed to be more consistent with the existing comments. I found the existing comments in the code pretty short. I am belonging to the "architectural decisions group" strengthening the need of listing "options" one choose from. See https://adr.github.io/madr/ for more information. I will delete the comment. ------------- PR: https://git.openjdk.org/jdk/pull/10704
