On Thu, 17 Apr 2025 03:37:03 GMT, Hao Sun wrote:
> I was wondering if `--disable-java-warnings-as-errors` could help to address
> your concern about this PR.
It doesn't address the issue unless it's configured by default, which I don't
think is being proposed. I think the best approach would b
On Fri, 28 Mar 2025 09:26:45 GMT, Alan Bateman wrote:
> > @AlanBateman Can you review this if this patch looks good in principle?
>
> It needs confirmation that it doesn't break the build, I haven't looked into
> which parts of Liam's change weren't backed out. So if there are no build
> issue
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 14 commits:
-
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated c
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote:
>> The UnsafeOps JMH benchmark fails with the following error:
>>
>> ```
>> java.lang.IllegalAccessError: class
>> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
>> access class jdk.internal.misc.Unsafe
On Thu, 23 Jan 2025 05:42:33 GMT, Liam Miller-Cushon wrote:
> This change fixes an incorrect call to `printf` for a failure message in
> `CLDRDisplayNamesTest`.
This pull request has now been integrated.
Changeset: d9d2e19f
Author: Liam Miller-Cushon
URL:
https://git.openj
This change fixes an incorrect call to `printf` for a failure message in
`CLDRDisplayNamesTest`.
-
Commit messages:
- 8348365: Bad format string in CLDRDisplayNamesTest
Changes: https://git.openjdk.org/jdk/pull/23252/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23252&ra
On Wed, 18 Dec 2024 02:38:28 GMT, Liam Miller-Cushon wrote:
> Please consider this fix for
> [JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an
> `ExceptionInInitializerError` in the class initializer of
> `XMLDocumentFragmentScannerImpl` and other classes
kXmlUtils`. The change breaks the cycle by
> moving some initialization out of the class initializer of `JdkXmlUtils`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the
On Mon, 2 Dec 2024 16:50:20 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request with a new target base
kXmlUtils`. The change breaks the cycle by
> moving some initialization out of the class initializer of `JdkXmlUtils`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the
On Wed, 18 Dec 2024 07:54:05 GMT, Alan Bateman wrote:
> No objection to the change but is this only an issue when something is
> reflectively load java.xml internal classes? Can it arise when using just the
> exported/supported API?
I don't know a way to reproduce it using the supported API, t
Please consider this fix for
[JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an
`ExceptionInInitializerError` in the class initializer of
`XMLDocumentFragmentScannerImpl` and other classes that have a circular
dependency on `jdk.xml.internal.JdkXmlUtils`. The change bre
On Fri, 22 Nov 2024 13:42:32 GMT, Jan Lahoda wrote:
> There is a new preview language feature, `requires transitive java.base;`.
> And the `java.se` module is permitted to use the feature, without being
> marked as preview (i.e. the `java.se` module participates in preview). This
> is currentl
On Mon, 2 Dec 2024 16:50:20 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request with a new target base
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated c
On Tue, 9 Jul 2024 23:17:47 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request incrementally with
On Fri, 24 May 2024 15:32:09 GMT, Liam Miller-Cushon wrote:
> This change fixes a bug preventing javac from emitting
> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
> non-default value. The diagnostics are currently emitted for values of
> `-
On Mon, 21 Oct 2024 17:56:23 GMT, Vicente Romero wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Migrate another use of sun.misc.Unsafewq
>
> lgtm
@vicente-romero-oracle coul
he is a redo of [JDK-8331081](https://bugs.openjdk.org/browse/JDK-8331081),
> which was backed out in
> [JDK-8332740](https://bugs.openjdk.org/browse/JDK-8332740) due to a build
> failure in the microbenchmarks.
Liam Miller-Cushon has updated the pull request with a new target base due to
On Tue, 9 Jul 2024 23:17:47 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request incrementally with
he is a redo of [JDK-8331081](https://bugs.openjdk.org/browse/JDK-8331081),
> which was backed out in
> [JDK-8332740](https://bugs.openjdk.org/browse/JDK-8332740) due to a build
> failure in the microbenchmarks.
Liam Miller-Cushon has updated the pull request incrementally with one
addi
he is a redo of [JDK-8331081](https://bugs.openjdk.org/browse/JDK-8331081),
> which was backed out in
> [JDK-8332740](https://bugs.openjdk.org/browse/JDK-8332740) due to a build
> failure in the microbenchmarks.
Liam Miller-Cushon has updated the pull request with a new target base due to
On Tue, 9 Jul 2024 23:17:47 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request incrementally with
On Fri, 19 Jul 2024 15:36:10 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4
Hi,
I have a data point to share on the compatibility impact of
JDK-8325621 (Improve jspawnhelper version checks), which was
backported to earlier release trains.
As a result of that change, doing an in-place upgrade from 22.0.1 to
22.0.2 breaks long-running Java applications that create subproce
On Fri, 24 May 2024 15:32:09 GMT, Liam Miller-Cushon wrote:
> This change fixes a bug preventing javac from emitting
> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
> non-default value. The diagnostics are currently emitted for values of
> `-
On Fri, 19 Jul 2024 19:35:14 GMT, Liam Miller-Cushon wrote:
> This change deduplicates constants in ZipConstants64 for the Zip64 Extended
> Information Extra Field Header ID (see APPNOTE.TXT 4.5.3).
>
> I think there are arguments for consolidating on either `EXTID_ZIP64` or
&g
I
> was only looking at one of the constants.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three additional
commits since the la
On Fri, 19 Jul 2024 19:35:14 GMT, Liam Miller-Cushon wrote:
> This change deduplicates constants in ZipConstants64 for the Zip64 Extended
> Information Extra Field Header ID (see APPNOTE.TXT 4.5.3).
>
> I think there are arguments for consolidating on either `EXTID_ZIP64` or
&g
On Fri, 19 Jul 2024 15:18:26 GMT, Lance Andersen wrote:
>> src/java.base/share/native/libjli/parse_manifest.c line 507:
>>
>>> 505: || censiz == ZIP64_MAGICVAL
>>> 506: || cenoff == ZIP64_MAGICVAL)
>>> 507: && cenext > 0) {
>>
>> I went throug
This change deduplicates constants in ZipConstants64 for the Zip64 Extended
Information Extra Field Header ID (see APPNOTE.TXT 4.5.3).
I think there are arguments for consolidating on either `EXTID_ZIP64` or
`ZIP64_EXTID`. The PR currently consolidates on `EXTID_ZIP64`, `ZIP64_EXTID` is
also an
in the central directory it is stored in a
> 'Zip64 Extended Information Extra Field'.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Use /* instead of /** comments
-
Changes:
- all: https://git.op
On Fri, 19 Jul 2024 13:19:52 GMT, Jaikiran Pai wrote:
>> Liam Miller-Cushon has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains
On Tue, 4 Jun 2024 17:43:24 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As des
in the central directory it is stored in a
> 'Zip64 Extended Information Extra Field'.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull
On Thu, 18 Jul 2024 14:55:31 GMT, Jaikiran Pai wrote:
>> Liam Miller-Cushon has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains ei
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Update test/jdk/java/util/Coll
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Update copyright year
and a
On Tue, 9 Jul 2024 22:43:05 GMT, Chen Liang wrote:
> All three files can have their copyright year updated.
Done
-
PR Comment: https://git.openjdk.org/jdk/pull/18522#issuecomment-2218861123
On Tue, 9 Jul 2024 22:23:57 GMT, Chen Liang wrote:
> Would you mind changing "Calling any mutator method on the Map will ..." to
> something like "... on the map or any derived view collection will ..." to
> emphasize our new consistency? (Our internal conversation agreed on this)
Done! Kevin
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Update unmodifiable map j
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated c
On Tue, 9 Jul 2024 17:43:32 GMT, Chen Liang wrote:
>> `testCollMutatorsAlwaysThrow` expects a `Collection` (not e.g. a
>> `Collection>`). MOAT could be refactored to handle
>> that case. Do you think that's worth it, or have thoughts about what the
>> cleanest way to do that would be?
>
> Ther
On Mon, 8 Jul 2024 20:39:38 GMT, Chen Liang wrote:
>> Liam Miller-Cushon has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains
On Fri, 24 May 2024 15:32:09 GMT, Liam Miller-Cushon wrote:
> This change fixes a bug preventing javac from emitting
> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
> non-default value. The diagnostics are currently emitted for values of
> `-
On Tue, 4 Jun 2024 17:43:24 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As des
in the central directory it is stored in a
> 'Zip64 Extended Information Extra Field'.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The
This change fixes a bug preventing javac from emitting
'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
non-default value. The diagnostics are currently emitted for values of
`--release`, and for the default value of `--system`.
The is a redo of [JDK-8331081](https://bugs.o
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated c
On Thu, 4 Apr 2024 16:57:40 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As des
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated c
On Mon, 27 May 2024 12:18:23 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/ImmutableCollections.java line 1323:
>>
>>> 1321: @Override
>>> 1322: public int hashCode() {
>>> 1323: return MapN.this.hashCode();
>>
>> The hash co
On Thu, 4 Apr 2024 16:57:40 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As des
On Wed, 27 Mar 2024 17:36:28 GMT, Liam Miller-Cushon wrote:
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Please keep this open
-
PR Comment: https://git.openjdk.org/jdk/pull
On Thu, 4 Apr 2024 09:42:48 GMT, Jaikiran Pai wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add some more comments
>
> test/jdk/java/util/zip/Zip64Offsets.java line 1:
>
in the central directory it is stored in a
> 'Zip64 Extended Information Extra Field'.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Move test to test/jdk/tools/launcher
-
Changes:
- all: https:
On Fri, 29 Mar 2024 18:25:18 GMT, Jiangli Zhou wrote:
>> it's in APPNOTE.TXT 4.5, the extra field structure is `header1+data1 +
>> header2+data2 . . .`, and we have to iterate through to see if there's an
>> entry that's a zip64 extended information extra field
>
> Thanks! That's helpful. I cou
in the central directory it is stored in a
> 'Zip64 Extended Information Extra Field'.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Add some more comments
-
Changes:
- all: https://git.openjdk.o
On Fri, 29 Mar 2024 17:40:59 GMT, Jiangli Zhou wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make cendsk an unsigned short
>
> src/java.base/share/native/libjli/parse_
On Fri, 29 Mar 2024 19:54:31 GMT, Jiangli Zhou wrote:
>> I think it doesn't matter, because the validation below only uses `cenoff`.
>> If `cenoff` fits in 32 bits, we don't need to read the zip64 extra info.
>
> Thanks for the explanation. Could you please add a comment with the info
> above t
On Sat, 30 Mar 2024 17:28:11 GMT, Jiangli Zhou wrote:
>> I think that's similar idea to one of the alternatives I mentioned earlier,
>> won't that allocate for every central directory entry? This callsite has
>> already read the data we need into a buffer, if we end up doing something
>> like
On Sat, 30 Mar 2024 03:21:39 GMT, Jiangli Zhou wrote:
>> The other loop uses `readAt` to read in additional data and advance through
>> the extra fields, this loop already has access to a buffer that contains all
>> of the data for the extra fields and doesn't need to do that.
>>
>> I consider
On Fri, 29 Mar 2024 18:24:23 GMT, Jiangli Zhou wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Maximum Zip64 extra field length is 32
>
> src/java.base/share/native/li
On Fri, 29 Mar 2024 18:28:37 GMT, Jiangli Zhou wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Maximum Zip64 extra field length is 32
>
> src/java.base/share/native/li
On Fri, 29 Mar 2024 18:03:13 GMT, Jiangli Zhou wrote:
>> There can be multiple extra fields, and the zip64 extended information may
>> not be the first one
>
> Could you please point to the related spec for the other `extra field`?
it's in APPNOTE.TXT 4.5, the extra field structure is `header1+
On Fri, 29 Mar 2024 17:43:36 GMT, Jiangli Zhou wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make cendsk an unsigned short
>
> src/java.base/share/native/libjli/parse_
On Fri, 29 Mar 2024 17:32:11 GMT, Jiangli Zhou wrote:
>> Thanks for the catch, I had missed that the disk start number is 4 bytes and
>> not 8. I pushed a commit. I also removed some unused references to the disk
>> number, which is only being used to validate the size of the zip64 extended
>>
in the central directory it is stored in a
> 'Zip64 Extended Information Extra Field'.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Maximum Zip64 extra field length is 32
-
Changes:
- all: https:
On Wed, 27 Mar 2024 21:49:10 GMT, Chen Liang wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> src/java.base/share/classes/java/util/ImmutableCollections.java line 1321:
>
>> 1319:
This change overrides mutator methods in the implementation returned by
`Map.of().entrySet()` to throw `UnsupportedOperationException`.
-
Commit messages:
- Use AbstractImmutableSet
- Throw UOE for all Map.of().entrySet() mutator methods
- 8328821: Make the ImmutableCollections cl
in the central directory it is stored in a
> 'Zip64 Extended Information Extra Field'.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Make cendsk an unsigned short
-
Changes:
- all: https://git.op
On Wed, 27 Mar 2024 03:18:42 GMT, Jiangli Zhou wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix disk number size
>
> src/java.base/share/native/libjli/manifest_inf
in the central directory it is stored in a
> 'Zip64 Extended Information Extra Field'.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Fix disk number size
-
Changes:
- all: https://git.openjdk.o
On Wed, 27 Mar 2024 03:19:47 GMT, Jiangli Zhou wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As described in APPNOTE.TXT
>> 4.5.3, the
This change fixes a zip64 bug in the launcher that is prevent it from reading
the manifest of jars where the 'relative offset of local header' field in the
central directory entry is >4GB. As described in APPNOTE.TXT 4.5.3, the offset
is too large to be stored in the central directory it is stor
On Wed, 30 Nov 2022 18:48:30 GMT, Liam Miller-Cushon wrote:
> This causes jar to not compress the `META-INF/` directory entry, for
> consistency with the handling of other directory entries and compliance with
> `APPNOTE.TXT`, and for compatibility with other zip implementations.
On Thu, 1 Dec 2022 11:44:11 GMT, Lance Andersen wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve test
>
> test/jdk/tools/jar/ManifestDirectoryCompression.java line 8
> This causes jar to not compress the `META-INF/` directory entry, for
> consistency with the handling of other directory entries and compliance with
> `APPNOTE.TXT`, and for compatibility with other zip implementations.
Liam Miller-Cushon has updated the pull request incrementally
On Thu, 1 Dec 2022 11:44:07 GMT, Lance Andersen wrote:
>> Unfortunately it's recursing on `cleanup` in the lambda, so it can't throw
>> checked exceptions without more refactoring. This is imitating the recursive
>> deletion approach in another jar test, I'm happy to swap this out if you'd
>>
> This causes jar to not compress the `META-INF/` directory entry, for
> consistency with the handling of other directory entries and compliance with
> `APPNOTE.TXT`, and for compatibility with other zip implementations.
Liam Miller-Cushon has updated the pull request incrementally
On Wed, 30 Nov 2022 22:15:14 GMT, Lance Andersen wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use TestNG, and assert on the compression method
>
> test/jdk/tools/jar/Manifest
> This causes jar to not compress the `META-INF/` directory entry, for
> consistency with the handling of other directory entries and compliance with
> `APPNOTE.TXT`, and for compatibility with other zip implementations.
Liam Miller-Cushon has updated the pull request incrementally
On Wed, 30 Nov 2022 18:48:30 GMT, Liam Miller-Cushon wrote:
> This causes jar to not compress the `META-INF/` directory entry, for
> consistency with the handling of other directory entries and compliance with
> `APPNOTE.TXT`, and for compatibility with other zip implementations.
T
This causes jar to not compress the `META-INF/` directory entry, for
consistency with the handling of other directory entries and compliance with
`APPNOTE.TXT`, and for compatibility with other zip implementations.
-
Commit messages:
- 8297875: jar should not compress the manifest
85 matches
Mail list logo
