On Fri, 19 Jul 2024 13:19:52 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Liam Miller-Cushon has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 10 >> additional commits since the last revision: >> >> - Add a missing `break` >> - Merge branch 'master' into JDK-8328995 >> - Merge remote-tracking branch 'origin/master' into JDK-8328995 >> - Move test to test/jdk/tools/launcher >> - Add some more comments >> - Maximum Zip64 extra field length is 32 >> - Make cendsk an unsigned short >> - Fix disk number size >> - Improvements >> >> * don't rely on variable length arrays >> * only run the test of 64 bit machines, since it requires >4GB of heap >> - 8328995: launcher can't open jar files where the offset of the manifest >> is >4GB > > src/java.base/share/native/libjli/parse_manifest.c line 186: > >> 184: } >> 185: >> 186: /** > > Nit: For the sake of consistency with the rest of the comments in this file, > this comment should be a `/*` instead of `/**` Fixed, thanks ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18479#discussion_r1684551384
