On Tue, 4 Jun 2024 17:43:24 GMT, Liam Miller-Cushon <cus...@openjdk.org> wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from >> reading the manifest of jars where the 'relative offset of local header' >> field in the central directory entry is >4GB. As described in APPNOTE.TXT >> 4.5.3, the offset is too large to be stored in the central directory it is >> stored in a 'Zip64 Extended Information Extra Field'. > > Liam Miller-Cushon has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains eight additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into JDK-8328995 > - Move test to test/jdk/tools/launcher > - Add some more comments > - Maximum Zip64 extra field length is 32 > - Make cendsk an unsigned short > - Fix disk number size > - Improvements > > * don't rely on variable length arrays > * only run the test of 64 bit machines, since it requires >4GB of heap > - 8328995: launcher can't open jar files where the offset of the manifest is > >4GB For what it's worth I have been testing the current version of the PR at Google, and have verified it allows jars with >4GB offsets to be launched, and we haven't observed any regressions using it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18479#issuecomment-2237656114
