On Thu, 9 Nov 2023 16:49:41 GMT, Gaurav Chaudhari wrote:
> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
> When running without security manager, the test references 'badfactoty.jar'
> instead of 'badfactory.jar'. This change address
On Sat, 25 Nov 2023 16:45:07 GMT, Eirik Bjorsnos wrote:
>>> Reviewer time is a scarce resource. It would be wasteful to spend review
>>> cycles on getting a fix of this `.sh` test integrated now and then
>>> immediately follow up with a delete in the rewrite PR.
>>>
>>> I think we should handl
On Wed, 22 Nov 2023 18:01:21 GMT, Eirik Bjorsnos wrote:
>> @eirbjo Yes, as you noticed, the jar file does matter. And the reason I
>> suspected it wasn't noticed was because it was in the scenario of running
>> without security manager, So may that part of the code wasn't being actively
>> exe
> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
> When running without security manager, the test references 'badfactoty.jar'
> instead of 'badfactory.jar'. This change addresses this by correcting the jar
> name.
Gaurav Chaudha
On Wed, 22 Nov 2023 11:32:13 GMT, Eirik Bjorsnos wrote:
>>> Looks okay. This test is begging to be re-written in Java, maybe some day.
>>>
>>> I assume the copyright header will be updated before this change is
>>> integrated.
>>
>> Hi @AlanBateman, do I have to update the copyright year to 20
On Tue, 21 Nov 2023 16:36:26 GMT, Alan Bateman wrote:
> Looks okay. This test is begging to be re-written in Java, maybe some day.
>
> I assume the copyright header will be updated before this change is
> integrated.
Hi @AlanBateman, do I have to update the copyright year to 2023 manually and
The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
When running without security manager, the test references 'badfactoty.jar'
instead of 'badfactory.jar'. This change addresses this by correcting the jar
name.
-
Commit messages:
- 8319668: Fixup of jar
On Tue, 28 Jun 2022 18:52:32 GMT, Gaurav Chaudhari wrote:
> This is a REDO of the Fix that was incompletely implemented earlier:
> [8285838: Fix for TZ environment variable DST
> rules](https://github.com/openjdk/jdk/pull/8660)
>
> Offset calculation now accounts all the way upt
ffset)_
> Sample output:
> 
Gaurav Chaudhari has updated the pull request incrementally with one additional
commit since the last revision:
8288377: Adjusted length check for retur
ffset)_
> Sample output:
> 
Gaurav Chaudhari has updated the pull request incrementally with one additional
commit since the last revision:
8288377: Added GMT0 corner case and minor
On Thu, 30 Jun 2022 20:05:05 GMT, Naoto Sato wrote:
>> Gaurav Chaudhari has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8288377: Simplified TZ offset calc and consolidate MACOS impl.
>
> src/java.base/uni
On Tue, 28 Jun 2022 18:52:32 GMT, Gaurav Chaudhari wrote:
> This is a REDO of the Fix that was incompletely implemented earlier:
> [8285838: Fix for TZ environment variable DST
> rules](https://github.com/openjdk/jdk/pull/8660)
>
> Offset calculation now accounts all the way upt
ffset)_
> Sample output:
> 
Gaurav Chaudhari has updated the pull request incrementally with one additional
commit since the last revision:
8288377: Simplified TZ offset calc and co
On Tue, 28 Jun 2022 22:15:39 GMT, Naoto Sato wrote:
>> This is a REDO of the Fix that was incompletely implemented earlier:
>> [8285838: Fix for TZ environment variable DST
>> rules](https://github.com/openjdk/jdk/pull/8660)
>>
>> Offset calculation now accounts all the way upto year in order t
This is a REDO of the Fix that was incompletely implemented earlier:
[8285838: Fix for TZ environment variable DST
rules](https://github.com/openjdk/jdk/pull/8660)
Offset calculation now accounts all the way upto year in order to avoid
cross-day miscalculations as well as to calculate always in
15 matches
Mail list logo
