On Tue, 28 Jun 2022 18:52:32 GMT, Gaurav Chaudhari <d...@openjdk.org> wrote:

> This is a REDO of the Fix that was incompletely implemented earlier:
> [8285838: Fix for TZ environment variable DST 
> rules](https://github.com/openjdk/jdk/pull/8660)
> 
> Offset calculation now accounts all the way upto year in order to avoid 
> cross-day miscalculations as well as to calculate always in the correct 
> direction for offset. In situations where there may be multiple days, the 
> excess days of offset will be shaved off by applying mod to `seconds_per_day` 
> , which will remove the excessive days that might be included in the offset 
> calculation for special scenarios like a leap year / February months and 
> variances between 30 and 31 days.
> 
> I have tested this solution with the cases where this fix had failed last 
> time as well, and confirmed it works:
> _(where 7200 represents 7200 seconds -> +2 hour offset)_
> Sample output:
> ![image](https://user-images.githubusercontent.com/6877595/176259828-07e27901-4a3f-4949-bd8d-2f88c979685a.png)

This pull request has now been integrated.

Changeset: 3c325641
Author:    Gaurav Chaudhari <dei...@hotmail.com>
Committer: Naoto Sato <na...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/3c3256414f7df049cdd6c8519fbcea0d818a1a33
Stats:     126 lines in 2 files changed: 86 ins; 28 del; 12 mod

8288377: [REDO] DST not applying properly with zone id offset set with TZ env 
variable

Reviewed-by: naoto

-------------

PR: https://git.openjdk.org/jdk/pull/9312

Reply via email to