On Sat, 25 Nov 2023 16:45:07 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:
>>> Reviewer time is a scarce resource. It would be wasteful to spend review >>> cycles on getting a fix of this `.sh` test integrated now and then >>> immediately follow up with a delete in the rewrite PR. >>> >>> I think we should handle this change in one PR, not two. If you prefer to >>> keep the history of your `.sh` fix documented, we can repurpose this PR, >>> otherwise we start fresh with a new PR for the rewrite. >> >> The change here is trivial, it's okay to integrate and use a separate >> issue/PR to replace the shell test. I can't tell from the bug report if this >> was just noticed in passing or it actually failed (maybe on an IBM port). > >> The change here is trivial, it's okay to integrate and use a separate >> issue/PR to replace the shell test. > > Fair point, I filed https://bugs.openjdk.org/browse/JDK-8320712 to track the > rewrite. > > @Deigue, would you like to contribute a PR for the rewrite as well? If not, > I'll be happy to take on this task. Thanks @eirbjo, I dont directly have committer status for creating openjdk bugs myself. You can go ahead and contribute the PR in that case. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16585#issuecomment-1828215999
