On Fri, 25 Apr 2025 14:49:37 GMT, Aleksey Shipilev wrote:
> CDS cannot handle large number of classes, because `ClassLoader` data
> structures get too large for CDS archival. The new test captures such an
> occasion. We do `clear()`-s, but that is not enough to trim the backing
> storages for
On Fri, 18 Apr 2025 01:41:36 GMT, Ioi Lam wrote:
>>> Do we have a test case where `--add-opens` is used both at dump time and
>>> run time? That will verify that `--add-opens` at dump time is correctly
>>> processed.
>>>
>>
>> Yes, the new test `AddopensOption.java` uses the `--add-opens` bot
On Wed, 16 Apr 2025 18:21:41 GMT, Calvin Cheung wrote:
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tier
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated t
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated t
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated t
On Mon, 21 Apr 2025 18:39:39 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam comment
>
> src/java.base/share/classes/jdk/internal/module/ModuleBoot
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated t
On Fri, 18 Apr 2025 01:41:36 GMT, Ioi Lam wrote:
>
> AddopensOption.java only checks if the --add-opens is accepted. It doesn't
> check if the option has any effect. I think it's better to run `TEST_MODULE1`
> to make sure that `setAccessible` can be called without throwing an
> exception. Th
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated t
On Thu, 17 Apr 2025 21:21:22 GMT, Ioi Lam wrote:
> Do we have a test case where `--add-opens` is used both at dump time and run
> time? That will verify that `--add-opens` at dump time is correctly processed.
>
Yes, the new test `AddopensOption.java` uses the `--add-opens` both at dump
time a
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated t
On Thu, 17 Apr 2025 07:38:27 GMT, Timofei Pushkin wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/customLoader/RegUnregSuperTest.java
>> line 77:
>>
>>> 75: out.shouldContain("CustomLoadee3Child (id 3) has super-type
>>> CustomLoadee3 (id 1) overshadowed by another class with the s
On Wed, 16 Apr 2025 14:34:25 GMT, Timofei Pushkin wrote:
>> If a base class is package-private then its subclasses should have the same
>> package name and defining class loader, otherwise `IllegalAccessError` is
>> thrown when linking a subclass. Currently when dumping a static archive
>> sep
On Wed, 16 Apr 2025 07:50:00 GMT, Timofei Pushkin wrote:
>> src/java.base/share/classes/jdk/internal/misc/CDS.java line 390:
>>
>>> 388: @Override
>>> 389: public byte[] readClassFile(String className) throws
>>> IOException {
>>> 390: final var subPath =
This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
can be used during production run with --add-opens option as long as the same
set of options is used during assembly phase.
Passed tiers 1 - 4 testing.
-
Commit messages:
- trailing whitespace
- 8352003
On Wed, 16 Apr 2025 17:12:07 GMT, Ioi Lam wrote:
>> During an application's training run, it's possible to inject classes into
>> the built-in platform/app class loaders with reflection calls.
>>
>> - Before [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), only
>> the names of thes
On Wed, 16 Apr 2025 00:51:23 GMT, Ioi Lam wrote:
>> During an application's training run, it's possible to inject classes into
>> the built-in platform/app class loaders with reflection calls.
>>
>> - Before [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), only
>> the names of thes
On Sat, 12 Apr 2025 18:37:18 GMT, Ioi Lam wrote:
>> During an application's training run, it's possible to inject classes into
>> the built-in platform/app class loaders with reflection calls.
>>
>> - Before [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), only
>> the names of thes
On Mon, 14 Apr 2025 14:04:33 GMT, Timofei Pushkin wrote:
>> If a base class is package-private then its subclasses should have the same
>> package name and defining class loader, otherwise `IllegalAccessError` is
>> thrown when linking a subclass. Currently when dumping a static archive
>> sep
On Thu, 20 Mar 2025 04:46:21 GMT, Ioi Lam wrote:
> `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG).
>
> - Before this PR, when `--add-export` is specified, FMG is disabled, so AOT
> caches created with `-XX:+AOTClassLinking` cannot be loaded.
> - After this PR, if the
On Thu, 23 Jan 2025 02:04:33 GMT, Ioi Lam wrote:
>> I reimplemented
>> `SystemDictionaryShared::lookup_super_for_unregistered_class()` with Java
>> code. This removes hacks in
>> `SystemDictionary::resolve_with_circularity_detection()` to facilitate
>> future clean-ups there that are planned
On Wed, 22 Jan 2025 03:28:00 GMT, Ioi Lam wrote:
> I reimplemented
> `SystemDictionaryShared::lookup_super_for_unregistered_class()` with Java
> code. This removes hacks in
> `SystemDictionary::resolve_with_circularity_detection()` to facilitate future
> clean-ups there that are planned by @c
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.c. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
This pull
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.c. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
Than
On Wed, 18 Dec 2024 11:58:37 GMT, Jorn Vernee wrote:
>> How about the following?
>>
>>
>> jint result = (*VM)->AttachCurrentThreadAsDaemon(VM, (void**) &env, NULL);
>> if (result != JNI_OK) {
>> fprintf(stderr, "do_upcall trying to attach thread returned %d", result);
>> return;
>>
On Wed, 18 Dec 2024 05:21:55 GMT, Julian Waters wrote:
>> src/java.base/share/native/libfallbackLinker/fallbackLinker.c line 168:
>>
>>> 166: // attach thread
>>> 167: JNIEnv* env;
>>> 168: (*VM)->AttachCurrentThreadAsDaemon(VM, (void**) &env, NULL);
>>
>> I think the variable should be u
A simple fix for removing an unused variable in fallbacklinker.cpp. This is
needed for building zero jvm variant on macosx-x64.
Testing:
- [x] tier1
- [x] zero jvm variant build on macosx-x64
-
Commit messages:
- 8346132: fallbacklinker.cpp failed compilation due to unused variabl
On Wed, 20 Nov 2024 00:37:25 GMT, Calvin Cheung wrote:
> Currently, when retrieving a ClassFileStream during runtime, we call into the
> zip library to retrieve the stream based only on a class name. This doesn't
> work well if the class is in a multi-release jar under a versi
On Tue, 26 Nov 2024 04:06:22 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove assert in filemap.cpp
>
> Marked as reviewed by dholmes (Reviewer).
Thank
On Tue, 26 Nov 2024 00:29:15 GMT, David Holmes wrote:
>> I adapted the asserts from diagnosticCommand.cpp. I'm keeping the first
>> assert. Is it ok?
>
> Both asserts are unnecessary.
I've removed the assert. Will run some tests before integrating the fix.
Please re-review when you have a chanc
. To address this issue, this change
> calls the java api `ClassLoader.getResourceAsStream()` to retrieve the stream.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
re
. To address this issue, this change
> calls the java api `ClassLoader.getResourceAsStream()` to retrieve the stream.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
@dholmes-ora commen
On Mon, 25 Nov 2024 04:11:20 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update comments
>
> src/hotspot/share/cds/filemap.cpp line 2718:
>
>> 2716:
On Fri, 22 Nov 2024 11:07:31 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dholmes-ora comment
>
> src/java.base/share/classes/java/lang/ClassLoader.java l
. To address this issue, this change
> calls the java api `ClassLoader.getResourceAsStream()` to retrieve the stream.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
update comments
-
On Mon, 28 Oct 2024 16:16:14 GMT, Calvin Cheung wrote:
>> Summary of changes:
>>
>> Before dumping info the archive, all the module names from `--add-modules`
>> will be sorted and then concatenated into one string with comma as the
>> separator between modul
On Wed, 16 Oct 2024 22:46:40 GMT, Calvin Cheung wrote:
> Summary of changes:
>
> Before dumping info the archive, all the module names from `--add-modules`
> will be sorted and then concatenated into one string with comma as the
> separator between module names.
>
>
On Mon, 28 Oct 2024 09:09:35 GMT, Alan Bateman wrote:
>> Thanks, I'll get back to you on but I want see how this will behave with
>> ALL-MODULE-PATH as that will sometimes appear in Maven environments.
>
> I chatted with Calvin about this change. Testing that the root modules
> specified to --a
o has an addition argument `Set addModules`. It
> returns the `archivedModuleGraph` only if both the `mainModule` and the
> `addModules` are the same as the input arguments.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit
On Mon, 21 Oct 2024 13:17:10 GMT, Alan Bateman wrote:
>> Hi Alan,
>> I tried your suggestion but it can't handle the `ALL-SYSTEM` case.
>> I made some slight adjustments to your patch as follows:
>>
>>
>> /**
>> * Returns true if all modules named in the given set are in the
>> Config
o has an addition argument `Set addModules`. It
> returns the `archivedModuleGraph` only if both the `mainModule` and the
> `addModules` are the same as the input arguments.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commi
On Fri, 18 Oct 2024 11:26:30 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @rose00 comment
>
> src/java.base/share/classes/jdk/internal/module/ModuleBoot
On Wed, 16 Oct 2024 23:18:42 GMT, John R Rose wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @rose00 comment
>
> src/hotspot/share/classfile/modules.cpp line 697:
>
>>
o has an addition argument `Set addModules`. It
> returns the `archivedModuleGraph` only if both the `mainModule` and the
> `addModules` are the same as the input arguments.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit si
Summary of changes:
Before dumping info the archive, all the module names from `--add-modules` will
be sorted and then concatenated into one string with comma as the separator
between module names.
During runtime, same function will be used to obtain the string in the same
format with sorted m
On Tue, 17 Sep 2024 23:44:40 GMT, Calvin Cheung wrote:
> Prior to this patch, if `--module-path` is specified in the command line:
> during CDS dump time, full module graph will not be included in the CDS
> archive;
> during run time, full module graph will not be used.
>
&g
On Wed, 2 Oct 2024 05:50:14 GMT, Calvin Cheung wrote:
>> Prior to this patch, if `--module-path` is specified in the command line:
>> during CDS dump time, full module graph will not be included in the CDS
>> archive;
>> during run time, full module graph will not b
On Wed, 2 Oct 2024 02:13:40 GMT, David Holmes wrote:
> Nothing further from me on the VM side. Just a couple of minor nits.
>
> Thanks
I've pushed another commit to address the nits.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/21048#issuecomment-2387676650
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last rev
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last r
On Sun, 29 Sep 2024 06:43:42 GMT, Alan Bateman wrote:
>> Why does it need to clear `moduleToReader` only for app loader and not for
>> platform loader? Is it because the `moduleToReader` for the app loader may
>> contain reference to jar files that indirectly references some file system
>> obj
On Sun, 29 Sep 2024 04:11:53 GMT, Ioi Lam wrote:
>> It should work because the jmod file won't be added to the `module_paths`.
>
> In my scenario, will the FMG be used? If so, the program won't be able to
> load the code in mod2.jmod, so the behavior will be wrong. Could you add a
> test case f
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revi
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request with a new target base due to a
merge or a rebase. The pull
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last rev
On Fri, 27 Sep 2024 11:11:20 GMT, Alan Bateman wrote:
> Do you remember why resetArchivedStates resets the resource cache? I would
> expected it to be cleared for all class loaders.
>
I think it is because `resourceCache` is a `SoftReference` and it will fail the
check in `JavaClasses::is_sup
On Wed, 25 Sep 2024 00:11:32 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix indentation
>
> src/hotspot/share/cds/filemap.cpp line 956:
>
>> 954: }
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revi
On Tue, 24 Sep 2024 05:06:50 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> trailing whitespace
>
> src/java.base/share/classes/jdk/internal/module/ModuleBoot
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revi
On Sat, 21 Sep 2024 06:31:16 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> trailing whitespace
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferenc
On Wed, 18 Sep 2024 01:15:40 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> trailing whitespace
>
> src/hotspot/share/cds/filemap.cpp line 931:
>
>> 929
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last r
gs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275)
> in the bug report regarding some changes in the corelib classes.
Calvin Cheung has updated the pull request incrementally with one additional
commi
Prior to this patch, if `--module-path` is specified in the command line:
during CDS dump time, full module graph will not be included in the CDS archive;
during run time, full module graph will not be used.
With this patch, the full module graph will be included in the CDS archive with
the `--mo
On Mon, 2 Sep 2024 12:27:21 GMT, Alan Bateman wrote:
> This PR proposes changes to the ModuleBootstrap code that is used with CDS
> (Ahead-of-Time Class Loading & Linking in the future). At things stand, the
> module graph and boot layer can be archived at dump time (-Xshare:dump) when
> the i
On Mon, 20 May 2024 17:24:22 GMT, Ioi Lam wrote:
>> JavacBench is a test program that compiles 90 Java source files. It uses a
>> fair amount of invokedynamic callsites, so it's good for testing CDS support
>> for indy and lambda expressions.
>>
>> This test was first integrated into the
>> [
On Thu, 16 May 2024 17:44:22 GMT, Ioi Lam wrote:
>> JavacBench is a test program that compiles 90 Java source files. It uses a
>> fair amount of invokedynamic callsites, so it's good for testing CDS support
>> for indy and lambda expressions.
>>
>> This test was first integrated into the
>> [
On Wed, 21 Feb 2024 19:10:16 GMT, Calvin Cheung wrote:
> While generating holder classes (in `generateHolderClasses()`), don't add the
> `MethodType` to the `invokerTypes` if will fail the check in the `build()`
> method which would result in a `RuntimeException`.
>
&
On Fri, 8 Mar 2024 15:58:27 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam comments and copyright update
>
> Looks good. Just a small nit.
Thanks @ikla
ethodHandles` to check
> that the "Failed to generate LambdaForm holder classes" error is not in the
> output;
>
> Passed tiers 1 - 3 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
remove unused import
On Fri, 8 Mar 2024 15:58:16 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam comments and copyright update
>
> src/java.base/share/classes/java/lang/invoke/Generat
ethodHandles` to check
> that the "Failed to generate LambdaForm holder classes" error is not in the
> output;
>
> Passed tiers 1 - 3 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
@iklam co
On Wed, 6 Mar 2024 22:00:42 GMT, Ioi Lam wrote:
>> To avoid the CDS dump error message, a fix is during dumping a classlist,
>> check if an invoker can be archived.
>> If not, don't write the invoker info into the classlist, i.e. don't call
>> `logLambdaFormInvoker()`. While generating holder
On Thu, 7 Mar 2024 21:00:01 GMT, Ioi Lam wrote:
>> A few clean ups:
>>
>> 1. Rename functions like "`s_loading_full_module_graph()` to
>> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
>> might be interpreted as to cover only the period where the artifact is being
>
On Wed, 6 Mar 2024 01:58:26 GMT, Ioi Lam wrote:
>> I meant the following. Just the last line #94 needs to be changed - shift
>> one space to the left after `bool`.
>>
>> static bool is_dumping_heap()
>> NOT_CDS_JAVA_HEAP_RETURN_(false);
>> static void stop_dumping_
To avoid the CDS dump error message, a fix is during dumping a classlist, check
if an invoker can be archived.
If not, don't write the invoker info into the classlist, i.e. don't call
`logLambdaFormInvoker()`. While generating holder classes (in
`generateHolderClasses()`), don't add the `Method
On Tue, 5 Mar 2024 23:38:21 GMT, Ioi Lam wrote:
>> src/hotspot/share/cds/cdsConfig.hpp line 94:
>>
>>> 92: static bool is_dumping_full_module_graph() { return
>>> CDS_ONLY(_is_dumping_full_module_graph) NOT_CDS(false); }
>>> 93: static void stop_using_full_module_graph(con
On Sat, 2 Mar 2024 01:18:06 GMT, Ioi Lam wrote:
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> load
On Thu, 21 Dec 2023 19:10:59 GMT, Calvin Cheung wrote:
> Please review this change for enabling full module graph even when
> -Xbootclasspath/a is specified. The validation of -Xbootclasspath/a is
> already being done in `FileMapInfo::validate_boot_class_paths()`. The full
> modul
On Sat, 23 Dec 2023 08:08:35 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments from Alan and Ioi
>
> Marked as reviewed by alanb (Reviewer).
Thanks @AlanBa
would
> fail without the change.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
tests update per discussion with Ioi
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17178/f
On Fri, 22 Dec 2023 08:40:08 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments from Alan and Ioi
>
> src/java.base/share/classes/jdk/internal/loader/Class
would
> fail without the change.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
comments from Alan and Ioi
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17178/files
Please review this change for enabling full module graph even when
-Xbootclasspath/a is specified. The validation of -Xbootclasspath/a is already
being done in `FileMapInfo::validate_boot_class_paths()`. The full module graph
will be disabled if there's a mismatch in -Xbootclasspath/a between du
On Mon, 2 Oct 2023 22:17:34 GMT, Calvin Cheung wrote:
> Please review this changeset for adding support for `--module` (-m) option
> for CDS.
> Changes in the `ModuleBootstrap.java` are needed so that the
> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
On Wed, 1 Nov 2023 11:26:48 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more comments from Alan and Ioi; copyright year update
>
> Marked as reviewe
://bugs.openjdk.org/browse/JDK-8266329). More subtask(s)
> will be created to support other options such as `--add-modules`.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
cleanup suggested
On Fri, 27 Oct 2023 16:34:20 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge master
>> - skip archiving full module graph is there is
://bugs.openjdk.org/browse/JDK-8266329). More subtask(s)
> will be created to support other options such as `--add-modules`.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
more co
On Tue, 31 Oct 2023 09:09:37 GMT, Alan Bateman wrote:
> Thanks, it looks correctly now.
Thanks!
>
> One small question. At ModuleBootstrap L235 we set canArchive as it's okay to
> archive under specific restrictions. For completeness, shouldn't this set
> canArchive to CDS.isDumpingStaticArc
On Sat, 28 Oct 2023 06:37:00 GMT, Alan Bateman wrote:
>> The `ArchivedModuleGraph.java` wasn't changed. So if `-m` is not specified,
>> the `archivedModuleGraph` is non-null; if `-m` is specified, the
>> `archivedModuleGraph` is null.
>> So running `java -version`, the archivedModuleGraph is no
On Fri, 27 Oct 2023 16:28:10 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge master
>> - skip archiving full module graph is there is
://bugs.openjdk.org/browse/JDK-8266329). More subtask(s)
> will be created to support other options such as `--add-modules`.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
comments from Ioi a
On Fri, 27 Oct 2023 17:40:12 GMT, Alan Bateman wrote:
>> I reran the script you sent me few days ago and got the expected results
>> with the latest changes.
>> The checking of the main module name matches between dump time and runtime
>> is performed in the VM code. If an archive (even the def
On Fri, 27 Oct 2023 13:57:38 GMT, Alan Bateman wrote:
>> I've pushed another update with the following changes:
>>
>> - in the VM code, skip archiving full module graph if there's an incubator
>> module by checking if the ArchivedBootLayer::archivedBootLayer is available;
>> - included your sug
://bugs.openjdk.org/browse/JDK-8266329). More subtask(s)
> will be created to support other options such as `--add-modules`.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains ten commits:
On Sat, 21 Oct 2023 07:51:42 GMT, Alan Bateman wrote:
>>> > Yes, because of the following code further up in the same method:
>>>
>>> I think what you are actually doing here is supporting archiving of the
>>> boot layer when the main module transitively depends on an incubator
>>> module. We
://bugs.openjdk.org/browse/JDK-8266329). More subtask(s)
> will be created to support other options such as `--add-modules`.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementally with one additional
commit since the last revision:
skip archiving fu
1 - 100 of 118 matches
Mail list logo
