On Fri, 22 Nov 2024 11:07:31 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comment > > src/java.base/share/classes/java/lang/ClassLoader.java line 1689: > >> 1687: >> 1688: /** >> 1689: * Called by VM for constructing a ClassFileStream. > > "ClassFileStream" looks like a Java class name so might confusing readers of > this code as it doesn't exist. So maybe adjust this to say that it's for > reading class bytes or make it clear that it's for the C++/VM ClassFileStream. I've updated the comment as follows: `* Called by VM for reading class bytes.` Also updated some comments in filemap.cpp. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22262#discussion_r1854342438
