On Mon, 23 Jun 2025 20:14:36 GMT, Naoto Sato wrote:
> Fixing the side-effect caused by calling `StringTokenizer.nextToken(null)`,
> where the delimiter is set to `null` even if the method throws an NPE.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/j
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Mon, 23 Jun 2025 19:04:22 GMT, Alexey Ivanov wrote:
>> If "major tick" is translated to "Hauptteilstrich", then the plural would be
>> `[SliderDemo.majorticks=]Hauptteilstriche` (which is a rather artificial
>> word so the translation team might want to come up with a better translation
>>
On Mon, 16 Jun 2025 16:36:43 GMT, Gautham Krishnan
wrote:
> Some methods in the java.time.chrono interfaces—ChronoLocalDate,
> ChronoLocalDateTime, and ChronoZonedDateTime—override methods from the
> java.time.temporal.Temporal interface that are documented to throw
> UnsupportedTemporalTypeE
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote:
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode`
On Mon, 23 Jun 2025 10:39:59 GMT, Anton Artemov wrote:
>> test/hotspot/jtreg/runtime/Monitor/StressWrapper_TestRecursiveLocking_36M.java
>> line 36:
>>
>>> 34: * -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI
>>> 35: * -Xint
>>> 36: * -XX:LockingMode=0
>>
>> I was wondering why
On Mon, 23 Jun 2025 23:09:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
sun.invoke.empty.Empty and java.lang.invoke.InvokeDynamic are useless remnants
- Empty can be replaced by java.lang.Void, and InvokeDynamic was previously
used as a stub for javac to compile signature polymorphic methods. They should
be removed as a cleanup.
Testing: jdk/java/lang/invoke
-
On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla wrote:
> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved,
> JavaBaseCheckSince no longer needs to be problemlisted.
Now that https://github.com/openjdk/jdk/pull/25854 has been integrated, the
tests no longer need to be problemlisted.
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Wed, 18 Jun 2025 20:16:18 GMT, Roger Riggs wrote:
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add
On Mon, 23 Jun 2025 20:14:36 GMT, Naoto Sato wrote:
> Fixing the side-effect caused by calling `StringTokenizer.nextToken(null)`,
> where the delimiter is set to `null` even if the method throws an NPE.
Note that as mentioned in the bug discussion, the same also occurs when doing
`new StringTo
On Thu, 19 Jun 2025 11:08:32 GMT, Markus KARG wrote:
>> Replaces the implementation `readAllCharsAsString().lines().toList()` with
>> reading into a temporary `char` array which is then processed to detect line
>> terminators and copy non-terminating characters into strings which are added
>>
On Thu, 19 Jun 2025 10:57:52 GMT, Markus KARG wrote:
>>> I think we should treat "\r\n" as a single line terminator?
>>
>> You are correct: that needs to be fixed:
>>
>> jshell> Reader r = new StringReader("hello\r\nworld")
>> r ==> java.io.StringReader@480bdb19
>>
>> jshell> r.readAllLines()
On Fri, 20 Jun 2025 18:44:47 GMT, Naoto Sato wrote:
>> Refactored the internal handling of `stdin/out/err.encoding` to allow
>> setting them only via command-line options by converting them into
>> `StaticProperty`. This change prevents unexpected behavior caused by
>> applications modifying t
On Mon, 23 Jun 2025 20:14:36 GMT, Naoto Sato wrote:
> Fixing the side-effect caused by calling `StringTokenizer.nextToken(null)`,
> where the delimiter is set to `null` even if the method throws an NPE.
Indeed, looking at the spec, we would anticipate an exception means no change
has been comm
On Mon, 23 Jun 2025 07:14:45 GMT, Alan Bateman wrote:
> > Note that test j/u/c/tck/ testTimeUnit already includes
> > testTimedWait_IllegalMonitorException(). because it was already implied by
> > the spec. The change just makes this explicit. Does this require CSR? (If
> > so, I'd be happy to
On Mon, 23 Jun 2025 16:36:00 GMT, Alisen Chung wrote:
>> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 462:
>>
>>> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit
>>> Hauptteilstrichen
>>> 461: SliderDemo.ticks=Feinteilungen, Teilungen zum Einrasten und Labels
>
Fixing the side-effect caused by calling `StringTokenizer.nextToken(null)`,
where the delimiter is set to `null` even if the method throws an NPE.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/25942/files
Webrev: https://webrevs.openjdk.org/?repo=j
On Mon, 23 Jun 2025 19:54:24 GMT, Roger Riggs wrote:
>> @RogerRiggs My preferred formatting style is like this:
>>
>>
>> default boolean setShardingKeyIfValid(ShardingKey shardingKey,
>> ShardingKey superShardingKey,
>>
On Mon, 23 Jun 2025 18:38:00 GMT, simon wrote:
>> src/java.sql/share/classes/java/sql/Connection.java line 1597:
>>
>>> 1595: default boolean setShardingKeyIfValid(ShardingKey shardingKey,
>>> 1596: ShardingKey
>>> superShardingKey,
>>> 1597:
On Mon, 26 May 2025 19:20:06 GMT, Shaojin Wen wrote:
>> Through JVM Option +PrintInlining, we found that String has a constructor
>> codeSize of 852, which is too large. This caused failed to inline.
>>
>> The following is the output information of PrintInlining:
>>
>> @ 9 ja
On Thu, 19 Jun 2025 17:39:38 GMT, Johannes Döbler wrote:
>> src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties
>> line 183:
>>
>>> 181: size.bit.alg=%1$d-Bit-%2$s
>>> 182:
>>> Generating.full.keyAlgName.key.pair.and.self.signed.certificate.sigAlgName.with.a.
On Mon, 23 Jun 2025 17:38:58 GMT, Johannes Döbler wrote:
>> What would be the correct translation of majorticks here?
>
> If "major tick" is translated to "Hauptteilstrich", then the plural would be
> `[SliderDemo.majorticks=]Hauptteilstriche` (which is a rather artificial word
> so the transla
On Mon, 23 Jun 2025 14:55:08 GMT, Justin Lu wrote:
>> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties
>> line 220:
>>
>>> 218:
>>> entry.1.is.signed.in.jarfile.but.is.not.signed.in.jarinputstream=Eintrag %s
>>> ist in JarFile, aber nicht in JarInpu
On Mon, 23 Jun 2025 17:35:50 GMT, Roger Riggs wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: refactor code formatting to enforce 100 chars line length limit
>> for improved readability
>
> src/java.sql/share/cl
On Mon, 23 Jun 2025 16:34:05 GMT, Alisen Chung wrote:
>> I agree. I'd expect consistency here.
>
> What would be the correct translation of majorticks here?
If "major tick" is translated to "Hauptteilstrich", then the plural would be
`[SliderDemo.majorticks=]Hauptteilstriche` (which is a rather
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Mon, 23 Jun 2025 14:50:24 GMT, Roger Riggs wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: refactor code formatting to enforce 100 chars line length limit
>> for improved readability
>
> The indentation fixes
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote:
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode`
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
update to german translations
-
Ch
On Mon, 23 Jun 2025 11:09:30 GMT, Alan Bateman wrote:
> WindowsPath.compareTo is where we ended up for JDK 7, it would be good to
> validate this.
I assume that you intend here validating correctness with respect to the NTFS
case sensitivity settings
-
PR Comment: https://git.ope
On Mon, 23 Jun 2025 16:32:21 GMT, Alisen Chung wrote:
>> I am wondering the same thing. Perhaps because it is not intended for
>> general public, it's not in the [JDK tools
>> specifications](https://docs.oracle.com/en/java/javase/24/docs/specs/man/index.html).
>> If that was intentionally left
On Mon, 23 Jun 2025 07:31:34 GMT, Henry Jen wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage_de.properties
>> line 1:
>>
>>> 1: #
>>
>> Just wondering why this resource file has not been translated into
>> de/ja/zh_CN till now. Looks correct though.
>
> I am wondering t
On Wed, 18 Jun 2025 20:37:43 GMT, Phil Race wrote:
>> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 460:
>>
>>> 458: SliderDemo.a_plain_slider=Ein einfacher Schieberegler
>>> 459: SliderDemo.majorticks=Grobteilungen
>>> 460: SliderDemo.majorticksdescription=Ein Schieberegler
On Wed, 18 Jun 2025 14:48:13 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 462:
>
>> 460: SliderDemo.
On Tue, 17 Jun 2025 20:16:05 GMT, Naoto Sato wrote:
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting
> them only via command-line options by converting them into `StaticProperty`.
> This change prevents unexpected behavior caused by applications modifying
> these
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote:
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode`
On Mon, 23 Jun 2025 14:51:44 GMT, Chen Liang wrote:
> FYI people don't usually review on weekends (you opened this PR in a weekend)
> or holidays. This PR is sent to core-libs-dev list so people will eventually
> see and review it.
Great, @liach! Thanks for the information! 😄
-
P
On Mon, 23 Jun 2025 14:50:24 GMT, Roger Riggs wrote:
> The indentation fixes look ok. The reformatting of declarations seem
> unnecessary and create lines that are longer than desirable to be able to do
> side-by-side compares (100 char max). Generally, avoid just asking the IDE to
> re-format
On Wed, 18 Jun 2025 15:59:35 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_de.proper
Hi Davide,
There is no such jpackage option that configures the installer to launch
the app automatically after installation.
You can, however, customize wix sources jpackage uses to build the
installer accordingly.
Here is how you can do it:
1. Use main.wxs file from [1] as the baseline f
On Wed, 18 Jun 2025 15:52:15 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties
>
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
On Wed, 18 Jun 2025 07:52:02 GMT, David Holmes wrote:
>> This PR contains changes for the 1st phase of the `LockingMode` flag
>> obsoletion.
>>
>> The work is done by @fbredber, I have taken it over and am finishing it
>> while he's on vacation.
>>
>> In the 1st phase one keeps the `Locking
On Wed, 18 Jun 2025 18:23:58 GMT, Coleen Phillimore wrote:
>> This PR contains changes for the 1st phase of the `LockingMode` flag
>> obsoletion.
>>
>> The work is done by @fbredber, I have taken it over and am finishing it
>> while he's on vacation.
>>
>> In the 1st phase one keeps the `Lo
On Wed, 18 Jun 2025 07:37:31 GMT, David Holmes wrote:
>> This PR contains changes for the 1st phase of the `LockingMode` flag
>> obsoletion.
>>
>> The work is done by @fbredber, I have taken it over and am finishing it
>> while he's on vacation.
>>
>> In the 1st phase one keeps the `Locking
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote:
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode`
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote:
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode`
This PR contains changes for the 1st phase of the `LockingMode` flag
obsoletion.
The work is done by @fbredber, I have taken it over and am finishing it while
he's on vacation.
In the 1st phase one keeps the `LockingMode` variable in all places, but makes
it non-settable from the command lin
On Wed, 18 Jun 2025 18:48:04 GMT, Damon Nguyen wrote:
>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2001, 2023, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Looks wrong but is correct. File had
On Mon, 9 Jun 2025 20:42:43 GMT, Justin Lu wrote:
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
> $ javap fo\ o.class
>
On Tue, 17 Jun 2025 21:47:49 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
As subject.
Using jpackage 24 with WiX Toolset 5 or 6,
how can I start the app automatically after installation is complete?
As title, is this possible?
At the moment I generate my installer with this command:
jpackage -i target --type exe --main-class org.dpsoftware.JavaFXStarter
--main-jar
On Wed, 18 Jun 2025 06:01:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8359830?
>
> macOS operating system's newer version 26 (currently in Beta) is reported as
> a 16 by older versions
On Mon, 16 Jun 2025 22:49:00 GMT, Xueming Shen wrote:
> Just wondering how Windows implementation really behaves for its
> 'case-insensitive-comparing" for "\u0131 vs "I". I would assume they actually
> are 2 'distinguished" files?
I think it depends on the locale. Also it is possible to confi
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
On Sun, 22 Jun 2025 12:54:29 GMT, Doug Lea wrote:
>> This collects miscellaneous open issues that can be resolved with
>> documentation updates; each indicated by adding JDK issue numbers
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremen
On Wed, 18 Jun 2025 16:42:16 GMT, Kevin Rushforth wrote:
>> Can I please get a review of this change which proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8359830?
>>
>> macOS operating system's newer version 26 (currently in Beta) is reported as
>> a 16 by older
On Wed, 18 Jun 2025 01:51:28 GMT, Naoto Sato wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage_de.properties
> line 1:
>
>> 1: #
On Mon, 23 Jun 2025 08:07:21 GMT, Jaikiran Pai wrote:
> I think we are missing a test for this which might explain why tier1, tier2,
> tier3 testing of this current change didn't notice that this area too needs a
> change.
It looks like an existing test
`test/hotspot/jtreg/runtime/ErrorHandl
On Sun, 22 Jun 2025 10:50:42 GMT, Doug Lea wrote:
> Note that test j/u/c/tck/ testTimeUnit already includes
> testTimedWait_IllegalMonitorException(). because it was already implied by
> the spec. The change just makes this explicit. Does this require CSR? (If so,
> I'd be happy to do it).
I
66 matches
Mail list logo
