On Sun, 22 Jun 2025 01:13:26 GMT, simon <d...@openjdk.org> wrote: > 8360122: Refine formatting of Connection.java interface > > --------- > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 > [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > > > > ### Reviewing > <details><summary>Using <code>git</code></summary> > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jdk.git pull/25925/head:pull/25925` \ > `$ git checkout pull/25925` > > Update a local copy of the PR: \ > `$ git checkout pull/25925` \ > `$ git pull https://git.openjdk.org/jdk.git pull/25925/head` > > </details> > <details><summary>Using Skara CLI tools</summary> > > Checkout this PR locally: \ > `$ git pr checkout 25925` > > View PR using the GUI difftool: \ > `$ git pr show -t 25925` > > </details> > <details><summary>Using diff file</summary> > > Download this PR as a diff file: \ > <a > href="https://git.openjdk.org/jdk/pull/25925.diff";>https://git.openjdk.org/jdk/pull/25925.diff</a> > > </details> > <details><summary>Using Webrev</summary> > > [Link to Webrev > Comment](https://git.openjdk.org/jdk/pull/25925#issuecomment-2993856738) > </details>
The indentation fixes look ok. The reformatting of declarations seem unnecessary and create lines that are longer than desirable to be able to do side-by-side compares (100 char max). Generally, avoid just asking the IDE to re-format the source, it leads to unnecessary changes. ------------- PR Review: https://git.openjdk.org/jdk/pull/25925#pullrequestreview-2950430779
