Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v6]

2025-05-09 Thread Vicente Romero
On Thu, 8 May 2025 18:55:34 GMT, Vicente Romero wrote: >> Vicente Romero has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 26 commits: >> >> - Merge branch 'master' into JDK-8354556 >> - addressing review comment >> - changes to

Integrated: 8356664: [macos] AppContentTest fails after JDK-8352480

2025-05-09 Thread Alexander Matveev
On Fri, 9 May 2025 23:36:44 GMT, Alexander Matveev wrote: > - Regression from JDK-8352480. > - On macOS we should create `Links` folder under `Resources`. Which means > `--app-content` should point to `app-content/Resources` and not to > `app-content/Resources/Links`. This pull request has now

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 20:39:27 GMT, Naoto Sato wrote: >> With the introduction of `stdin.encoding` >> ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance >> for users to decode `System.in` would be desirable. Adding examples in the >> field description would help. > > Naot

Re: RFR: 8356664: [macos] AppContentTest fails after JDK-8352480

2025-05-09 Thread Alexey Semenyuk
On Fri, 9 May 2025 23:36:44 GMT, Alexander Matveev wrote: > - Regression from JDK-8352480. > - On macOS we should create `Links` folder under `Resources`. Which means > `--app-content` should point to `app-content/Resources` and not to > `app-content/Resources/Links`. Marked as reviewed by ase

Re: RFR: 8356107: [java.lang] Use @requires tag instead of exiting based on os.name or separatorChar property

2025-05-09 Thread Naoto Sato
On Fri, 9 May 2025 23:23:27 GMT, Brent Christian wrote: > For `java.lang` tests, use the `@requires` facility in place of checking the > `os.name` system property or `File.separatorChar`. > > Automated test results are omitted as expected. I think `test/jdk/java/lang/System/NonAnsiFileEncoding

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Naoto Sato
On Fri, 9 May 2025 20:53:42 GMT, Chen Liang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects a review comment > > src/java.base/share/classes/java/util/Scanner.java line 81: > >> 79: * } >> 80: * >> 81: *

Re: RFR: 8356107: [java.lang] Use @requires tag instead of exiting based on os.name or separatorChar property

2025-05-09 Thread Brian Burkhalter
On Fri, 9 May 2025 23:23:27 GMT, Brent Christian wrote: > For `java.lang` tests, use the `@requires` facility in place of checking the > `os.name` system property or `File.separatorChar`. > > Automated test results are omitted as expected. test/jdk/java/lang/RuntimeTests/exec/Space.java line 4

RFR: 8356664: [macos] AppContentTest fails after JDK-8352480

2025-05-09 Thread Alexander Matveev
- Regression from JDK-8352480. - On macOS we should create `Links` folder under `Resources`. Which means `--app-content` should point to `app-content/Resources` and not to `app-content/Resources/Links`. - Commit messages: - 8356664: [macos] AppContentTest fails after JDK-8352480 C

RFR: 8356107: [java.lang] Use @requires tag instead of exiting based on os.name or separatorChar property

2025-05-09 Thread Brent Christian
For `java.lang` tests, use the `@requires` facility in place of checking the `os.name` system property or `File.separatorChar`. Automated test results are omitted as expected. - Commit messages: - add @requires Changes: https://git.openjdk.org/jdk/pull/25163/files Webrev: https:

Re: RFR: 8356644: Update encoding declaration to UTF-8

2025-05-09 Thread Naoto Sato
On Fri, 9 May 2025 14:14:57 GMT, Magnus Ihse Bursie wrote: > A handful of html and xml files in the JDK source tree claims to have > encodings like `ISO-8859-1`, when they are in fact pure US-ASCII files. > > While perhaps technically correct, this is misleading, and goes contrary to > the eff

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v9]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 22:48:34 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v8]

2025-05-09 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v9]

2025-05-09 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v6]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 21:24:58 GMT, Archie Cobbs wrote: > That's why I was offering my existing patch which basically does that > already. But it's OK to wait if you prefer. Sure, I think vicente is open to patches and PRs to his fork. And I can help review; just remember to @liach.

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Naoto Sato
On Fri, 9 May 2025 21:10:02 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects a review comment > > src/java.base/share/classes/java/lang/System.java line 135: > >> 133: * {@snippet lang=

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Naoto Sato
On Fri, 9 May 2025 20:15:48 GMT, Brian Burkhalter wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects a review comment > > src/java.base/share/classes/java/lang/System.java line 136: > >> 134: * new In

Integrated: 8351443: Improve robustness of StringBuilder

2025-05-09 Thread Roger Riggs
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote: > Refactor AbstractStringBuilder to maintain consistency among count, coder, > and value buffers while the buffer capacity is being expanded and/or inflated > from Latin1 to UTF16 representations. > The refactoring pattern is to read and wri

Re: RFR: 8351443: Improve robustness of StringBuilder [v9]

2025-05-09 Thread Brent Christian
On Fri, 9 May 2025 16:41:39 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8356420: Provide examples on wrapping System.in [v3]

2025-05-09 Thread Naoto Sato
> With the introduction of `stdin.encoding` > ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance > for users to decode `System.in` would be desirable. Adding examples in the > field description would help. Naoto Sato has updated the pull request incrementally with one a

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v6]

2025-05-09 Thread Archie Cobbs
On Fri, 9 May 2025 21:09:46 GMT, Chen Liang wrote: > I think if we do that, we should encapsulate `option` and move all access, > such as `option.isSet`, to dedicated methods on `LintCategory`. We are a bit > short on time for this, so IMO our best approach is to open a followup issue > that w

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v6]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 21:06:09 GMT, Archie Cobbs wrote: > Do we care about that? If so then we might want to implement a proper fix for > lint aliases as a separate pre-requisite to this issue. I think if we do that, we should encapsulate `option` and move all access, such as `option.isSet`, to d

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Roger Riggs
On Fri, 9 May 2025 20:39:27 GMT, Naoto Sato wrote: >> With the introduction of `stdin.encoding` >> ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance >> for users to decode `System.in` would be desirable. Adding examples in the >> field description would help. > > Naot

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v6]

2025-05-09 Thread Archie Cobbs
On Fri, 9 May 2025 20:25:40 GMT, Vicente Romero wrote: > I was working on something in this line too, just pushed the patch Looks reasonable, a couple of comments... Can't `LintCategory.alias` be `final`? If so I think this obviates the patch to `DetectMutableStaticFields.java`. This is not a

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or c

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v16]

2025-05-09 Thread Roger Riggs
On Tue, 6 May 2025 15:43:07 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Revert BufferedReader; simplify Reader changes

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-09 Thread Vicente Romero
On Fri, 9 May 2025 20:43:46 GMT, Chen Liang wrote: >> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixing bugs, removing dead code > > make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java > line 22

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Iris Clark
On Fri, 9 May 2025 20:39:27 GMT, Naoto Sato wrote: >> With the introduction of `stdin.encoding` >> ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance >> for users to decode `System.in` would be desirable. Adding examples in the >> field description would help. > > Naot

Re: RFR: 8356420: Provide examples on wrapping System.in

2025-05-09 Thread Brian Burkhalter
On Fri, 9 May 2025 19:53:24 GMT, Naoto Sato wrote: > With the introduction of `stdin.encoding` > ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance > for users to decode `System.in` would be desirable. Adding examples in the > field description would help. Looks good.

Re: RFR: 8356644: Update encoding declaration to UTF-8

2025-05-09 Thread Phil Race
On Fri, 9 May 2025 14:14:57 GMT, Magnus Ihse Bursie wrote: > A handful of html and xml files in the JDK source tree claims to have > encodings like `ISO-8859-1`, when they are in fact pure US-ASCII files. > > While perhaps technically correct, this is misleading, and goes contrary to > the eff

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or c

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v12]

2025-05-09 Thread Andrey Turbanov
On Tue, 6 May 2025 20:52:34 GMT, Markus KARG wrote: >> This Pull Request proposes an implementation for >> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new >> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int >> dstBegin)` to the `CharSequence` in

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Brian Burkhalter
On Fri, 9 May 2025 20:31:51 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/lang/System.java line 136: >> >>> 134: * new InputStreamReader(System.in, >>> System.getProperty("stdin.encoding")); >>> 135: * } >>> 136: * Or with a {@link java.util.Scanner Scanner}: >>

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Brian Burkhalter
On Fri, 9 May 2025 20:36:07 GMT, Naoto Sato wrote: >> With the introduction of `stdin.encoding` >> ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance >> for users to decode `System.in` would be desirable. Adding examples in the >> field description would help. > > Naot

Re: RFR: 8356420: Provide examples on wrapping System.in [v2]

2025-05-09 Thread Naoto Sato
> With the introduction of `stdin.encoding` > ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance > for users to decode `System.in` would be desirable. Adding examples in the > field description would help. Naoto Sato has updated the pull request incrementally with one a

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-09 Thread Vicente Romero
> This PR is defining a new internal annotation, > `@jdk.internal.RequiresIdentity`, with target types PARAMETER and > TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation > that an argument to a given method or constructor parameter will be an object > with a unique ident

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v6]

2025-05-09 Thread Archie Cobbs
On Thu, 8 May 2025 18:55:34 GMT, Vicente Romero wrote: >> Vicente Romero has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 26 commits: >> >> - Merge branch 'master' into JDK-8354556 >> - addressing review comment >> - changes to

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v7]

2025-05-09 Thread Weijun Wang
> Finalize the KDF API. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: new algorithms in SunJCE - Changes: - all: https://git.openjdk.org/jdk/pull/24520/files - new: https://git.openjdk.org/jdk/pull/24520/files/f44dc

RFR: 8356420: Provide examples on wrapping System.in

2025-05-09 Thread Naoto Sato
With the introduction of `stdin.encoding` ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance for users to decode `System.in` would be desirable. Adding examples in the field description would help. - Commit messages: - initial commit Changes: https://git.

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-09 Thread Phil Race
On Fri, 9 May 2025 08:58:15 GMT, Leo Korinth wrote: > > test/jdk/java/awt/font/NumericShaper/MTTest.java > > ``` > > * * @run main/timeout=300/othervm MTTest > > > > > > * * @run main/timeout=1200/othervm MTTest > > ``` > > > > > > > > > > > > > > > > > > > >

Re: RFR: 8356486: ReverseOrderListView should override reversed() to return `base` [v2]

2025-05-09 Thread Stuart Marks
On Fri, 9 May 2025 07:50:29 GMT, Per Minborg wrote: >> This PR proposed to let `ReverseOrderListView::reversed` directly return >> `base` instead of going though a more complicated code path. > > Per Minborg has updated the pull request incrementally with two additional > commits since the last

Re: RFR: 8356486: ReverseOrderListView should override reversed() to return `base` [v2]

2025-05-09 Thread Stuart Marks
On Fri, 9 May 2025 07:03:30 GMT, Per Minborg wrote: >> There are some new collections (such as StableList) that are not covered in >> Basic. But maybe they should have their separate tests? > > `UnmodifiableSequencedCollection` double-reversed is not an identity > function. But at least, it doe

Re: RFR: 8355393: Create a Test case to have special cases coverage for currency.getInstance()

2025-05-09 Thread Weibing Xiao
On Tue, 6 May 2025 07:25:36 GMT, Abhishek N wrote: > Create a Test case to have special cases coverage for currency.getInstance(). > > The test Validates that all currency codes and country-currency mappings in > the input file are consistent with the Java Currency API. > > test results: > >

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v8]

2025-05-09 Thread Vicente Romero
> This PR is defining a new internal annotation, > `@jdk.internal.RequiresIdentity`, with target types PARAMETER and > TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation > that an argument to a given method or constructor parameter will be an object > with a unique ident

Integrated: 8355719: Reduce memory consumption of BigInteger.pow()

2025-05-09 Thread fabioromano1
On Wed, 16 Apr 2025 13:45:55 GMT, fabioromano1 wrote: > This PR optimizes `BigInteger.pow(int)` method. The primary enhancement in > `pow()` is not concerned most on execution time, but rather in memory > optimization, because the PR implementation does the "shift of the exponent" > squaring t

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v7]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 14:35:38 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or c

Re: RFR: 8348828: Windows dll loading now resolves symlinks [v3]

2025-05-09 Thread Benjamin Peterson
On Fri, 9 May 2025 09:10:21 GMT, Alan Bateman wrote: > Is this documented in the Microsoft document for LoadLibrary? We don't want > to rely on undocumented behavior as it could break at any time. [LoadLibraryEx` documentation](https://learn.microsoft.com/en-us/windows/win32/api/libloaderapi/n

Re: RFR: 8348828: Windows dll loading now resolves symlinks [v4]

2025-05-09 Thread Benjamin Peterson
> Deep in the bowels of `System.loadLibrary`, `File.getCanonicalPath()` is > called on the target library file before it is passed to the system library > loading APIs. In JDK-8003887, `File.getCanonicalPath` was altered to resolve > symlinks on Windows. This had unintended consequences for pass

Re: RFR: 8333664: Decouple command line parsing and package building in jpackage [v3]

2025-05-09 Thread Alexey Semenyuk
> Refactor jpackage to separate the configuration and execution phases. > At the configuration phase, jpackage parses command-line arguments and > validates them. > At the execution phase, jpackage builds a bundle based on data collected at > the configuration phase. > > There was no clear separ

Re: RFR: 8333664: Decouple command line parsing and package building in jpackage [v2]

2025-05-09 Thread Alexey Semenyuk
> Refactor jpackage to separate the configuration and execution phases. > At the configuration phase, jpackage parses command-line arguments and > validates them. > At the execution phase, jpackage builds a bundle based on data collected at > the configuration phase. > > There was no clear separ

Integrated: 8353232: Standardizing and Unifying XML Component Configurations

2025-05-09 Thread Joe Wang
On Wed, 7 May 2025 16:17:07 GMT, Joe Wang wrote: > This is a refactor patch, no change in functionality. > > This patch refactor the configuration code. Rather than for each factory to > go through the whole configuration process, a base configuration as > represented in JdkXmlConfig is create

Re: RFR: 8351443: Improve robustness of StringBuilder [v9]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 16:41:39 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8355719: Reduce memory consumption of BigInteger.pow() [v55]

2025-05-09 Thread duke
On Thu, 8 May 2025 16:48:40 GMT, fabioromano1 wrote: >> This PR optimizes `BigInteger.pow(int)` method. The primary enhancement in >> `pow()` is not concerned most on execution time, but rather in memory >> optimization, because the PR implementation does the "shift of the exponent" >> squarin

Re: RFR: 8351443: Improve robustness of StringBuilder [v9]

2025-05-09 Thread Raffaello Giulietti
On Fri, 9 May 2025 16:41:39 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8352565: Add native method implementation of Reference.get() [v4]

2025-05-09 Thread Kim Barrett
On Fri, 11 Apr 2025 08:14:29 GMT, Kim Barrett wrote: >> test/hotspot/jtreg/gc/TestNativeReferenceGet.java line 137: >> >>> 135: } >>> 136: checkQueue(); // One last check after refproc >>> complete. >>> 137: } catch (InterruptedException e) { >> >> Rather

Re: RFR: 8355719: Reduce memory consumption of BigInteger.pow() [v55]

2025-05-09 Thread Raffaello Giulietti
On Thu, 8 May 2025 16:48:40 GMT, fabioromano1 wrote: >> This PR optimizes `BigInteger.pow(int)` method. The primary enhancement in >> `pow()` is not concerned most on execution time, but rather in memory >> optimization, because the PR implementation does the "shift of the exponent" >> squarin

Re: RFR: 8355393: Create a Test case to have special cases coverage for currency.getInstance()

2025-05-09 Thread Justin Lu
On Tue, 6 May 2025 07:25:36 GMT, Abhishek N wrote: > Create a Test case to have special cases coverage for currency.getInstance(). > > The test Validates that all currency codes and country-currency mappings in > the input file are consistent with the Java Currency API. > > test results: > >

Integrated: 8352480: Don't follow symlinks in additional content for app images

2025-05-09 Thread Alexander Matveev
On Wed, 30 Apr 2025 20:17:57 GMT, Alexander Matveev wrote: > - Symbolic links will not be followed for `--app-content` on all platforms. > - Added test to cover this case. > - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG, > since "cp -r" on macOS is not documented op

Re: RFR: 8351443: Improve robustness of StringBuilder [v9]

2025-05-09 Thread Roger Riggs
> Refactor AbstractStringBuilder to maintain consistency among count, coder, > and value buffers while the buffer capacity is being expanded and/or inflated > from Latin1 to UTF16 representations. > The refactoring pattern is to read and write AbstractStringBuilder fields > once using locals fo

Integrated: 8356555: Incorrect use of {@link} in BigDecimal

2025-05-09 Thread Joe Darcy
On Thu, 8 May 2025 21:07:16 GMT, Joe Darcy wrote: > Fix javadoc tags. This pull request has now been integrated. Changeset: bed29a03 Author:Joe Darcy URL: https://git.openjdk.org/jdk/commit/bed29a03d198a9717f7d258ee21330462775136e Stats: 4 lines in 1 file changed: 0 ins; 0 del;

Re: RFR: 8356555: Incorrect use of {@link} in BigDecimal [v2]

2025-05-09 Thread Joe Darcy
> Fix javadoc tags. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/25131/files - new: https://git.openjdk.org/jdk/pull/25131/files/d1c2345a

Re: RFR: 8356555: Incorrect use of {@link} in BigDecimal [v2]

2025-05-09 Thread Brian Burkhalter
On Fri, 9 May 2025 16:15:11 GMT, Joe Darcy wrote: >> Fix javadoc tags. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by bpb (Reviewer). - PR Review: https://git.o

Re: RFR: 8356555: Incorrect use of {@link} in BigDecimal [v2]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 16:15:11 GMT, Joe Darcy wrote: >> Fix javadoc tags. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by liach (Reviewer). - PR Review: https://git

Re: RFR: 8356555: Incorrect use of {@link} in BigDecimal [v2]

2025-05-09 Thread Nizar Benalla
On Fri, 9 May 2025 16:15:11 GMT, Joe Darcy wrote: >> Fix javadoc tags. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Looks good! - Marked as reviewed by nbenalla (Committer). PR Re

Re: RFR: 8354968: Replace unicode sequences in comment text with UTF-8 characters [v4]

2025-05-09 Thread Naoto Sato
On Fri, 9 May 2025 10:12:09 GMT, Magnus Ihse Bursie wrote: >> As part of the UTF-8 cleaning up done in >> [JDK-8301971](https://bugs.openjdk.org/browse/JDK-8301971), I looked at >> where and how we are using unicode sequences (`\u`). In several string >> literals, I think the unicode seque

Re: RFR: 8356450: NPE in CLDRTimeZoneNameProviderImpl for tzdata downgrades after JDK-8342550

2025-05-09 Thread Naoto Sato
On Thu, 8 May 2025 20:50:25 GMT, Naoto Sato wrote: > Fixing the NPE in CLDR time zone name provider. The NPE occurrs if the time > zone data was downgraded by the TZUpdater tool in which some time zones are > missing. For those missing zones, `ZoneInfo.getTimeZone()` returns null, > while `Tim

Integrated: 8356450: NPE in CLDRTimeZoneNameProviderImpl for tzdata downgrades after JDK-8342550

2025-05-09 Thread Naoto Sato
On Thu, 8 May 2025 20:50:25 GMT, Naoto Sato wrote: > Fixing the NPE in CLDR time zone name provider. The NPE occurrs if the time > zone data was downgraded by the TZUpdater tool in which some time zones are > missing. For those missing zones, `ZoneInfo.getTimeZone()` returns null, > while `Tim

Re: RFR: 8356555: Incorrect use of {@link} in BigDecimal

2025-05-09 Thread Joe Darcy
On Fri, 9 May 2025 10:32:27 GMT, Nizar Benalla wrote: > I just noticed there are a couple more javadoc tags that need to be fixed in > this class, I still see two more warnings. I should have included these in > the JBS issue when filling it. > > ``` > src/java.base/share/classes/java/math/Big

Re: RFR: 8356644: Update encoding declaration to UTF-8

2025-05-09 Thread Daniel Fuchs
On Fri, 9 May 2025 14:14:57 GMT, Magnus Ihse Bursie wrote: > A handful of html and xml files in the JDK source tree claims to have > encodings like `ISO-8859-1`, when they are in fact pure US-ASCII files. > > While perhaps technically correct, this is misleading, and goes contrary to > the eff

Re: RFR: 8352565: Add native method implementation of Reference.get() [v6]

2025-05-09 Thread Kim Barrett
> Please review this change which adds a native method providing the > implementation of Reference::get. Referece::get is an intrinsic candidate, so > this native method implementation is only used when the intrinsic is not. > > Currently there is intrinsic support by the interpreter, C1, C2, and

Re: RFR: 8351443: Improve robustness of StringBuilder [v7]

2025-05-09 Thread Raffaello Giulietti
On Fri, 9 May 2025 13:28:44 GMT, Raffaello Giulietti wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add an assert to inflateToUTF16 method >> Add doc of preconditions to appendChars... methods >> Correct misc

Re: RFR: 8355022: Implement JEP 506: Scoped Values [v7]

2025-05-09 Thread Alan Bateman
On Fri, 9 May 2025 08:28:37 GMT, Alan Bateman wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix merge > >> I'm getting a test failure in >> [ClassFileVersionTest.java](https://github.com/openjdk/jdk/blob/master/

Re: RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory [v2]

2025-05-09 Thread Andrew Haley
> This intrinsic is generally faster than the current implementation for Panama > segment operations for all writes larger than about 8 bytes in size, > increasing to more than 2* the performance on larger memory blocks on > Graviton 2, between "panama" (C2 generated, what we use now) and "unsaf

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-05-09 Thread Viktor Klang
On Thu, 8 May 2025 13:47:41 GMT, kabutz wrote: >> src/java.base/share/classes/java/util/concurrent/LinkedBlockingDeque.java >> line 341: >> >>> 339: if (count >= capacity) >>> 340: return false; >>> 341: linkFirst(node); >> >> I'm a bit uneasy about incr

Re: RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory

2025-05-09 Thread Andrew Haley
On Fri, 9 May 2025 14:11:27 GMT, Andrew Haley wrote: > This intrinsic is generally faster than the current implementation for Panama > segment operations for all writes larger than about 8 bytes in size, > increasing to more than 2* the performance on larger memory blocks on > Graviton 2, betw

Re: RFR: 8351443: Improve robustness of StringBuilder [v8]

2025-05-09 Thread Roger Riggs
> Refactor AbstractStringBuilder to maintain consistency among count, coder, > and value buffers while the buffer capacity is being expanded and/or inflated > from Latin1 to UTF16 representations. > The refactoring pattern is to read and write AbstractStringBuilder fields > once using locals fo

Re: RFR: 8351443: Improve robustness of StringBuilder [v6]

2025-05-09 Thread Roger Riggs
On Tue, 6 May 2025 16:18:11 GMT, Chen Liang wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply reviewer suggestions for typos, javadoc, and copyright dates. > > src/java.base/share/classes/java/lang/AbstractStrin

Re: RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory

2025-05-09 Thread Andrew Haley
On Fri, 9 May 2025 14:11:27 GMT, Andrew Haley wrote: > This intrinsic is generally faster than the current implementation for Panama > segment operations for all writes larger than about 8 bytes in size, > increasing to more than 2* the performance on larger memory blocks on > Graviton 2, betw

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 12:10:38 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Unfortunately, this PR shows the total commit history for stable values. > > Per Minborg has updated the pull re

Re: RFR: 8354968: Replace unicode sequences in comment text with UTF-8 characters [v4]

2025-05-09 Thread Magnus Ihse Bursie
> As part of the UTF-8 cleaning up done in > [JDK-8301971](https://bugs.openjdk.org/browse/JDK-8301971), I looked at where > and how we are using unicode sequences (`\u`). In several string > literals, I think the unicode sequences still has merit, if they improve > clarity or readability o

Integrated: 8346255: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java finds no deadlock

2025-05-09 Thread Patricio Chilano Mateo
On Thu, 8 May 2025 13:46:02 GMT, Patricio Chilano Mateo wrote: > Please review this small test fix. We need to make sure the two threads are > blocked on the expected locks before invoking findMonitorDeadlockedThreads. > In the failing cases, one of the threads is seen as blocked while waiting

Re: RFR: 8346255: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java finds no deadlock [v2]

2025-05-09 Thread Patricio Chilano Mateo
On Thu, 8 May 2025 21:59:18 GMT, David Holmes wrote: > > we don’t change the state to Thread.State.WAITING when using ObjectLocker > > and calling wait_uninterruptibly(). > > No, because that is an internal implementation detail. It is a grey area. > There is no such thing as an uninterruptibl

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v7]

2025-05-09 Thread Archie Cobbs
On Fri, 9 May 2025 14:35:38 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or c

RFR: 8356644: Update encoding declaration to UTF-8

2025-05-09 Thread Magnus Ihse Bursie
A handful of html and xml files in the JDK source tree claims to have encodings like `ISO-8859-1`, when they are in fact pure US-ASCII files. While perhaps technically correct, this is misleading, and goes contrary to the efforts of turning the source code into UTF-8 proper. I chose between mar

Re: RFR: 8346255: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java finds no deadlock [v2]

2025-05-09 Thread Patricio Chilano Mateo
On Fri, 9 May 2025 06:32:07 GMT, Alan Bateman wrote: >> Patricio Chilano Mateo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rename awaitBlocked to awaitTrueAndBlocked > > Marked as reviewed by alanb (Reviewer). Thanks for the reviews

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v10]

2025-05-09 Thread Maurizio Cimadamore
On Thu, 8 May 2025 10:50:55 GMT, Per Minborg wrote: >> As we advance, converting older JDK code to use the relatively new FFM API >> requires system calls that can provide `errno` and the likes to explicitly >> allocate a MemorySegment to capture potential error states. This can lead to >> neg

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-05-09 Thread Viktor Klang
On Thu, 8 May 2025 14:28:18 GMT, kabutz wrote: >> src/java.base/share/classes/java/util/concurrent/LinkedBlockingDeque.java >> line 865: >> >>> 863: long n = 0; >>> 864: for (E e : c) { >>> 865: Objects.requireNonNull(e); >> >> This makes me wonder: Does it make sen

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-09 Thread Maurizio Cimadamore
On Fri, 9 May 2025 12:10:38 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Unfortunately, this PR shows the total commit history for stable values. > > Per Minborg has updated the pull re

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v7]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 14:35:38 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or c

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v5]

2025-05-09 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP > Client API](https://openjdk.org/jeps/517). > > The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP > Client API](https://bugs.openjdk.org/browse/JDK-8350588) > > This JEP propose

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v7]

2025-05-09 Thread Vicente Romero
> This PR is defining a new internal annotation, > `@jdk.internal.RequiresIdentity`, with target types PARAMETER and > TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation > that an argument to a given method or constructor parameter will be an object > with a unique ident

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-09 Thread Leo Korinth
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory

2025-05-09 Thread Andrew Haley
On Fri, 9 May 2025 14:11:27 GMT, Andrew Haley wrote: > This intrinsic is generally faster than the current implementation for Panama > segment operations for all writes larger than about 8 bytes in size, > increasing to more than 2* the performance on larger memory blocks on > Graviton 2, betw

RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory

2025-05-09 Thread Andrew Haley
This intrinsic is generally faster than the current implementation for Panama segment operations for all writes larger than about 8 bytes in size, increasing to more than 2* the performance on larger memory blocks on Graviton 2, between "panama" (C2 generated, what we use now) and "unsafe" (this

Re: RFR: 8351443: Improve robustness of StringBuilder [v7]

2025-05-09 Thread Raffaello Giulietti
On Fri, 9 May 2025 00:20:19 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v6]

2025-05-09 Thread Sean Mullan
On Fri, 2 May 2025 18:49:34 GMT, Weijun Wang wrote: >> Finalize the KDF API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > fine tuning debug log and exception message We should also update the comments and info string of

Re: RFR: 8355022: Implement JEP 506: Scoped Values [v7]

2025-05-09 Thread Andrew Haley
On Thu, 8 May 2025 18:18:44 GMT, Chen Liang wrote: > I noted that `ThreadFlock` is using scoped values but throwing > `StructureViolationException` introduced by structured concurrency - is it > considered an implementation artifact and part of structured concurrency > instead? > > Context: t

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-09 Thread Leo Korinth
On Thu, 8 May 2025 20:00:21 GMT, Phil Race wrote: > test/jdk/java/awt/font/NumericShaper/MTTest.java > > * * @run main/timeout=300/othervm MTTest > > > * * @run main/timeout=1200/othervm MTTest > > > I'm puzzling over why you saw this test fail with timeout = 300 .. or perhaps > you

RFR: 8355393: Create a Test case to have special cases coverage for currency.getInstance()

2025-05-09 Thread Abhishek N
Create a Test case to have special cases coverage for currency.getInstance(). The test Validates that all currency codes and country-currency mappings in the input file are consistent with the Java Currency API. test results: jdk-24.0.2/bin/java -jar jtreg/lib/jtreg.jar -testjdk:jdk-24.0.2 -di

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-09 Thread Leo Korinth
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-09 Thread Leo Korinth
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

  1   2   >