On Fri, 9 May 2025 08:28:37 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix merge > >> I'm getting a test failure in >> [ClassFileVersionTest.java](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/runtime/ClassFile/ClassFileVersionTest.java#45) >> because `ScopedValue` is not a Preview API. Should I just fix the test to >> use some other Preview Class? > > Chen offered to change this test to use the ClassFile API and construct the > class with the preview minor number. The PR to change this test is reviewed > so I think all good, nothing more to do here. > That's an interesting question that I'll leave to @AlanBateman . Nothing to do as the test uses StructureViolationException so needs to continue to be compile/run with preview features enabled. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24923#issuecomment-2865643883
