On Fri, 11 Apr 2025 08:14:29 GMT, Kim Barrett <[email protected]> wrote:
>> test/hotspot/jtreg/gc/TestNativeReferenceGet.java line 137:
>>
>>> 135: }
>>> 136: checkQueue(); // One last check after refproc
>>> complete.
>>> 137: } catch (InterruptedException e) {
>>
>> Rather than using Reference.remove with a timeout, I've changed this to use
>> waitForReferenceProcessing.
>> That removes false passes (from reference processing being slow to deliver)
>> and also removes the delay
>> until timeout for the passing case.
>
> https://github.com/openjdk/jdk/pull/24527 is proposing a different way to
> access
> `waitForReferenceProcessing`. I'll wait for that.
Test has now been changed to use the new
`WhiteBox::waitForReferenceProcessing()`.
So how about some reviews...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24315#discussion_r2082106208
