On Thu, 17 Apr 2025 21:29:21 GMT, Markus KARG wrote:
>> This Pull Request proposes an implementation for
>> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
>> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
>> dstBegin)` to the `CharSequence` i
On Thu, 17 Apr 2025 00:08:55 GMT, Chen Liang wrote:
> The downcallHandle method in Linker has a complex implementation, and type
> switches is triggered in multiple places in that handle.
>
> After bytestacks analysis of a simple program that links the native
> implementation of Class::forName
On Fri, 18 Apr 2025 02:32:39 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/io/Reader.java line 424:
>>
>>> 422: int n;
>>> 423: while ((n = read(str)) != -1) {
>>> 424: result.append(str, 0, n);
>>
>> If the characters in the Reader are always Latin1, t
On Fri, 18 Apr 2025 04:08:56 GMT, Alexey Bakhtin wrote:
> Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource
> in the main XMLSchemaMessages.properties file.
LGTM. Added a link to JDK-8355006.
-
Marked as reviewed by joehw (Reviewer).
PR Review: https:/
On Fri, 28 Mar 2025 13:19:50 GMT, Viktor Klang wrote:
>> He-Pin(kerr) has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - .
>> - .
>
> test/jdk/java/util/concurrent/tck/ThreadPoolExecutorTest.java line 44:
>
>> 42: import java.util.Colle
On Thu, 17 Apr 2025 19:44:07 GMT, Chen Liang wrote:
> Perf numbers for simple main:
> Linking of `Class::forName0` down from ~152 to ~83
>
> For calling little color management system
> https://bugs.openjdk.org/browse/JDK-8313344:
> JNI: ~45
> baseline panama: ~164
> patch: ~103
>
> Also see #
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful messages.
He-Pin(kerr) has updated the pull request incr
On Fri, 18 Apr 2025 02:26:10 GMT, Shaojin Wen wrote:
>> Brian Burkhalter has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8354724: Increment copyright year in Reader
>> - 8354724: Move readString from BufferedReader to Reader
>
> src/j
On Thu, 17 Apr 2025 23:07:35 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8354724: Increment copyright year in Reader
> - 835
On Fri, 18 Apr 2025 02:45:56 GMT, Chen Liang wrote:
>> We need to provide a StringBuilder that creates a coder of UTF16 to avoid
>> the unnecessary UTF16 to LATIN1 conversion overhead here.
>>
>> If we do not want to add a new public method, we can add an internal method
>> and expose it thro
On Thu, 17 Apr 2025 22:05:31 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> simple/special case in check invocation
>
> test/jdk/java/util/Currency/ValidateISO4217.java line 203:
>
>> 201: Co
On Thu, 17 Apr 2025 23:07:35 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8354724: Increment copyright year in Reader
> - 835
On Wed, 16 Apr 2025 17:43:58 GMT, Alan Bateman wrote:
>> I am not sure what you mean here as file paths _can_ contain (s) space(s).
>
> The question is about directories in the path that end with space. So yes,
> the file path may contain spaces but the proposed check is only looking at
> the e
On Thu, 17 Apr 2025 23:00:25 GMT, Calvin Cheung wrote:
> > Do we have a test case where `--add-opens` is used both at dump time and
> > run time? That will verify that `--add-opens` at dump time is correctly
> > processed.
>
> Yes, the new test `AddopensOption.java` uses the `--add-opens` both
On Thu, 17 Apr 2025 18:03:47 GMT, Vladimir Ivanov wrote:
>> Migrate Vector API math library (SVML and SLEEF) linkage from native code
>> (in JVM) to Java FFM API.
>>
>> Since FFM API doesn't support vector calling conventions yet, migration
>> affects only symbol lookup for now. But it still e
On Thu, 17 Apr 2025 18:08:21 GMT, Vladimir Ivanov wrote:
>> Please see the `addr` definition code in
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/vectorIntrinsics.cpp#L1877
>> . If queried `addr` returns `nullptr` for 256-bit vectors, and the arch
>> supports scalable v
> This patch optimizes the following patterns:
> For integer types:
>
> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1))
> => (VectorMaskCmp src1 src2 ncond)
> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1))
> => (VectorMaskCmp src1 src2 ncond)
>
> cond can be eq, ne, le, ge, l
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables significant
> simplifications on JVM side.
>
> The patc
> Please review this PR which improves the _ValidateISO4217_ Currency test by
> adding testing of future currencies after the transition date.
>
> This is done by creating a patched version of Currency that replaces
> `System.currentTimeMillis()` calls with a mocked value equivalent to
> `Long.
On Thu, 17 Apr 2025 21:21:22 GMT, Ioi Lam wrote:
> Do we have a test case where `--add-opens` is used both at dump time and run
> time? That will verify that `--add-opens` at dump time is correctly processed.
>
Yes, the new test `AddopensOption.java` uses the `--add-opens` both at dump
time a
Rework Executor class from jpackage test lib to support separate configuration
of stdout and stderr streams handling:
- New `Executor.discardStdout(boolean)` and `Executor.discardStderr(boolean)`
methods enable/disable stdout and stderr streams, respectively;
- New `Executor.Result.stdout()` ac
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with two additional
commits since the last revision:
- 8354724: Increment copyright year in Reader
- 8354724: Move readString from BufferedReader to Reader
-
Chan
On Thu, 17 Apr 2025 23:47:09 GMT, Alexey Semenyuk wrote:
> Rework Executor class from jpackage test lib to support separate
> configuration of stdout and stderr streams handling:
> - New `Executor.discardStdout(boolean)` and
> `Executor.discardStderr(boolean)` methods enable/disable stdout and
On Thu, 17 Apr 2025 22:13:06 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Change the test to reuse a ByteBuffer when wr
On Thu, 17 Apr 2025 18:53:16 GMT, Alexey Semenyuk wrote:
> - Add tests covering command output handling in the Executor class
> - Fix revealed bugs
> - Add a couple of `Executor.of()` convenience methods
>
> The test is implemented in a way that it will remain mostly unchanged when
> Executor
On Thu, 17 Apr 2025 20:51:10 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
On Thu, 17 Apr 2025 22:13:06 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Change the test to reuse a ByteBuffer when wr
On Thu, 17 Apr 2025 18:53:16 GMT, Alexey Semenyuk wrote:
> - Add tests covering command output handling in the Executor class
> - Fix revealed bugs
> - Add a couple of `Executor.of()` convenience methods
>
> The test is implemented in a way that it will remain mostly unchanged when
> Executor
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementall
On Thu, 17 Apr 2025 00:08:55 GMT, Chen Liang wrote:
> The downcallHandle method in Linker has a complex implementation, and type
> switches is triggered in multiple places in that handle.
>
> After bytestacks analysis of a simple program that links the native
> implementation of Class::forName
On Thu, 17 Apr 2025 07:14:25 GMT, Timofei Pushkin wrote:
>> src/hotspot/share/cds/classListParser.cpp line 517:
>>
>>> 515: return;
>>> 516: }
>>> 517: assert(!supertype->is_shared_unregistered_class(), "unregistered
>>> supertype cannot be overshadowed");
>>
>> Does this always preven
On Thu, 17 Apr 2025 07:41:36 GMT, Timofei Pushkin wrote:
>> If a base class is package-private then its subclasses should have the same
>> package name and defining class loader, otherwise `IllegalAccessError` is
>> thrown when linking a subclass. Currently when dumping a static archive
>> sep
On Thu, 17 Apr 2025 22:13:06 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Change the test to reuse a ByteBuffer when wr
On Thu, 17 Apr 2025 21:29:21 GMT, Markus KARG wrote:
>> This Pull Request proposes an implementation for
>> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
>> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
>> dstBegin)` to the `CharSequence` i
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Change the test to reuse a ByteBuffer when writing the file
-
Changes:
- all: https://git.openjdk.o
On Thu, 17 Apr 2025 21:35:08 GMT, Justin Lu wrote:
>> Please review this PR which improves the _ValidateISO4217_ Currency test by
>> adding testing of future currencies after the transition date.
>>
>> This is done by creating a patched version of Currency that replaces
>> `System.currentTimeM
On Thu, 17 Apr 2025 19:08:52 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Address all PR comments to now
>
> src/java.base/share/classes/java/io/BufferedReader.java line 417:
>
>>
On Wed, 16 Apr 2025 17:04:07 GMT, Jaikiran Pai wrote:
> > IIUC then you will be fine with a test that solely tests the default
> > implementation of CharSequence.getChars()?
>
> Correct. And a similar separate test for `CharBuffer.getChars()` since that
> one too is a new default implementatio
> This Pull Request proposes an implementation for
> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
> dstBegin)` to the `CharSequence` interface, providing a **bulk-read**
> facility including a
On Wed, 16 Apr 2025 18:21:41 GMT, Calvin Cheung wrote:
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
On Thu, 17 Apr 2025 16:44:02 GMT, Henry Jen wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ClassFileReader.java line 105:
>
>> 103:
>> 104: pr
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance is available. (The old error check existed only for con
> Please review this PR which improves the _ValidateISO4217_ Currency test by
> adding testing of future currencies after the transition date.
>
> This is done by creating a patched version of Currency that replaces
> `System.currentTimeMillis()` calls with a mocked value equivalent to
> `Long.
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote:
> Added problemlists and and requires for execution tests with --enable-preview.
>
> The --enable-preview features might significantly change VM/JDK behavior and
> sometimes it is useful to run tests with preview features enabled. Eventuall
On Thu, 17 Apr 2025 14:01:07 GMT, Magnus Ihse Bursie wrote:
> Is there some specific problem you are worried about on Windows that you were
> thinking about?
I would have tested on non-English (preferrably Chinese/Japanese) Windows where
users set it to English. I believe we had issues from co
On Thu, 17 Apr 2025 19:34:13 GMT, Chen Liang wrote:
> I don't see how `readString` is particularly line oriented; making
> `readAllLines` specific to `BufferedReader` makes sense.
Put another way, I don't think it makes sense to break up the higher level APIs
across classes.
The buffering prov
The downcallHandle method in Linker has a complex implementation, and type
switches is triggered in multiple places in that handle.
After bytestacks analysis of a simple program that links the native
implementation of Class::forName0, it turns out that:
1. there are a few missed usages of type s
On Thu, 17 Apr 2025 18:45:13 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Address all PR comments to now
I don't see h
On Thu, 17 Apr 2025 05:06:24 GMT, Chen Liang wrote:
> Just curious, which tiers have you run with forced `--enable-preview` and
> discovered such incompatible tests?
I've run tiers 1-3 and have not found any incompatible tests (by that means).
-
PR Comment: https://git.openjdk.org
On Thu, 17 Apr 2025 18:45:13 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Address all PR comments to now
The base `Rea
On Thu, 17 Apr 2025 18:53:16 GMT, Alexey Semenyuk wrote:
> - Add tests covering command output handling in the Executor class
> - Fix revealed bugs
> - Add a couple of `Executor.of()` convenience methods
>
> The test is implemented in a way that it will remain mostly unchanged when
> Executor
- Add tests covering command output handling in the Executor class
- Fix revealed bugs
- Add a couple of `Executor.of()` convenience methods
The test is implemented in a way that it will remain mostly unchanged when
Executor supports disabling of stderr and stdout streams.
-
Commi
On Thu, 17 Apr 2025 00:30:00 GMT, Stuart Marks wrote:
>> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac)
>> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows)
>> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the
>> na
On Thu, 17 Apr 2025 17:30:06 GMT, Johannes Graham wrote:
>> test/jdk/java/io/BufferedReader/ReadAll.java line 34:
>>
>>> 32:
>>> 33: import java.io.BufferedReader;
>>> 34: import java.io.File;
>>
>> Cosmetic thought - I think this could all be done with Path, avoiding File
>> and friends.
>
>
On Thu, 17 Apr 2025 17:05:54 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Address all PR comments to now
>
> src/java.base/share/classes/java/io/BufferedReader.java line 440:
>
>>
On Thu, 17 Apr 2025 17:19:03 GMT, Chen Liang wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Address all PR comments to now
>
> src/java.base/share/classes/java/io/BufferedReader.java line 419:
>
>> 4
On Thu, 17 Apr 2025 16:42:54 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/BufferedReader.java line 459:
>>
>>> 457: * @since 25
>>> 458: */
>>> 459: public String readString() throws IOException {
>>
>> Suggestion:
>>
>> public String readString() thro
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Address all PR comments to now
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24728/files
- n
On Sat, 12 Apr 2025 02:19:35 GMT, Stuart Marks wrote:
> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac)
> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows)
> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the
> native
On Thu, 17 Apr 2025 00:26:49 GMT, Stuart Marks wrote:
>> I belive they can be removed as they are no where used (and I don't think it
>> will be used for `stdin.encoding` either) So I prefer removing those unused
>> code now.
>
> OK, I've done so. Now testing on Windows
(CI run built and p
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables significant
> simplifications on JVM side.
>
> The patc
On Thu, 17 Apr 2025 17:20:57 GMT, Chen Liang wrote:
> Is there a particular reason that these methods should exist only on
> `BufferedReader` but not the base `Reader`?
Good question. Perhaps @RogerRiggs could comment on that.
-
PR Comment: https://git.openjdk.org/jdk/pull/24728#i
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
> /csr needed
I was going to do that _after_ consensus had been achieved here. It's extra
work to create a CSR before that point, especially as that point might not be
reached.
On Fri, 11 Apr 2025 22:45:55 GMT, Chen Liang wrote:
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance i
Fix a NPE on calling DocumentBuilderFactory::getAttribute. This issue was found
during the previous JCK test (JCK-7322355). The JCK failure was from a
different method call, but it appears this is the root cause.
Also in this patch: consolidates get and set properties to use the same Util
metho
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
test/jdk/java/io/BufferedReader/ReadAll.java line 34:
> 32:
> 33: import java.io.BufferedReader;
> 34: import java.io.File;
Cosmetic thought - I think this could all be done wit
On Thu, 17 Apr 2025 17:28:12 GMT, Johannes Graham wrote:
>> Implement the requested methods and add a test thereof.
>
> test/jdk/java/io/BufferedReader/ReadAll.java line 34:
>
>> 32:
>> 33: import java.io.BufferedReader;
>> 34: import java.io.File;
>
> Cosmetic thought - I think this could all
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
Is there a particular reason that these methods should exist only on
`BufferedReader` but not the base `Reader`? Similar read-all operation
`InputStream::readAllBytes` exists on
On Wed, 16 Apr 2025 18:21:41 GMT, Calvin Cheung wrote:
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
src/java.base/share/classes/java/io/BufferedReader.java line 440:
> 438: * Reads all characters into a string.
> 439: *
> 440: * This method reads all content incl
On Thu, 17 Apr 2025 00:15:47 GMT, Naoto Sato wrote:
> > As the test tracks the ISO 4217 data, manual testing of this change can be
> > done by modifying the cut-over year from 2025 to 2026 for the
> > `CW=ANG;2025-04-01-04-00-00;XCG` entry for both the JDK and test data.
>
> Would it be possib
On Thu, 17 Apr 2025 16:36:53 GMT, Hendrik Schick wrote:
>> Implement the requested methods and add a test thereof.
>
> src/java.base/share/classes/java/io/BufferedReader.java line 459:
>
>> 457: * @since 25
>> 458: */
>> 459: public String readString() throws IOException {
>
> Su
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
A CSR will be filed if the discussion in this request converges to consensus.
-
PR Comment: https://git.openjdk.org/jdk/pull/24728#issuecomment-2813488383
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
src/java.base/share/classes/java/io/BufferedReader.java line 459:
> 457: * @since 25
> 458: */
> 459: public String readString() throws IOException {
Suggestion:
On Thu, 17 Apr 2025 00:30:00 GMT, Stuart Marks wrote:
>> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac)
>> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows)
>> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the
>> na
On Fri, 11 Apr 2025 17:31:08 GMT, Johannes Graham wrote:
> The `DigitList` class used in `DecimalFormat` does not reset the `data` array
> in its clone method. This can cause interference when clones are used
> concurrently.
This pull request has now been integrated.
Changeset: 04c32fc0
Autho
Implement the requested methods and add a test thereof.
-
Commit messages:
- 8354724: BufferedReader readAllLines and readString methods
Changes: https://git.openjdk.org/jdk/pull/24728/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24728&range=00
Issue: https://bugs.open
On Thu, 17 Apr 2025 07:38:27 GMT, Timofei Pushkin wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/customLoader/RegUnregSuperTest.java
>> line 77:
>>
>>> 75: out.shouldContain("CustomLoadee3Child (id 3) has super-type
>>> CustomLoadee3 (id 1) overshadowed by another class with the s
As part of the UTF-8 cleaning up done in
[JDK-8301971](https://bugs.openjdk.org/browse/JDK-8301971), I looked at where
and how we are using unicode sequences (`\u`). In several string literals,
I think the unicode sequences still has merit, if they improve clarity or
readability of the code
On Wed, 16 Apr 2025 17:37:07 GMT, David Beaumont wrote:
>> Increasing timeout for deadlock detection and adjusting for the timeout
>> factor in higher tiers.
>
> David Beaumont has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing test
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
`KEEPALIVE`
-
PR Comment: https://git.openjdk.org/jdk/pull/24063#issuecomment-281301
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote:
>> Most of the JDK code base has been transitioned to UTF-8, but not all. This
>> has recently become an acute problem, since our mixing of iso-8859-1 and
>> utf-8 in properties files confused the version of `sed` that is shipped with
On Wed, 16 Apr 2025 16:14:39 GMT, Naoto Sato wrote:
> We will probably need to make sure things are ok on Windows as well (they are
> the other confusing environment)
Windows is much more painful to work with, since there is no correspondence of
`LC_ALL`; you must set the user's locale. There
On Wed, 16 Apr 2025 17:40:39 GMT, Johannes Graham wrote:
>> The `DigitList` class used in `DecimalFormat` does not reset the `data`
>> array in its clone method. This can cause interference when clones are used
>> concurrently.
>
> Johannes Graham has updated the pull request incrementally with
On Wed, 16 Apr 2025 17:40:39 GMT, Johannes Graham wrote:
>> The `DigitList` class used in `DecimalFormat` does not reset the `data`
>> array in its clone method. This can cause interference when clones are used
>> concurrently.
>
> Johannes Graham has updated the pull request incrementally with
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote:
> Added problemlists and and requires for execution tests with --enable-preview.
>
> The --enable-preview features might significantly change VM/JDK behavior and
> sometimes it is useful to run tests with preview features enabled. Eventuall
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac)
> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows)
> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the
> native.encoding property will be set from sprops.encoding and
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
On Thu, 10 Apr 2025 14:19:25 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address comments on original vs underlying
Last review pass?
On Thu, 17 Apr 2025 05:45:50 GMT, Calvin Cheung wrote:
>> Timofei Pushkin has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Empty commit to make GH update the PR
>> - Merge remote-tracking branch 'openjdk-jdk/m
On Wed, 16 Apr 2025 21:52:46 GMT, Ioi Lam wrote:
>> Timofei Pushkin has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Empty commit to make GH update the PR
>> - Merge remote-tracking branch 'openjdk-jdk/master'
93 matches
Mail list logo
