On Thu, 17 Apr 2025 23:00:25 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
> > Do we have a test case where `--add-opens` is used both at dump time and > > run time? That will verify that `--add-opens` at dump time is correctly > > processed. > > Yes, the new test `AddopensOption.java` uses the `--add-opens` both at dump > time and run time. I have done some minor cleanup on the test, please review > the new version. AddopensOption.java only checks if the --add-opens is accepted. It doesn't check if the option has any effect. I think it's better to run `TEST_MODULE1` to make sure that `setAccessible` can be called without throwing an exception. That will verify that the option has achieved the intended effect. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24695#issuecomment-2814318147
