On Thu, 17 Apr 2025 00:15:47 GMT, Naoto Sato <na...@openjdk.org> wrote:
> > As the test tracks the ISO 4217 data, manual testing of this change can be > > done by modifying the cut-over year from 2025 to 2026 for the > > `CW=ANG;2025-04-01-04-00-00;XCG` entry for both the JDK and test data. > > Would it be possible to use `currency.properties` file to provide a test > transition, and use this logic test the validity, so that it is not a manual > testing? Still it is not 100% same with the data from `currency.data`, but at > least provides the transition logic validity, possibly for both simple and > special currencies. That's an interesting idea, I think it is possible. As you stated, the logic is different, but it would guarantee that the second run is indeed testing in the future. I'm not sure how combining a currency.properties override with the main ValidateISO4217 test will turn out though since the test should track 1 to 1 with the ISO data. Will look into it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24701#issuecomment-2813567220
