> Hi all,
>
> Test test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java run passed
> unexpected without native library or with the incorrect native library path.
> The test command with incorrect native library path shows below. We will seen
> this tests run passed unexpected before this PR
On Wed, 12 Feb 2025 07:15:58 GMT, Alan Bateman wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename latch to started, and do the countDown before the while loop
>
> test/jdk/java/lang/Thread/virtual/ThreadPollOnYiel
On Mon, 10 Feb 2025 13:23:49 GMT, Coleen Phillimore wrote:
>> This change removes the native call and injected field for ProtectionDomain
>> in the java.lang.Class instance, and moves the field to be declared in Java.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request wit
> Hi all,
>
> Test test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java run passed
> unexpected without native library or with the incorrect native library path.
> The test command with incorrect native library path shows below. We will seen
> this tests run passed unexpected before this PR
On Wed, 12 Feb 2025 03:24:07 GMT, SendaoYan wrote:
> Hi all,
>
> Test test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java run passed
> unexpected without native library or with the incorrect native library path.
> The test command with incorrect native library path shows below. We will se
On Mon, 10 Feb 2025 13:23:49 GMT, Coleen Phillimore wrote:
>> This change removes the native call and injected field for ProtectionDomain
>> in the java.lang.Class instance, and moves the field to be declared in Java.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request wit
On Wed, 12 Feb 2025 03:53:47 GMT, David Holmes wrote:
> Trivial fix for missing comma.
>
> Thanks
Thanks David. Apologize for mine carelessness.
-
PR Comment: https://git.openjdk.org/jdk/pull/23577#issuecomment-2652752680
On Wed, 12 Feb 2025 03:43:53 GMT, David Holmes wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove the additional check for virtual thread of
>> test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java
>
> test/jd
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
Hi all,
Test test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java run passed
unexpected without native library or with the incorrect native library path.
The test command with incorrect native library path shows below. We will seen
this tests run passed unexpected before this PR, because th
On Tue, 11 Feb 2025 02:45:11 GMT, SendaoYan wrote:
> H all,
>
> This PR add `/native` keyword in the test header for virtual thread tests.
> The `/native` keyword will make run the related tests by jtreg standalone
> more friendly.
>
> I runed all the tests without -nativepath argument and fi
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
On Mon, 10 Feb 2025 13:23:49 GMT, Coleen Phillimore wrote:
>> This change removes the native call and injected field for ProtectionDomain
>> in the java.lang.Class instance, and moves the field to be declared in Java.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request wit
On Tue, 11 Feb 2025 17:50:45 GMT, Jamil Nimeh wrote:
> This fix makes some minor changes to the internals of the
> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
> works better now with thes
On Tue, 11 Feb 2025 17:50:45 GMT, Jamil Nimeh wrote:
> This fix makes some minor changes to the internals of the
> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
> works better now with thes
On Tue, 11 Feb 2025 21:47:31 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>
> This PR fixes two issues:
> - the original issue is a crash caused by `__ warn` corrupting the stack on
> Windows only
> - This issue also uncovered that -Xcheck:jni test cases were getting 65k
> lines of warning on HelloWorld (on
On Wed, 5 Feb 2025 20:11:36 GMT, Alexey Semenyuk wrote:
> Enable MSI installers to block installation if the version of Windows is too
> old.
>
> jpackage will read major and minor OS versions from PE headers of the main
> launcher and `java.dll` in the app image. The combined version is the m
The return value adaption of Proxy is problematic, that it may attempt to
access package-private types inaccessible to its package in a `checkcast`
instruction, which causes `IllegalAccessError` if the returned object is not
`null`. This likely affects all Java versions since the publication of
This fix makes some minor changes to the internals of the `CertificateBuilder`
and `SimpleOCSPServer` test classes. They would break when ML-DSA was selected
as key and signing algorithms. Also RSASSA-PSS works better now with these
changes. I've also taken this opportunity to do some cleanup
On Fri, 7 Feb 2025 20:05:49 GMT, Naoto Sato wrote:
>> This is a follow-on fix to
>> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java
>> launcher can take arguments from "JDK_JAVA_OPTIONS" environment variable, so
>> the same processing is needed. Also, obsolete code for Win
On Thu, 6 Feb 2025 19:46:21 GMT, Naoto Sato wrote:
> This is a follow-on fix to
> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java launcher
> can take arguments from "JDK_JAVA_OPTIONS" environment variable, so the same
> processing is needed. Also, obsolete code for Windows
On Tue, 11 Feb 2025 16:36:24 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/classfile/constantpool/Utf8Entry.java
>> line 95:
>>
>>> 93: * @since 25
>>> 94: */
>>> 95: boolean equalsSymbol(ClassDesc desc);
>>
>> Ambiguity of class internal name vs. descriptor ser
On Tue, 11 Feb 2025 08:03:23 GMT, Adam Sotona wrote:
>> The ClassFile API promotes usage of constant nominal descriptors over
>> literal strings. However, for `class` file parsing, currently the efficient
>> way to check if a constant pool entry matches a desired descriptor is via
>> unrolling
On Fri, 7 Feb 2025 19:40:44 GMT, Chen Liang wrote:
> In CodeBuilder, validation for a slot was missing due to concurrent patches,
> and the original patch did not add effective tests for CodeBuilder because of
> the complex exceptional behaviors. Now the bug is fixed with renames to
> prevent
On Fri, 7 Feb 2025 19:40:44 GMT, Chen Liang wrote:
> In CodeBuilder, validation for a slot was missing due to concurrent patches,
> and the original patch did not add effective tests for CodeBuilder because of
> the complex exceptional behaviors. Now the bug is fixed with renames to
> prevent
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a `MemorySegment` to capture potential error states. This can lead
> to negative performance implications if not designed carefully
On Fri, 7 Feb 2025 17:43:15 GMT, Alexey Semenyuk wrote:
>> As far as my testing is concerned it's only `jdk.crypto.cryptoki` which is
>> different with `--bind-services` (as it provides a security provider as a
>> service and doesn't export API).
>
> This is the diff of modules between "jpackag
> The change for JDK-8346434 added a new test case to
> tools/jpackage/share/JLinkOptionsTest.java which does not respect the
> constraint of the linkable runtime (JEP 493) that no jdk.jlink module can be
> part of the target image.
> This can be circumvented by limiting the modules.
Christoph
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
On Tue, 11 Feb 2025 09:00:46 GMT, SendaoYan wrote:
>> Can you remove this change from the PR as it this is a separate discussion?
>> My guess is that in your environment the Thread.yield is somehow taking more
>> than 5 seconds, is that right? In that case, we can modify the test to use a
>> l
On Tue, 11 Feb 2025 08:53:41 GMT, Alan Bateman wrote:
>> Reason description as
>> https://github.com/openjdk/jdk/pull/23550#issuecomment-2650141187.
>
> Can you remove this change from the PR as it this is a separate discussion?
> My guess is that in your environment the Thread.yield is somehow
> H all,
>
> This PR add `/native` keyword in the test header for virtual thread tests.
> The `/native` keyword will make run the related tests by jtreg standalone
> more friendly.
>
> I runed all the tests without -nativepath argument and find the fail tests.
> This will find all the virtual
On Tue, 11 Feb 2025 08:44:15 GMT, SendaoYan wrote:
>> test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java line 69:
>>
>>> 67: if (flag != true) {
>>> 68: throw new RuntimeException("flag = " + flag);
>>> 69: }
>>
>> What are these other changes about?
>
> Reason
On Tue, 11 Feb 2025 08:44:15 GMT, Alan Bateman wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add /native for test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java
>> test/jdk/java/lang/Thread/virtual/Starvation.
> H all,
>
> This PR add `/native` keyword in the test header for virtual thread tests.
> The `/native` keyword will make run the related tests by jtreg standalone
> more friendly.
>
> I runed all the tests without -nativepath argument and find the fail tests.
> This will find all the virtual
On Tue, 11 Feb 2025 08:41:44 GMT, Alan Bateman wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add /native for test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java
>> test/jdk/java/lang/Thread/virtual/Starvation.
On Tue, 11 Feb 2025 08:38:48 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
On Tue, 11 Feb 2025 07:30:49 GMT, Alan Bateman wrote:
> Can you check if these two needs to be updated too?
>
> test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java
> test/jdk/java/lang/Thread/virtual/Starvation.java
These two tests also need `/native` keyword.
- Test test/jdk/java/lang/T
On Sat, 11 Jan 2025 07:10:53 GMT, He-Pin(kerr) wrote:
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful m
> H all,
>
> This PR add `/native` keyword in the test header for virtual thread tests.
> The `/native` keyword will make run the related tests by jtreg standalone
> more friendly.
>
> I runed all the tests without -nativepath argument and find the fail tests.
> This will find all the virtual
On Mon, 10 Feb 2025 08:21:21 GMT, Alan Bateman wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
On Tue, 11 Feb 2025 02:26:57 GMT, Chen Liang wrote:
> The ClassFile API promotes usage of constant nominal descriptors over literal
> strings. However, for `class` file parsing, currently the efficient way to
> check if a constant pool entry matches a desired descriptor is via unrolling
> them
45 matches
Mail list logo
