Re: [jdk24] RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError

2025-02-04 Thread SendaoYan
On Tue, 7 Jan 2025 15:14:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24. > > The commi

[jdk24] Withdrawn: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError

2025-02-04 Thread SendaoYan
On Tue, 7 Jan 2025 15:14:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24. > > The commi

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v17]

2025-02-04 Thread Jatin Bhateja
On Tue, 4 Feb 2025 19:18:39 GMT, Chen Liang wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing typos > > src/java.base/share/classes/jdk/internal/vm/vector/Float16Math.java line 42: > >> 40: } >> 41: >>

[jdk24] Integrated: 8349183: [BACKOUT] Optimization for StringBuilder append boolean & null

2025-02-04 Thread Jaikiran Pai
On Mon, 3 Feb 2025 18:41:44 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of > https://github.com/openjdk/jdk/pull/23420 into jdk24? > > This proposes to bring in those same backouts into `jdk24` to prevent the > issue noted in that PR description. jdk24 is in rampdown

Re: RFR: 8349344: Clarify documentation of Arena.ofConfined

2025-02-04 Thread Jaikiran Pai
On Tue, 4 Feb 2025 09:46:48 GMT, Per Minborg wrote: > This PR proposes to clarify the documentation for `Arena.ofConfined()`. It is > proposed to say that segments allocated from the returned `Arena` can _only_ > be accessed by the thread that created the `Arena` in the first place. Marked as

Re: RFR: 8349145: Make Class.getProtectionDomain() non-native [v4]

2025-02-04 Thread David Holmes
On Mon, 3 Feb 2025 16:11:06 GMT, Coleen Phillimore wrote: >> This change removes the native call and injected field for ProtectionDomain >> in the java.lang.Class instance, and moves the field to be declared in Java. >> Tested with tier1-4. > > Coleen Phillimore has updated the pull request incr

Re: [jdk24] RFR: 8349183: [BACKOUT] Optimization for StringBuilder append boolean & null

2025-02-04 Thread Jaikiran Pai
On Mon, 3 Feb 2025 18:41:44 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of > https://github.com/openjdk/jdk/pull/23420 into jdk24? > > This proposes to bring in those same backouts into `jdk24` to prevent the > issue noted in that PR description. jdk24 is in rampdown

RFR: 8333569: jpackage tests must run app launchers with retries on Linux only

2025-02-04 Thread Alexey Semenyuk
Run app launchers in jpackage tests with retries on Linux only. Run them without retries on other platforms. Supplementary remove `HelloApp.AppOutputVerifier.removePathEnvVar()` function. It sets an unused member field and is a leftover from [JDK-8347300](https://bugs.openjdk.org/browse/JDK-834

Re: RFR: 8346434: Add test for non-automatic service binding

2025-02-04 Thread Alexander Matveev
On Fri, 10 Jan 2025 21:23:22 GMT, Alexey Semenyuk wrote: > Added a test case to JLinkOptionsTest to test that jpackage doesn't bind > services in app's runtime by default. > > The test builds two app images for the same app. One with the default jlink > options and another with `--bind-service

Re: RFR: 8346434: Add test for non-automatic service binding

2025-02-04 Thread Alexey Semenyuk
On Fri, 10 Jan 2025 21:23:22 GMT, Alexey Semenyuk wrote: > Added a test case to JLinkOptionsTest to test that jpackage doesn't bind > services in app's runtime by default. > > The test builds two app images for the same app. One with the default jlink > options and another with `--bind-service

Re: RFR: 8346434: Add test for non-automatic service binding

2025-02-04 Thread Abdelhak Zaaim
On Fri, 10 Jan 2025 21:23:22 GMT, Alexey Semenyuk wrote: > Added a test case to JLinkOptionsTest to test that jpackage doesn't bind > services in app's runtime by default. > > The test builds two app images for the same app. One with the default jlink > options and another with `--bind-service

RFR: 8346434: Add test for non-automatic service binding

2025-02-04 Thread Alexey Semenyuk
Added a test case to JLinkOptionsTest to test that jpackage doesn't bind services in app's runtime by default. The test builds two app images for the same app. One with the default jlink options and another with `--bind-services` jlink option. The test compares module lists from both runtimes.

Integrated: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails

2025-02-04 Thread SendaoYan
On Mon, 3 Feb 2025 07:49:21 GMT, SendaoYan wrote: > Hi all, > The JMH test > "org.openjdk.bench.java.time.format.ZonedDateTimeFormatterBenchmark.parse" > fails "java.time.format.DateTimeParseException: Text '2015:03:10:12:13:ECT' > could not be parsed at index 17". > The `ECT` standard for "Am

Re: RFR: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails [v2]

2025-02-04 Thread SendaoYan
On Tue, 4 Feb 2025 02:40:59 GMT, SendaoYan wrote: >> Hi all, >> The JMH test >> "org.openjdk.bench.java.time.format.ZonedDateTimeFormatterBenchmark.parse" >> fails "java.time.format.DateTimeParseException: Text '2015:03:10:12:13:ECT' >> could not be parsed at index 17". >> The `ECT` standard f

Re: RFR: 8346567: Make Class.getModifiers() non-native [v2]

2025-02-04 Thread Dean Long
On Tue, 4 Feb 2025 14:43:51 GMT, Coleen Phillimore wrote: >> The Class.getModifiers() method is implemented as a native method in >> java.lang.Class to access a field that we've calculated when creating the >> mirror. The field is final after that point. The VM doesn't need it >> anymore, so

Re: RFR: 8347009: Speed ​​up parseInt and parseLong [v15]

2025-02-04 Thread Shaojin Wen
> This is an optimization for decimal Integer.parseInt and Long.parseLong, > which improves performance by about 10%. The optimization includes: > 1. Improve performance by parsing 2 numbers at a time, which has performance > improvements for numbers with length >= 3. > 2. It uses charAt(0) for t

Re: RFR: 8347009: Speed ​​up parseInt and parseLong [v14]

2025-02-04 Thread Shaojin Wen
> This is an optimization for decimal Integer.parseInt and Long.parseLong, > which improves performance by about 10%. The optimization includes: > 1. Improve performance by parsing 2 numbers at a time, which has performance > improvements for numbers with length >= 3. > 2. It uses charAt(0) for t

Re: RFR: 8315585: Optimization for decimal to string [v4]

2025-02-04 Thread Shaojin Wen
On Sat, 1 Feb 2025 08:42:32 GMT, Shaojin Wen wrote: >> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString >> and BigDecimal::toPlainString performance and reduce duplicate code > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a re

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v9]

2025-02-04 Thread Shaojin Wen
> The following code can reproduce the problem, writing out of bounds causes > JVM Crash > > > StringBuilder buf = new StringBuilder(); > buf.append('中'); > > Thread[] threads = new Thread[40]; > final CountDownLatch latch = new CountDownLatch(threads.length); >

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v8]

2025-02-04 Thread Shaojin Wen
On Tue, 4 Feb 2025 22:54:48 GMT, Shaojin Wen wrote: >> The following code can reproduce the problem, writing out of bounds causes >> JVM Crash >> >> >> StringBuilder buf = new StringBuilder(); >> buf.append('中'); >> >> Thread[] threads = new Thread[40]; >> fin

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v8]

2025-02-04 Thread Shaojin Wen
> The following code can reproduce the problem, writing out of bounds causes > JVM Crash > > > StringBuilder buf = new StringBuilder(); > buf.append('中'); > > Thread[] threads = new Thread[40]; > final CountDownLatch latch = new CountDownLatch(threads.length); >

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v7]

2025-02-04 Thread Shaojin Wen
> The following code can reproduce the problem, writing out of bounds causes > JVM Crash > > > StringBuilder buf = new StringBuilder(); > buf.append('中'); > > Thread[] threads = new Thread[40]; > final CountDownLatch latch = new CountDownLatch(threads.length); >

Re: RFR: 8349107: Remove RMI finalizers [v2]

2025-02-04 Thread Brent Christian
On Mon, 3 Feb 2025 19:13:10 GMT, Brent Christian wrote: >> 3 finalizers in RMI code can be removed, as they do not perform meaningful >> cleanup. >> >> **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`** >> >> `RegistryContext.finalize()` just calls `close()`. The `clo

Integrated: 8349107: Remove RMI finalizers

2025-02-04 Thread Brent Christian
On Sat, 1 Feb 2025 00:11:31 GMT, Brent Christian wrote: > 3 finalizers in RMI code can be removed, as they do not perform meaningful > cleanup. > > **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`** > > `RegistryContext.finalize()` just calls `close()`. The `close()`

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v6]

2025-02-04 Thread Shaojin Wen
> The following code can reproduce the problem, writing out of bounds causes > JVM Crash > > > StringBuilder buf = new StringBuilder(); > buf.append('中'); > > Thread[] threads = new Thread[40]; > final CountDownLatch latch = new CountDownLatch(threads.length); >

Re: RFR: 8315585: Optimization for decimal to string [v4]

2025-02-04 Thread Archie Cobbs
On Tue, Feb 4, 2025 at 2:40 PM Joe Darcy wrote: > Can we please have a pause on the sequence of "make XYZ toString faster" > PRs until there is some wider discussion of goals, etc.? Thanks. > I agree with this sentiment... It was surprising to see how easily a VM crash can sneak in. There is al

Re: RFR: 8315585: Optimization for decimal to string [v4]

2025-02-04 Thread Joe Darcy
On Sat, 1 Feb 2025 08:42:32 GMT, Shaojin Wen wrote: >> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString >> and BigDecimal::toPlainString performance and reduce duplicate code > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a re

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v6]

2025-02-04 Thread Volkan Yazici
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote: >> Adds `test.lib.Utils::createTempFileOfSize` to generate >> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory >> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file >> tracked by git: >> >>

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v17]

2025-02-04 Thread Chen Liang
On Tue, 4 Feb 2025 10:05:09 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection o

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v16]

2025-02-04 Thread Emanuel Peter
On Tue, 4 Feb 2025 09:56:15 GMT, Jatin Bhateja wrote: >> src/hotspot/share/opto/convertnode.cpp line 971: >> >>> 969: return true; >>> 970: default: >>> 971: return false; >> >> Does this cover all cases? What about `FmaHF`? > > FmaHF is a ternary operation and is intrinsified.

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v17]

2025-02-04 Thread Emanuel Peter
On Tue, 4 Feb 2025 10:05:09 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection o

Re: RFR: 8349107: Remove RMI finalizers [v2]

2025-02-04 Thread Stuart Marks
On Mon, 3 Feb 2025 19:13:10 GMT, Brent Christian wrote: >> 3 finalizers in RMI code can be removed, as they do not perform meaningful >> cleanup. >> >> **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`** >> >> `RegistryContext.finalize()` just calls `close()`. The `clo

Re: RFR: 8349344: Clarify documentation of Arena.ofConfined

2025-02-04 Thread Jorn Vernee
On Tue, 4 Feb 2025 09:46:48 GMT, Per Minborg wrote: > This PR proposes to clarify the documentation for `Arena.ofConfined()`. It is > proposed to say that segments allocated from the returned `Arena` can _only_ > be accessed by the thread that created the `Arena` in the first place. Marked as

RFR: 8344925: translet-name ignored when package-name is also set

2025-02-04 Thread Joe Wang
Fix an issue where the translet-name is incorrectly set when the package-name is also specified. - Commit messages: - update copyright - 8344925: translet-name ignored when package-name is also set Changes: https://git.openjdk.org/jdk/pull/23446/files Webrev: https://webrevs.ope

Re: RFR: 8349107: Remove RMI finalizers [v2]

2025-02-04 Thread Stuart Marks
On Mon, 3 Feb 2025 19:13:10 GMT, Brent Christian wrote: >> 3 finalizers in RMI code can be removed, as they do not perform meaningful >> cleanup. >> >> **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`** >> >> `RegistryContext.finalize()` just calls `close()`. The `clo

Re: RFR: 8337279: Optimize format instant [v15]

2025-02-04 Thread Naoto Sato
On Mon, 3 Feb 2025 22:31:10 GMT, Shaojin Wen wrote: >> By removing the redundant code logic in >> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be >> reduced and the performance can be improved. > > Shaojin Wen has updated the pull request incrementally with one addit

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v5]

2025-02-04 Thread Roger Riggs
On Tue, 4 Feb 2025 14:03:24 GMT, Shaojin Wen wrote: >> The following code can reproduce the problem, writing out of bounds causes >> JVM Crash >> >> >> StringBuilder buf = new StringBuilder(); >> buf.append('中'); >> >> Thread[] threads = new Thread[40]; >> fin

Re: RFR: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails [v2]

2025-02-04 Thread Naoto Sato
On Tue, 4 Feb 2025 02:40:59 GMT, SendaoYan wrote: >> Hi all, >> The JMH test >> "org.openjdk.bench.java.time.format.ZonedDateTimeFormatterBenchmark.parse" >> fails "java.time.format.DateTimeParseException: Text '2015:03:10:12:13:ECT' >> could not be parsed at index 17". >> The `ECT` standard f

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v5]

2025-02-04 Thread Chen Liang
On Tue, 4 Feb 2025 14:03:24 GMT, Shaojin Wen wrote: >> The following code can reproduce the problem, writing out of bounds causes >> JVM Crash >> >> >> StringBuilder buf = new StringBuilder(); >> buf.append('中'); >> >> Thread[] threads = new Thread[40]; >> fin

Re: [jdk24] RFR: 8349183: [BACKOUT] Optimization for StringBuilder append boolean & null

2025-02-04 Thread Chen Liang
On Mon, 3 Feb 2025 18:41:44 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of > https://github.com/openjdk/jdk/pull/23420 into jdk24? > > This proposes to bring in those same backouts into `jdk24` to prevent the > issue noted in that PR description. jdk24 is in rampdown

Integrated: 8349000: Performance improvement for Currency.isPastCutoverDate(String)

2025-02-04 Thread Justin Lu
On Thu, 30 Jan 2025 19:27:30 GMT, Justin Lu wrote: > Please review this PR which improves the performance of cut-over date > checking when the user supplies a properties override via the > `java.util.currency.data` sys prop. Replacing the `SimpleDateFormat` with a > _java.time_ alternative has

Re: RFR: 8349000: Performance improvement for Currency.isPastCutoverDate(String) [v3]

2025-02-04 Thread Justin Lu
On Mon, 3 Feb 2025 19:01:50 GMT, Justin Lu wrote: >> Please review this PR which improves the performance of cut-over date >> checking when the user supplies a properties override via the >> `java.util.currency.data` sys prop. Replacing the `SimpleDateFormat` with a >> _java.time_ alternative

Re: RFR: 8349145: Make Class.getProtectionDomain() non-native [v4]

2025-02-04 Thread Coleen Phillimore
On Tue, 4 Feb 2025 16:37:10 GMT, Alan Bateman wrote: >> One of the reasons I wanted to move this out of Hotspot as a native call is >> that it might make further work with ProtectionDomain easier to do all in >> Java, except there's still a bit of coupling in the JVM with the name of the >> cl

Re: RFR: 8349145: Make Class.getProtectionDomain() non-native [v4]

2025-02-04 Thread Alan Bateman
On Tue, 4 Feb 2025 14:59:46 GMT, Coleen Phillimore wrote: >> There may need to be some follow-on cleanup, e.g. I'm wondering if >> Lookup.cachedProtectionDomain is needed now. > > One of the reasons I wanted to move this out of Hotspot as a native call is > that it might make further work with

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v6]

2025-02-04 Thread Daniel Fuchs
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote: >> Adds `test.lib.Utils::createTempFileOfSize` to generate >> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory >> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file >> tracked by git: >> >>

Adopting SequencedCollection via multi-release jars?

2025-02-04 Thread Fabian Meumertzheim
Guava provides immutable collections such as ImmutableList that are naturally sequenced. It would be useful to integrate it with Java 21's SequencedCollection interface. However, Guava needs to keep supporting Java 11 for the foreseeable future. An idea that may allow Guava to remain compatible bu

Re: [jdk24] RFR: 8349183: [BACKOUT] Optimization for StringBuilder append boolean & null

2025-02-04 Thread Roger Riggs
On Mon, 3 Feb 2025 18:41:44 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of > https://github.com/openjdk/jdk/pull/23420 into jdk24? > > This proposes to bring in those same backouts into `jdk24` to prevent the > issue noted in that PR description. jdk24 is in rampdown

Re: RFR: 8349145: Make Class.getProtectionDomain() non-native [v4]

2025-02-04 Thread Coleen Phillimore
On Tue, 4 Feb 2025 14:06:07 GMT, Alan Bateman wrote: >> Thanks for looking at this. I didn't want to change this with this change. > > There may need to be some follow-on cleanup, e.g. I'm wondering if > Lookup.cachedProtectionDomain is needed now. One of the reasons I wanted to move this out

Re: RFR: 8346567: Make Class.getModifiers() non-native [v2]

2025-02-04 Thread Coleen Phillimore
On Tue, 4 Feb 2025 13:36:44 GMT, Alan Bateman wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix copyright and param name > > src/hotspot/share/oops/arrayKlass.hpp line 2: > >> 1: /* >> 2: * Copyright (c) 1

Re: RFR: 8346567: Make Class.getModifiers() non-native [v2]

2025-02-04 Thread Coleen Phillimore
On Tue, 4 Feb 2025 14:40:47 GMT, Coleen Phillimore wrote: >> The Class.getModifiers() method is implemented as a native method in >> java.lang.Class to access a field that we've calculated when creating the >> mirror. The field is final after that point. The VM doesn't need it >> anymore, so

Re: RFR: 8346567: Make Class.getModifiers() non-native [v2]

2025-02-04 Thread Coleen Phillimore
> The Class.getModifiers() method is implemented as a native method in > java.lang.Class to access a field that we've calculated when creating the > mirror. The field is final after that point. The VM doesn't need it anymore, > so there's no real need for the jdk code to call into the VM to get

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v4]

2025-02-04 Thread Volkan Yazici
On Tue, 4 Feb 2025 10:47:22 GMT, Daniel Fuchs wrote: >> Volkan Yazici has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Assert that multiple files can be served using the same >> `FileServerHandler` >> - Remove redundant `@build` depen

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v5]

2025-02-04 Thread Volkan Yazici
On Tue, 4 Feb 2025 14:15:00 GMT, Daniel Fuchs wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace `assert`s with conditionally thrown exceptions > > test/jdk/java/net/httpclient/http2/FixedThreadPoolTest.java

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v6]

2025-02-04 Thread Volkan Yazici
> Adds `test.lib.Utils::createTempFileOfSize` to generate > `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory > contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file > tracked by git: > > > $ git ls-files | while read f; do echo -e $(stat -c %s "$f

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v5]

2025-02-04 Thread Daniel Fuchs
On Tue, 4 Feb 2025 12:04:47 GMT, Volkan Yazici wrote: >> Adds `test.lib.Utils::createTempFileOfSize` to generate >> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory >> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file >> tracked by git: >> >>

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v4]

2025-02-04 Thread Shaojin Wen
On Tue, 4 Feb 2025 13:43:08 GMT, Shaojin Wen wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> skip coder change > > [hs_err_pid23348.log](https://github.com/user-attachments/files/18658266/hs_err_pid23348.log) >> ```

Integrated: 8349343: Add missing copyright messages in FFM benchmarks

2025-02-04 Thread Per Minborg
On Tue, 4 Feb 2025 09:40:02 GMT, Per Minborg wrote: > This PR proposes to add missing copyright headers to some FFM benchmarks. This pull request has now been integrated. Changeset: beb43e26 Author:Per Minborg URL: https://git.openjdk.org/jdk/commit/beb43e2633900bb9ab3c975376fe5860b

Re: RFR: 8349145: Make Class.getProtectionDomain() non-native [v4]

2025-02-04 Thread Alan Bateman
On Fri, 31 Jan 2025 17:16:11 GMT, Coleen Phillimore wrote: >> src/java.base/share/classes/java/lang/System.java line 2150: >> >>> 2148: } >>> 2149: >>> 2150: public ProtectionDomain protectionDomain(Class c) { >> >> This accessor has become pointless since the functinoa

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v5]

2025-02-04 Thread Shaojin Wen
On Tue, 4 Feb 2025 06:37:48 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 845: >> >>> 843: int spaceNeeded = count + DecimalDigits.stringSize(i); >>> 844: byte[] value = ensureCapacityInternal(spaceNeeded); >>> 845: if

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v5]

2025-02-04 Thread Shaojin Wen
> The following code can reproduce the problem, writing out of bounds causes > JVM Crash > > > StringBuilder buf = new StringBuilder(); > buf.append('中'); > > Thread[] threads = new Thread[40]; > final CountDownLatch latch = new CountDownLatch(threads.length); >

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v4]

2025-02-04 Thread Thomas Stuefe
On Tue, 4 Feb 2025 13:43:08 GMT, Shaojin Wen wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> skip coder change > >> ```java >> StringBuilder buf = new StringBuilder(); >> buf.append('中'); >> >> final Count

Re: RFR: 8346567: Make Class.getModifiers() non-native

2025-02-04 Thread Alan Bateman
On Mon, 9 Dec 2024 19:26:53 GMT, Coleen Phillimore wrote: > The Class.getModifiers() method is implemented as a native method in > java.lang.Class to access a field that we've calculated when creating the > mirror. The field is final after that point. The VM doesn't need it anymore, > so ther

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v4]

2025-02-04 Thread Shaojin Wen
On Tue, 4 Feb 2025 00:59:57 GMT, Shaojin Wen wrote: >> The following code can reproduce the problem, writing out of bounds causes >> JVM Crash >> >> >>StringBuilder buf = new StringBuilder(); >> buf.append('中'); >> >> final CountDownLatch latch = new CountDownLatch(10); >> Run

Re: RFR: 8349189: Speed up DateTime parse & format via Class File API [v11]

2025-02-04 Thread Shaojin Wen
> By using the Class File API to dynamically generate a CompositePrinterParser, > and defining DateTimePrinterParser[] printerParsers as a specific field, C2 > can do TypeProfile optimization. > > Since the CompositePrinterParser is generated based on the pattern, we can > make the following op

Re: RFR: 8346567: Make Class.getModifiers() non-native

2025-02-04 Thread Alan Bateman
On Mon, 9 Dec 2024 19:26:53 GMT, Coleen Phillimore wrote: > The Class.getModifiers() method is implemented as a native method in > java.lang.Class to access a field that we've calculated when creating the > mirror. The field is final after that point. The VM doesn't need it anymore, > so ther

Re: RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

2025-02-04 Thread Alan Bateman
On Tue, 4 Feb 2025 12:35:50 GMT, SendaoYan wrote: > Hi all, > > Several JMH tests fails "cannot access class > jdk.internal.vm.ContinuationScope (in module java.base) because module > java.base does not export jdk.internal.vm to unnamed module". This PR add VM > option `--add-exports=java.bas

RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

2025-02-04 Thread SendaoYan
Hi all, Several JMH tests fails "cannot access class jdk.internal.vm.ContinuationScope (in module java.base) because module java.base does not export jdk.internal.vm to unnamed module". This PR add VM option `--add-exports=java.base/jdk.internal.vm=ALL-UNNAMED` to fix the JMH test bug. Change

Re: RFR: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long) [v4]

2025-02-04 Thread Thomas Stuefe
On Tue, 4 Feb 2025 00:59:57 GMT, Shaojin Wen wrote: >> The following code can reproduce the problem, writing out of bounds causes >> JVM Crash >> >> >>StringBuilder buf = new StringBuilder(); >> buf.append('中'); >> >> final CountDownLatch latch = new CountDownLatch(10); >> Run

Re: [External] : Re: mapConcurrent() with InterruptedException

2025-02-04 Thread Viktor Klang
Hi, The problem is that mapConcurrent cannot throw InterruptedException because that is a checked exception, so we cannot clear the interrupted flag and throw that exception. So the updated semantics is to not cut the stream short but instead run to completion, restoring the interruption flag.

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v4]

2025-02-04 Thread Volkan Yazici
On Tue, 4 Feb 2025 10:46:33 GMT, Daniel Fuchs wrote: >> Volkan Yazici has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Assert that multiple files can be served using the same >> `FileServerHandler` >> - Remove redundant `@build` depen

Re: RFR: 8349343: Add missing copyright messages in FFM benchmarks

2025-02-04 Thread Jorn Vernee
On Tue, 4 Feb 2025 09:40:02 GMT, Per Minborg wrote: > This PR proposes to add missing copyright headers to some FFM benchmarks. Marked as reviewed by jvernee (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23433#pullrequestreview-2592637362

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v5]

2025-02-04 Thread Volkan Yazici
> Adds `test.lib.Utils::createTempFileOfSize` to generate > `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory > contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file > tracked by git: > > > $ git ls-files | while read f; do echo -e $(stat -c %s "$f

Integrated: 8349238: Some more FFM benchmarks are broken

2025-02-04 Thread Per Minborg
On Mon, 3 Feb 2025 18:29:35 GMT, Per Minborg wrote: > This PR proposes to fix an Unsafe issue in a benchmark. This pull request has now been integrated. Changeset: 81126c20 Author:Per Minborg URL: https://git.openjdk.org/jdk/commit/81126c20cbcab577d82e690d9cf1c1b738754a07 Stats:

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v4]

2025-02-04 Thread Daniel Fuchs
On Mon, 3 Feb 2025 19:26:03 GMT, Volkan Yazici wrote: >> Adds `test.lib.Utils::createTempFileOfSize` to generate >> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory >> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file >> tracked by git: >> >>

Re: RFR: 8349238: Some more FFM benchmarks are broken

2025-02-04 Thread Maurizio Cimadamore
On Mon, 3 Feb 2025 18:29:35 GMT, Per Minborg wrote: > This PR proposes to fix an Unsafe issue in a benchmark. Marked as reviewed by mcimadamore (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23424#pullrequestreview-2592423136

Re: RFR: 8347009: Speed ​​up parseInt and parseLong [v9]

2025-02-04 Thread Raffaello Giulietti
On Mon, 27 Jan 2025 20:07:29 GMT, Raffaello Giulietti wrote: > This line on a test is now failing because it's expecting a specific > `NumberFormatException` message. > > https://github.com/openjdk/jdk/blob/21feef32803b2593b097fb225c7a4c7cd46525da/test/jdk/com/sun/jdi/JdbExprTest.java#L114 >

Re: RFR: 8347009: Speed ​​up parseInt and parseLong [v13]

2025-02-04 Thread Raffaello Giulietti
On Sat, 1 Feb 2025 10:07:25 GMT, Shaojin Wen wrote: >> This is an optimization for decimal Integer.parseInt and Long.parseLong, >> which improves performance by about 10%. The optimization includes: >> 1. Improve performance by parsing 2 numbers at a time, which has performance >> improvements

Re: RFR: 8349107: Remove RMI finalizers [v2]

2025-02-04 Thread Daniel Jeliński
On Mon, 3 Feb 2025 19:13:10 GMT, Brent Christian wrote: >> 3 finalizers in RMI code can be removed, as they do not perform meaningful >> cleanup. >> >> **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`** >> >> `RegistryContext.finalize()` just calls `close()`. The `clo

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v16]

2025-02-04 Thread Jatin Bhateja
On Tue, 4 Feb 2025 09:03:09 GMT, Emanuel Peter wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update >> test/micro/org/openjdk/bench/jdk/incubator/vector/Float16OperationsBenchmark.java >> >> Co-authored-by

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v16]

2025-02-04 Thread Jatin Bhateja
On Mon, 3 Feb 2025 18:11:11 GMT, Jatin Bhateja wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update >> test/micro/org/openjdk/bench/jdk/incubator/vector/Float16OperationsBenchmark.java >> >> Co-authored-by

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v17]

2025-02-04 Thread Jatin Bhateja
> Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of various Float16 operations through inline expansion or > patt

RFR: 8349344: Clarify documentation of Arena.ofConfined

2025-02-04 Thread Per Minborg
This PR proposes to clarify the documentation for `Arena.ofConfined()`. It is proposed to say that segments allocated from the returned `Arena` can _only_ be accessed by the thread that created the `Arena` in the first place. - Commit messages: - Clarify docs for Arena.ofConfined()

RFR: 8349343: Add missing copyright messages in FFM benchmarks

2025-02-04 Thread Per Minborg
This PR proposes to add missing copyright headers to some FFM benchmarks. - Commit messages: - Add copyright headers Changes: https://git.openjdk.org/jdk/pull/23433/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23433&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8

Re: RFR: 8349107: Remove RMI finalizers [v2]

2025-02-04 Thread Viktor Klang
On Mon, 3 Feb 2025 19:13:10 GMT, Brent Christian wrote: >> 3 finalizers in RMI code can be removed, as they do not perform meaningful >> cleanup. >> >> **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`** >> >> `RegistryContext.finalize()` just calls `close()`. The `clo

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v16]

2025-02-04 Thread Emanuel Peter
On Thu, 30 Jan 2025 11:03:43 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection

Re: RFR: 8349189: Speed up DateTime parse & format via Class File API [v10]

2025-02-04 Thread Shaojin Wen
> By using the Class File API to dynamically generate a CompositePrinterParser, > and defining DateTimePrinterParser[] printerParsers as a specific field, C2 > can do TypeProfile optimization. > > Since the CompositePrinterParser is generated based on the pattern, we can > make the following op

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v16]

2025-02-04 Thread Emanuel Peter
On Thu, 30 Jan 2025 11:03:43 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v16]

2025-02-04 Thread Emanuel Peter
On Mon, 3 Feb 2025 18:11:11 GMT, Jatin Bhateja wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update >> test/micro/org/openjdk/bench/jdk/incubator/vector/Float16OperationsBenchmark.java >> >> Co-authored-by

Re: RFR: 8349189: Speed up DateTime parse & format via Class File API [v9]

2025-02-04 Thread Shaojin Wen
> By using the Class File API to dynamically generate a CompositePrinterParser, > and defining DateTimePrinterParser[] printerParsers as a specific field, C2 > can do TypeProfile optimization. > > Since the CompositePrinterParser is generated based on the pattern, we can > make the following op

Re: RFR: 8349189: Speed up DateTime parse & format via Class File API [v8]

2025-02-04 Thread Shaojin Wen
> By using the Class File API to dynamically generate a CompositePrinterParser, > and defining DateTimePrinterParser[] printerParsers as a specific field, C2 > can do TypeProfile optimization. > > Since the CompositePrinterParser is generated based on the pattern, we can > make the following op

Re: RFR: 8349189: Speed up DateTime parse & format via Class File API [v7]

2025-02-04 Thread Shaojin Wen
> By using the Class File API to dynamically generate a CompositePrinterParser, > and defining DateTimePrinterParser[] printerParsers as a specific field, C2 > can do TypeProfile optimization. > > Since the CompositePrinterParser is generated based on the pattern, we can > make the following op