On Tue, 4 Feb 2025 19:18:39 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing typos
>
> src/java.base/share/classes/jdk/internal/vm/vector/Float16Math.java line 42:
>
>> 40: }
>> 41:
>> 42: public interface Float16TernaryMathOp {
>
> Is there a reason we don't write the default impl explicitly in this class,
> but ask for a lambda for an implementation? Each intrinsified method only has
> one default impl, so I think we can just inline that into the method body
> here.
This wrapper class is part of java.base module and only contains intrinsic
entry points for APIs defined in Float16 class which is part of an incubation
module. Thus, exposing intrinsic fallback code through lambda keeps the
interface clean while actual API logic and comments around it remains intact in
Float16 class.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22754#discussion_r1942344948
