On Thu, 30 Jan 2025 19:27:30 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which improves the performance of cut-over date > checking when the user supplies a properties override via the > `java.util.currency.data` sys prop. Replacing the `SimpleDateFormat` with a > _java.time_ alternative has better performance. It should be noted that this > method is only entered when the string `s` is confirmed to adhere to the > format: `yyyy-MM-ddTHH:mm:ss`. > > An alternative is using `LocalDateTime.of(..)` and extracting the date/time > values ourselves from `s` with the known positions which is considerably > faster but not as concise. This pull request has now been integrated. Changeset: 250ff86d Author: Justin Lu <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/250ff86dc86f73dbf7c944d9b5a792c4bdfeef0d Stats: 14 lines in 1 file changed: 2 ins; 3 del; 9 mod 8349000: Performance improvement for Currency.isPastCutoverDate(String) Reviewed-by: naoto, aturbanov ------------- PR: https://git.openjdk.org/jdk/pull/23374
