On Thu, 9 Jan 2025 00:12:29 GMT, Leonid Mesnik wrote:
> Test
> runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
> uses
> -Xbootclasspath/a: classpath
> (2 arguments)
>
> Such usage of options -Xbootclasspath/a: should be correctly processed by
> virtual thread factory suppor
On Tue, 5 Nov 2024 16:16:13 GMT, Christian Stein wrote:
> Please review this change that improves the launcher mode detection by
> reading the initial two characters from the started file for being a shebang
> script. It addresses the reported confusing error messages and also supports
> more
On Thu, 9 Jan 2025 00:12:29 GMT, Leonid Mesnik wrote:
> Test
> runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
> uses
> -Xbootclasspath/a: classpath
> (2 arguments)
>
> Such usage of options -Xbootclasspath/a: should be correctly processed by
> virtual thread factory suppor
On Thu, 9 Jan 2025 00:12:29 GMT, Leonid Mesnik wrote:
> Test
> runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
> uses
> -Xbootclasspath/a: classpath
> (2 arguments)
>
> Such usage of options -Xbootclasspath/a: should be correctly processed by
> virtual thread factory suppor
On Wed, 8 Jan 2025 22:09:29 GMT, Alexey Semenyuk wrote:
> Clean backport to jdk24
This pull request has now been integrated.
Changeset: bf451280
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/bf45128055f6be8b99e862db54899aaa601ddce3
Stats: 25 lines in 1 file chan
On Wed, 8 Jan 2025 23:45:53 GMT, Alexey Semenyuk wrote:
> Look up different patterns in WiX output based on the version of the WiX.
@sashamatveev PTAL
-
PR Comment: https://git.openjdk.org/jdk/pull/22989#issuecomment-2579124566
On Thu, 9 Jan 2025 00:12:29 GMT, Leonid Mesnik wrote:
> Test
> runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
> uses
> -Xbootclasspath/a: classpath
> (2 arguments)
>
> Such usage of options -Xbootclasspath/a: should be correctly processed by
> virtual thread factory suppor
On Wed, 8 Jan 2025 23:35:10 GMT, Alexey Semenyuk wrote:
> Add missing `jdk.jpackage.test.Annotations.Test` annotations to test cases in
> `LicenseTest` test and update jtreg command line accordingly.
This pull request has now been integrated.
Changeset: 97dd06ce
Author:Alexey Semenyuk
URL
On Wed, 8 Jan 2025 23:35:10 GMT, Alexey Semenyuk wrote:
> Add missing `jdk.jpackage.test.Annotations.Test` annotations to test cases in
> `LicenseTest` test and update jtreg command line accordingly.
Test cases executed
On Windows & OSX:
- Create: LicenseTest.testCommon
On Linux:
- Create:
On Wed, 8 Jan 2025 14:56:55 GMT, Severin Gehwolf wrote:
>> Please review this trivial test-only patch in support of running tests on
>> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run
>> `jlink` in-process of the test JVM which includes module patches (as in -
>> use
On Wed, 8 Jan 2025 23:39:14 GMT, Alexey Semenyuk wrote:
> Minor change affecting jpackage tests execution with jpackage test runner
This pull request has now been integrated.
Changeset: 0a35ebfd
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/0a35ebfd5709c3069fd64bb73
On Wed, 8 Jan 2025 23:51:55 GMT, Alexey Semenyuk wrote:
> Make names of msi files created in test cases of WinInstallerUiTest test
> shorter to workaround limitations of msi.exe on file path length.
>
> Old msi file names:
> WinInstallerUiTestWithDirChooserLicense-1.0.msi
> WinInstallerUiTestWi
On Wed, 8 Jan 2025 15:23:23 GMT, Chen Liang wrote:
> Joe and David, can you look at this updated versioning that uses the core
> libraries since scheme?
Yep that looks fine. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/22934#issuecomment-2579111421
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström
wrote:
>> Could I get a review of this fix to refine the warnings printed by `libjsig`
>> when using the deprecated `signal()`/`sigset()` functions?
>>
>> Currently the libjsig library supports chaining `signal()` and `sigset()`.
>> With these
On Wed, 8 Jan 2025 11:00:14 GMT, Joakim Nordström
wrote:
>> The test is skipped for SIGUSR2 on Linux and MacOS, and Windows skips all
>> signal testing. So I guess that leaves aix, which seems to use
>> signals_poxis.cpp... so perhaps the SIGUSR2 test should be skipped for aix
>> too?
>> But
On Wed, 8 Jan 2025 23:39:14 GMT, Alexey Semenyuk wrote:
> Minor change affecting jpackage tests execution with jpackage test runner
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22988#pullrequestreview-2538567325
On Wed, 8 Jan 2025 23:51:55 GMT, Alexey Semenyuk wrote:
> Make names of msi files created in test cases of WinInstallerUiTest test
> shorter to workaround limitations of msi.exe on file path length.
>
> Old msi file names:
> WinInstallerUiTestWithDirChooserLicense-1.0.msi
> WinInstallerUiTestWi
On Wed, 8 Jan 2025 23:35:10 GMT, Alexey Semenyuk wrote:
> Add missing `jdk.jpackage.test.Annotations.Test` annotations to test cases in
> `LicenseTest` test and update jtreg command line accordingly.
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.
On Wed, 8 Jan 2025 23:29:49 GMT, Alexey Semenyuk wrote:
> `JPackageCommand.ignoreFakeRuntime()` method mistakenly tests if Java runtime
> configured for the current jpackage command is a valid Java runtime.
>
> It must test the runtime configured for jpackage tests with
> `jdk.jpackage.test.ru
Change the test as done in #22957 for
[JDK-8346671](https://bugs.openjdk.org/browse/JDK-8346671).
-
Commit messages:
- 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows
Server 2025
Changes: https://git.openjdk.org/jdk/pull/22994/files
Webrev: https://web
On Wed, 8 Jan 2025 23:29:22 GMT, Alexey Semenyuk wrote:
>> - Don't remove the `PATH` variable from the environment when running app
>> launchers in jpackage tests;
>> - Fix tests that use `Executor` rather than `HelloApp` class to run app
>> launchers: apply the same changes to the environment
Test
runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
uses
-Xbootclasspath/a: classpath
(2 arguments)
Such usage of options -Xbootclasspath/a: should be correctly processed by
virtual thread factory support in ProcessTools.
-
Commit messages:
- 8347304: Update P
Test
test/jdk/tools/jimage/JImageToolTest.java
ignore vm flags and should be marked as flagless.
It is needed to don't try to run this test with virtual test thread factory.
-
Commit messages:
- 8347302
Changes: https://git.openjdk.org/jdk/pull/22992/files
Webrev: https://webrevs
On Wed, 8 Jan 2025 23:51:55 GMT, Alexey Semenyuk wrote:
> Make names of msi files created in test cases of WinInstallerUiTest test
> shorter to workaround limitations of msi.exe on file path length.
>
> Old msi file names:
> WinInstallerUiTestWithDirChooserLicense-1.0.msi
> WinInstallerUiTestWi
Make names of msi files created in test cases of WinInstallerUiTest test
shorter to workaround limitations of msi.exe on file path length.
Old msi file names:
WinInstallerUiTestWithDirChooserLicense-1.0.msi
WinInstallerUiTestWithDirChooserShortcutPrompt-1.0.msi
WinInstallerUiTestWithDirChooserSho
Look up different patterns in WiX output based on the version of the WiX.
-
Commit messages:
- Update copyright year
- Fix WinResourceTest to make it work with WiX v4.0+
Changes: https://git.openjdk.org/jdk/pull/22989/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22989&r
On Wed, 8 Jan 2025 23:45:53 GMT, Alexey Semenyuk wrote:
> Look up different patterns in WiX output based on the version of the WiX.
@sashamatveev PTAL
-
PR Comment: https://git.openjdk.org/jdk/pull/22989#issuecomment-2578892515
On Wed, 8 Jan 2025 23:29:49 GMT, Alexey Semenyuk wrote:
> `JPackageCommand.ignoreFakeRuntime()` method mistakenly tests if Java runtime
> configured for the current jpackage command is a valid Java runtime.
>
> It must test the runtime configured for jpackage tests with
> `jdk.jpackage.test.ru
On Wed, 8 Jan 2025 23:39:14 GMT, Alexey Semenyuk wrote:
> Minor change affecting jpackage tests execution with jpackage test runner
@sashamatveev PTAL
-
PR Comment: https://git.openjdk.org/jdk/pull/22988#issuecomment-2578887581
Minor change affecting jpackage tests execution with jpackage test runner
-
Commit messages:
- Update copyright year
- Skip the RuntimeImageSymbolicLinksTest test on Windows when it is executed
outside of jtreg. This is shared test and applies to multiple platforms but
Windows.
C
Add missing `jdk.jpackage.test.Annotations.Test` annotations to test cases in
`LicenseTest` test and update jtreg command line accordingly.
-
Commit messages:
- Copyright year updated
- Add annotations to test cases in LicenseTest
Changes: https://git.openjdk.org/jdk/pull/22987/fi
`JPackageCommand.ignoreFakeRuntime()` method mistakenly tests if Java runtime
configured for the current jpackage command is a valid Java runtime.
It must test the runtime configured for jpackage tests with
`jdk.jpackage.test.runtime-image` system property instead.
-
Commit message
On Wed, 8 Jan 2025 22:29:04 GMT, Alexey Semenyuk wrote:
> - Don't remove the `PATH` variable from the environment when running app
> launchers in jpackage tests;
> - Fix tests that use `Executor` rather than `HelloApp` class to run app
> launchers: apply the same changes to the environment as w
> - Don't remove the `PATH` variable from the environment when running app
> launchers in jpackage tests;
> - Fix tests that use `Executor` rather than `HelloApp` class to run app
> launchers: apply the same changes to the environment as would be applied by
> `HelloApp` class.
> - Replace `Execu
On Thu, 2 Jan 2025 18:43:35 GMT, Henry Jen wrote:
>> I would expect the next token would be parsed as the value. I suggest to
>> explore that and see how complex it would be.
>>
>> It seems awkward if the following are accepted:
>>
>> --add-options "--add-modules jdk.incubator.concurrent"
>>
- Don't remove the `PATH` variable from the environment when running app
launchers in jpackage tests;
- Replace `Executor.setRemovePathEnvVar()` with `Executor.removeEnvVar()` to
support removal of any variable from the environment of a child process
executed in jpackage tests;
- Add support of
On Wed, 8 Jan 2025 22:09:29 GMT, Alexey Semenyuk wrote:
> Clean backport to jdk24
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22982#pullrequestreview-2538406774
On Wed, 8 Jan 2025 06:52:10 GMT, Adam Sotona wrote:
> BTW: purpose of this PR is to seamlessly remove ASM from java.base and it is
> slightly turning into a massive synchronous refactoring of several hundreds
> of hotspot tests.
Moving the ASM library requires modifying every single test that
Clean backport to jdk24
-
Commit messages:
- Backport 4d18e5a1e26e04beb550d01ba5a3dbb8c0c37fa0
Changes: https://git.openjdk.org/jdk/pull/22982/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22982&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8346872
Stats: 25 lin
On Wed, 8 Jan 2025 22:09:29 GMT, Alexey Semenyuk wrote:
> Clean backport to jdk24
@sashamatveev PTAL
-
PR Comment: https://git.openjdk.org/jdk/pull/22982#issuecomment-2578773249
On Fri, 3 Jan 2025 16:55:24 GMT, Henry Jen wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the class
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
Please review a doc-only change to mostly add missing `@serial` javadoc tags.
This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc
`-serialwarn` option in the JDK doc build, which has been disabled since JDK 19.
[JDK-8286931]: https://bugs.openjdk.org/browse/JDK-8286931
For
On Tue, 29 Oct 2024 20:23:32 GMT, Severin Gehwolf wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix regression failed to setup helper methods properly
>
> Typo
> @jerboaa , @liach Thanks for reviewing, is there any
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote:
> Clean backport of a test follow-up for #22849 targeting JDK 24. Please
> review! Thanks in advance.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/22972#issuecomment-2578544126
On Wed, 8 Jan 2025 19:41:42 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to add missing `@serial` javadoc tags in
> module `java.base`. This is a sub-task of [JDK-8286931] to allow us to
> re-enable the javadoc `-serialwarn` option in the JDK doc build, which has
> been disab
Please review a doc-only change to add missing `@serial` javadoc tags in module
`java.base`. This is a sub-task of [JDK-8286931] to allow us to re-enable the
javadoc `-serialwarn` option in the JDK doc build, which has been disabled
since JDK 19.
[JDK-8286931]: https://bugs.openjdk.org/browse/J
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote:
> Clean backport of a test follow-up for #22849 targeting JDK 24. Please
> review! Thanks in advance.
LGTM
-
Marked as reviewed by asemenyuk (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22972#pullrequestreview-253
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Wed, 8 Jan 2025 05:51:12 GMT, Chen Liang wrote:
>> `javax.lang.model.SourceVersion` has a series of comments describing the new
>> language features present in each source version. Similar comments for the
>> `ClassFileFormatVersion` would be helpful, so readers no longer need to
>> search
On Sun, 22 Sep 2024 15:38:19 GMT, Alan Bateman wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the cl
On Mon, 9 Dec 2024 22:18:30 GMT, Joe Darcy wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Remove more unnecessary suppressions.
>> - Merge branch 'master' into SuppressWarningsCleanup-
On Fri, 20 Dec 2024 13:25:43 GMT, Severin Gehwolf wrote:
> Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259)
> to JDK 24 which has JEP 493.
Marked as reviewed by mchung (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22849#pullrequestreview-253
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote:
> Clean backport of a test follow-up for #22849 targeting JDK 24. Please
> review! Thanks in advance.
Marked as reviewed by mchung (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22972#pullrequestreview-2537763599
On Tue, 7 Jan 2025 18:27:31 GMT, Naoto Sato wrote:
> Long overdue cleanup, especially the old `javazic` tool, which has been
> maintenance burden for some time.
This pull request has now been integrated.
Changeset: 49ee4df3
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/
On Tue, 7 Jan 2025 18:27:31 GMT, Naoto Sato wrote:
> Long overdue cleanup, especially the old `javazic` tool, which has been
> maintenance burden for some time.
Thank you for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/22955#issuecomment-2578145519
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
On Tue, 10 Dec 2024 23:45:37 GMT, Volodymyr Paprotski
wrote:
> @TobiHartmann There are still some unanswered questions I have, but
> committing this since we need to work around vacation schedules.
>
> **This in fact happens on both Windows _AND_ Linux.** However, _only_ on
> Windows there i
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote:
> Clean backport of a test follow-up for #22849 targeting JDK 24. Please
> review! Thanks in advance.
@alexeysemenyukoracle Could you please help review this for JDK 24? The change
needing this is about to go into JDK 24 as well in #22849
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
Please review this change that improves the launcher mode detection by reading
the initial two characters from the started shebang script. It addresses the
reported confusing error messages and also supports more shebang line
variations. Including those line variations that omit the `--source` a
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote:
> Clean backport of a test follow-up for #22849 targeting JDK 24. Please
> review! Thanks in advance.
Backport looks fine.
-
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22972#pullreque
On Fri, 20 Dec 2024 13:25:43 GMT, Severin Gehwolf wrote:
> Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259)
> to JDK 24 which has JEP 493.
Thanks for the review. I'll wait until #22972 is reviewed and ready as well so
as to make the window with test failures as smal
On Wed, 8 Jan 2025 05:51:12 GMT, Chen Liang wrote:
>> `javax.lang.model.SourceVersion` has a series of comments describing the new
>> language features present in each source version. Similar comments for the
>> `ClassFileFormatVersion` would be helpful, so readers no longer need to
>> search
On Fri, 20 Dec 2024 13:25:43 GMT, Severin Gehwolf wrote:
> Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259)
> to JDK 24 which has JEP 493.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22849#pullrequestreview-2537
On Wed, 8 Jan 2025 14:56:55 GMT, Severin Gehwolf wrote:
>> Please review this trivial test-only patch in support of running tests on
>> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run
>> `jlink` in-process of the test JVM which includes module patches (as in -
>> use
Clean backport of a test follow-up for #22849 targeting JDK 24. Please review!
Thanks in advance.
-
Commit messages:
- Backport 7ba969a576eb92446e40587fecf98e1e4aba8883
Changes: https://git.openjdk.org/jdk/pull/22972/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22972&ra
On Fri, 20 Dec 2024 18:04:15 GMT, Alan Bateman wrote:
>> Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259)
>> to JDK 24 which has JEP 493.
>
> Hold off on integrating this into jdk24 until some issues with jpackage tests
> are figured out, I think we have some failure
On Wed, 8 Jan 2025 14:42:45 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright and @comment
>
> test/jdk/tools/launcher/SourceMode.java line 29:
>
>> 27: * @summary Test source mode
>>
> Please review this trivial test-only patch in support of running tests on JEP
> 493 enabled builds. Both tests use the `ToolProvider` API so as to run
> `jlink` in-process of the test JVM which includes module patches (as in -
> uses `--patch-module`) which is not supported for JEP 493 enabled
On Mon, 30 Dec 2024 21:25:20 GMT, Alexey Semenyuk wrote:
> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the
> test's work directory doesn't support DOS file names.
This pull request has now been integrated.
Changeset: 4d18e5a1
Author:Alexey Semenyuk
URL:
h
On Fri, 3 Jan 2025 21:33:17 GMT, Alexey Semenyuk wrote:
>> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the
>> test's work directory doesn't support DOS file names.
>
> Alexey Semenyuk has updated the pull request with a new target base due to a
> merge or a rebase. Th
On Wed, 8 Jan 2025 14:24:25 GMT, Severin Gehwolf wrote:
> Please review this trivial test-only patch in support of running tests on JEP
> 493 enabled builds. Both tests use the `ToolProvider` API so as to run
> `jlink` in-process of the test JVM which includes module patches (as in -
> uses `-
Please review this trivial test-only patch in support of running tests on JEP
493 enabled builds. Both tests use the `ToolProvider` API so as to run `jlink`
in-process of the test JVM which includes module patches (as in - uses
`--patch-module`) which is not supported for JEP 493 enabled JDKs. T
On Mon, 16 Dec 2024 14:19:49 GMT, Jatin Bhateja wrote:
>>> > Can you quickly summarize what tests you have, and what they test?
>>>
>>> Patch includes functional and performance tests, as per your suggestions IR
>>> framework-based tests now cover various special cases for constant folding
>>>
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT` notion from `jpackage` which includes all modules that exp
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
> Could I get a review of this fix to refine the warnings printed by `libjsig`
> when using the deprecated `signal()`/`sigset()` functions?
>
> Currently the libjsig library supports chaining `signal()` and `sigset()`.
> With these functions being deprecated, `libjsig` warns when a program calls
On Tue, 7 Jan 2025 14:26:13 GMT, Joakim Nordström
wrote:
>> test/hotspot/jtreg/runtime/signal/SigTestDriver.java line 176:
>>
>>> 174: /**
>>> 175: * Return true for all signals used by the JVM. This only covers
>>> the
>>> 176: * case where the JVM is started normally, and not w
On Wed, 8 Jan 2025 06:02:38 GMT, Chen Liang wrote:
> The anchor is `refkinds` instead of `refKinds`.
This pull request has now been integrated.
Changeset: afe54341
Author:Chen Liang
Committer: Jaikiran Pai
URL:
https://git.openjdk.org/jdk/commit/afe543414f58a04832d4f07dea1d6495
On Wed, 8 Jan 2025 06:02:38 GMT, Chen Liang wrote:
> The anchor is `refkinds` instead of `refKinds`.
tier testing of this change in the CI completed without any failures. I'll go
ahead and integrate this now to reduce additional sighting of this failure.
-
PR Comment: https://git.
On Wed, 8 Jan 2025 09:02:57 GMT, Per Minborg wrote:
> > copyrights should say 2025
>
> I believe all the changes were made and committed in 2024. So, shouldn't the
> copyright year be 2024 then?
I've typically used the year of when things are integrated. It's a bit of a
gray area and I'm not
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Wed, 8 Jan 2025 08:57:33 GMT, Per Minborg wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b0c935c0](https://github.com/openjdk/jdk/commit/b0c935c03ebb34f20f15dd8c7616c6c4526073cd)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 8 Jan 2025 08:57:33 GMT, Per Minborg wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b0c935c0](https://github.com/openjdk/jdk/commit/b0c935c03ebb34f20f15dd8c7616c6c4526073cd)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 8 Jan 2025 06:02:38 GMT, Chen Liang wrote:
> The anchor is `refkinds` instead of `refKinds`.
Marked as reviewed by shade (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22961#pullrequestreview-2536699804
On Wed, 8 Jan 2025 08:57:33 GMT, Per Minborg wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b0c935c0](https://github.com/openjdk/jdk/commit/b0c935c03ebb34f20f15dd8c7616c6c4526073cd)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Fri, 3 Jan 2025 21:33:17 GMT, Alexey Semenyuk wrote:
>> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the
>> test's work directory doesn't support DOS file names.
>
> Alexey Semenyuk has updated the pull request with a new target base due to a
> merge or a rebase. Th
On Thu, 19 Dec 2024 14:00:53 GMT, Alan Bateman wrote:
>> Both alternatives were present and I picked the most prevailing one in the
>> package. Also, this is what you get when you auto format in IntelliJ. But if
>> there is a preference for the other way, we could switch. No problem.
>
> I don'
On Tue, 7 Jan 2025 15:38:51 GMT, Maurizio Cimadamore
wrote:
> Do we have a sense on how easy would it be, moving forward, to preserve the
> "correct" order of imports? E.g. if I add a new one using IntelliJ
> autocompletion, where would it end up? Has this patch been generated using
> the IDE
On Tue, 7 Jan 2025 15:37:41 GMT, Maurizio Cimadamore
wrote:
> copyrights should say 2025
I believe all the changes were made and committed in 2024. So, shouldn't the
copyright year be 2024 then?
-
PR Comment: https://git.openjdk.org/jdk/pull/22827#issuecomment-2577140833
Hi all,
This pull request contains a backport of commit
[b0c935c0](https://github.com/openjdk/jdk/commit/b0c935c03ebb34f20f15dd8c7616c6c4526073cd)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Per Minborg on 8 Jan 2025 and was
revie
On Tue, 7 Jan 2025 19:38:23 GMT, Brent Christian wrote:
>> This PR proposes to eliminate the capturing of `this` in the cleanup action
>> of `AbstractMemorySegment::reinterpretInternal`.
>
> As a matter of style, I believe there is something to be said for writing out
> cleaning actions as stat
On Tue, 7 Jan 2025 10:44:22 GMT, Per Minborg wrote:
> This PR proposes to eliminate the capturing of `this` in the cleanup action
> of `AbstractMemorySegment::reinterpretInternal`.
This pull request has now been integrated.
Changeset: b0c935c0
Author:Per Minborg
URL:
https://git.op
On Tue, 7 Jan 2025 11:35:54 GMT, Maurizio Cimadamore
wrote:
> Please test this extensively. There is a non-zero chance that some tests
> (esp. in later tiers) might be relying on the current (bogus) behavior. So it
> might be possible for this fix to uncover more use-after-free issues.
Passes
On 07/01/2025 15:18, robert engels wrote:
Hi,
I would like to revisit this. I have signed the OCA for another PR I worked on
- I believe it covers all of my contributions.
The websockets license looks to be very permissive. But it seems like this is
something Oracle could reach out to the aut
99 matches
Mail list logo
