On Tue, 29 Oct 2024 20:23:32 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

>> Henry Jen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix regression failed to setup helper methods properly
>
> Typo

> @jerboaa , @liach Thanks for reviewing, is there anything else you would like 
> to add?

Good from my point of view. The only comment I have is to check the warning in 
https://github.com/openjdk/jdk/pull/21022#issue-2529094545 and possibly change 
the fix version to JDK 25 before integrating.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21022#issuecomment-2578555335

Reply via email to