Re: RFR: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history [v2]

2025-01-06 Thread Joe Darcy
On Tue, 7 Jan 2025 04:30:50 GMT, David Holmes wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add JEP/JSR numbers, clarify if something is attribute/modifier/etc. > > src/java.base/share/classes/java/lang/reflect/Cla

Re: RFR: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history [v2]

2025-01-06 Thread David Holmes
On Mon, 6 Jan 2025 21:20:58 GMT, Chen Liang wrote: >> `javax.lang.model.SourceVersion` has a series of comments describing the new >> language features present in each source version. Similar comments for the >> `ClassFileFormatVersion` would be helpful, so readers no longer need to >> search

Re: RFR: 8342468: Improve API documentation for java.lang.classfile.constantpool [v3]

2025-01-06 Thread Chen Liang
On Mon, 6 Jan 2025 21:41:17 GMT, Chen Liang wrote: >> Improve documentation for constant pool entries. This include some models >> for those entries, symbolic descriptors, and some general guidance in >> package summary. >> >> APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/ >> Javad

Re: RFR: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history [v2]

2025-01-06 Thread Iris Clark
On Mon, 6 Jan 2025 21:20:58 GMT, Chen Liang wrote: >> `javax.lang.model.SourceVersion` has a series of comments describing the new >> language features present in each source version. Similar comments for the >> `ClassFileFormatVersion` would be helpful, so readers no longer need to >> search

Re: RFR: 8342468: Improve API documentation for java.lang.classfile.constantpool [v3]

2025-01-06 Thread Chen Liang
> Improve documentation for constant pool entries. This include some models > for those entries, symbolic descriptors, and some general guidance in package > summary. > > APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/ > Javadoc: https://cr.openjdk.org/~liach/javadoc/cf-consts/ > > P

Re: RFR: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history [v2]

2025-01-06 Thread Chen Liang
On Mon, 6 Jan 2025 21:20:58 GMT, Chen Liang wrote: >> `javax.lang.model.SourceVersion` has a series of comments describing the new >> language features present in each source version. Similar comments for the >> `ClassFileFormatVersion` would be helpful, so readers no longer need to >> search

Re: RFR: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history [v2]

2025-01-06 Thread Chen Liang
> `javax.lang.model.SourceVersion` has a series of comments describing the new > language features present in each source version. Similar comments for the > `ClassFileFormatVersion` would be helpful, so readers no longer need to > search through the JVMS to find changes in new versions. Chen L

Withdrawn: 8334048: -Xbootclasspath can not read some ZIP64 zip files

2025-01-06 Thread duke
On Wed, 12 Jun 2024 14:02:58 GMT, Thomas Fitzsimmons wrote: > 8334048: -Xbootclasspath can not read some ZIP64 zip files This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/19678

Re: RFR: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history

2025-01-06 Thread Iris Clark
On Mon, 6 Jan 2025 18:26:54 GMT, Chen Liang wrote: > `javax.lang.model.SourceVersion` has a series of comments describing the new > language features present in each source version. Similar comments for the > `ClassFileFormatVersion` would be helpful, so readers no longer need to > search thro

Re: RFR: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history

2025-01-06 Thread Joe Darcy
On Mon, 6 Jan 2025 18:26:54 GMT, Chen Liang wrote: > `javax.lang.model.SourceVersion` has a series of comments describing the new > language features present in each source version. Similar comments for the > `ClassFileFormatVersion` would be helpful, so readers no longer need to > search thro

Re: RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError

2025-01-06 Thread Paul Sandoz
On Mon, 6 Jan 2025 09:12:01 GMT, SendaoYan wrote: > Hi all, > This PR add JVM option `jvmArgs={"--add-modules=jdk.incubator.vector"}` for > test/micro/org/openjdk/bench/jdk/incubator/vector/SpiltReplicate.java, to fix > test bug which cause jmh test fails 'java.lang.NoClassDefFoundError: > j

RFR: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history

2025-01-06 Thread Chen Liang
`javax.lang.model.SourceVersion` has a series of comments describing the new language features present in each source version. Similar comments for the `ClassFileFormatVersion` would be helpful, so readers no longer need to search through the JVMS to find changes in new versions. -

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2025-01-06 Thread Brian Burkhalter
On Tue, 24 Dec 2024 11:46:44 GMT, Taizo Kurashige wrote: > After applying the patch you provided, I confirmed that the test using the > mounted ISO file passes. I'm sorry I haven't been able to see the results of > the physical CD drive test myself, but I think I'll commit this patch. Thank >

Integrated: 8345668: ZoneOffset.ofTotalSeconds performance regression

2025-01-06 Thread Naoto Sato
On Fri, 20 Dec 2024 19:55:06 GMT, Naoto Sato wrote: > The change made in [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) > seems innocuous, but it caused this performance regression. Partially > reverting the change (ones that involve `computeIfAbsent()`) to the original. > Provided

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v4]

2025-01-06 Thread Naoto Sato
On Thu, 2 Jan 2025 18:11:53 GMT, Naoto Sato wrote: >> The change made in >> [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) seems innocuous, >> but it caused this performance regression. Partially reverting the change >> (ones that involve `computeIfAbsent()`) to the original. Provi

Re: RFR: 8346468: SM cleanup of common test library [v3]

2025-01-06 Thread Roger Riggs
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote: >> SM Cleanup of common test library test/lib/...: >> >> Remove unnecessary catches of SecurityException >> Remove AccessController and doPrivileged from SimpleSSLContext and >> ProcessTools. > > Roger Riggs has updated the pull request incre

Integrated: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks

2025-01-06 Thread Adam Sotona
On Fri, 3 Jan 2025 12:46:27 GMT, Adam Sotona wrote: > ASM-based benchmarks were useful to directly compare performance of ASM and > Class-File API. > However Class-File API performance history is now continuously tracked and > direct comparison to ASM becomes obsolete. > > This patch removes A

Re: RFR: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks [v2]

2025-01-06 Thread Chen Liang
On Mon, 6 Jan 2025 08:51:49 GMT, Adam Sotona wrote: >> ASM-based benchmarks were useful to directly compare performance of ASM and >> Class-File API. >> However Class-File API performance history is now continuously tracked and >> direct comparison to ASM becomes obsolete. >> >> This patch rem

Re: RFR: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks [v2]

2025-01-06 Thread Adam Sotona
On Mon, 6 Jan 2025 08:51:49 GMT, Adam Sotona wrote: >> ASM-based benchmarks were useful to directly compare performance of ASM and >> Class-File API. >> However Class-File API performance history is now continuously tracked and >> direct comparison to ASM becomes obsolete. >> >> This patch rem

Re: RFR: 8346983: Remove ASM-based transforms from Class-File API tests [v2]

2025-01-06 Thread Chen Liang
On Mon, 6 Jan 2025 08:56:09 GMT, Adam Sotona wrote: >> This patch removes obsolete ASM-based transformations from Class-File API >> tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8346983: Remove ASM-based transforms from Class-File API tests [v2]

2025-01-06 Thread Adam Sotona
On Mon, 6 Jan 2025 08:56:09 GMT, Adam Sotona wrote: >> This patch removes obsolete ASM-based transformations from Class-File API >> tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision

Integrated: 8346983: Remove ASM-based transforms from Class-File API tests

2025-01-06 Thread Adam Sotona
On Fri, 3 Jan 2025 12:19:54 GMT, Adam Sotona wrote: > This patch removes obsolete ASM-based transformations from Class-File API > tests. > > Please review. > > Thanks, > Adam This pull request has now been integrated. Changeset: c027f2ed Author:Adam Sotona URL: https://git.openjd

Integrated: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages

2025-01-06 Thread Adam Sotona
On Fri, 3 Jan 2025 12:06:05 GMT, Adam Sotona wrote: > This PR removes obsolete java.base exports of jdk.internal.objectweb.asm > packages to jdk.jfr module. > > Please review. > > Thanks, > Adam This pull request has now been integrated. Changeset: e0695e0e Author:Adam Sotona URL:

Re: RFR: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages [v2]

2025-01-06 Thread Adam Sotona
On Mon, 6 Jan 2025 08:45:48 GMT, Adam Sotona wrote: >> This PR removes obsolete java.base exports of jdk.internal.objectweb.asm >> packages to jdk.jfr module. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages [v2]

2025-01-06 Thread Chen Liang
On Mon, 6 Jan 2025 08:45:48 GMT, Adam Sotona wrote: >> This PR removes obsolete java.base exports of jdk.internal.objectweb.asm >> packages to jdk.jfr module. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit sin

[jdk24] Integrated: 8346069: Add missing Classpath exception statements

2025-01-06 Thread Sorna Sarathi N
On Tue, 17 Dec 2024 08:04:25 GMT, Sorna Sarathi N wrote: > Hi all, > > This pull request contains a backport of > [openjdk/jdk#22704](https://github.com/openjdk/jdk/pull/22704.) > > The commit being backported was authored by Sorna Sarathi on 13 Dec 2024 and > was reviewed by Amit Kumar, Alex

Re: [jdk24] RFR: 8346069: Add missing Classpath exception statements

2025-01-06 Thread Amit Kumar
On Tue, 17 Dec 2024 08:04:25 GMT, Sorna Sarathi N wrote: > Hi all, > > This pull request contains a backport of > [openjdk/jdk#22704](https://github.com/openjdk/jdk/pull/22704.) > > The commit being backported was authored by Sorna Sarathi on 13 Dec 2024 and > was reviewed by Amit Kumar, Alex

RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError

2025-01-06 Thread SendaoYan
Hi all, This PR add JVM option `jvmArgs={"--add-modules=jdk.incubator.vector"}` for test/micro/org/openjdk/bench/jdk/incubator/vector/SpiltReplicate.java, to fix test bug which cause jmh test fails 'java.lang.NoClassDefFoundError: jdk/incubator/vector/FloatVector'. Change has been verified loc

Re: RFR: 8346983: Remove ASM-based transforms from Class-File API tests [v2]

2025-01-06 Thread Adam Sotona
> This patch removes obsolete ASM-based transformations from Class-File API > tests. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: updated copyright year - Changes: - all: http

Re: RFR: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks [v2]

2025-01-06 Thread Adam Sotona
> ASM-based benchmarks were useful to directly compare performance of ASM and > Class-File API. > However Class-File API performance history is now continuously tracked and > direct comparison to ASM becomes obsolete. > > This patch removes ASM-based benchmarks from > test/micro/org/openjdk/ben

Re: RFR: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages [v2]

2025-01-06 Thread Alan Bateman
On Mon, 6 Jan 2025 08:45:48 GMT, Adam Sotona wrote: >> This PR removes obsolete java.base exports of jdk.internal.objectweb.asm >> packages to jdk.jfr module. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages [v2]

2025-01-06 Thread Adam Sotona
> This PR removes obsolete java.base exports of jdk.internal.objectweb.asm > packages to jdk.jfr module. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: updated copyright year - Ch