On Thu, 2 Jan 2025 18:11:53 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> The change made in >> [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) seems innocuous, >> but it caused this performance regression. Partially reverting the change >> (ones that involve `computeIfAbsent()`) to the original. Provided a >> benchmark that iterates the call to `ZoneOffset.ofTotalSeconds(0)` 1,000 >> times, which improves the operation time from 3,946ns to 2,241ns. > > Naoto Sato has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains five additional commits since > the last revision: > > - Addresses review comments > - Merge branch 'master' into JDK-8345668-ofTotalSeconds-perf-regression > - Fixed compile error > - Update src/java.base/share/classes/java/time/ZoneOffset.java > > Co-authored-by: Roger Riggs <roger.ri...@oracle.com> > - initial commit Thank you for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk/pull/22854#issuecomment-2573530009
