On Fri, 29 Nov 2024 22:20:50 GMT, Luca Kellermann wrote:
>> Don't think so. This imo is fixable in the future if we do have many new
>> cp/annotation tags (see example of Thread::threadId), though I don't think
>> that is likely
>
> Wait, I referenced the wrong thing. I was speaking about this
On Wed, 27 Nov 2024 11:07:18 GMT, Severin Gehwolf wrote:
> Right. I'm still not convinced this extra reduction buys us much. The adjust
> controller logic will handle it if kept as is in the Metrics version.
The adjust controller logic won't handle it, because it reduces the path from
child to
On Wed, 27 Nov 2024 09:11:22 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Fri, 29 Nov 2024 14:47:13 GMT, Sergey Chernyshev
wrote:
> > Right. I'm still not convinced this extra reduction buys us much. The
> > adjust controller logic will handle it if kept as is in the Metrics version.
>
> The adjust controller logic won't handle it, because it reduces the path fro
On Wed, 27 Nov 2024 10:56:57 GMT, Sergey Chernyshev
wrote:
>>> Version specific code can be had in `set_subsystem_path()` of the
>>> corresponding impl (like an earlier version of your patch). `lowest_limit`
>>> and `limit_cg_path` fixes are version agnostic and can and should be fixed
>>> in
On Wed, 27 Nov 2024 10:18:24 GMT, Severin Gehwolf wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust path suffix in cgroup (v1) version specific code, when root !=
>> cgroup
>
> src/hotspot/os/linux/cgrou
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Fri, 29 Nov 2024 18:59:41 GMT, Chen Liang wrote:
>>> Yet I think we can consider promoting Constant Pool tag from byte or char,
>>> short, or int to represent a u1 in case it goes over 127.
>>
>> Is there any chance a change like this could make it into JDK 24? I'd
>> imagine it would be to
On Mon, 25 Nov 2024 17:19:41 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which adds a utility API in the test libraries to
>> assert whether a file is currently open.
>>
>> Several OpenJDK tests currently rely on approximations to check this,
>> including deletion (fails only on Wind
On Mon, 4 Nov 2024 19:46:07 GMT, Xue-Lei Andrew Fan wrote:
>> Martin Balao has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains eight commits:
>>
>> - Remove -Xdebug from commented-out debug command
>>
>>This is unnecessary, s
On Fri, 29 Nov 2024 17:53:43 GMT, Luca Kellermann wrote:
>>> Your example is an exact antipattern from our data-oriented model: we would
>>> want users to check the object type with `instanceof` (should be `is` in
>>> kotlin) instead of checking these constants.
>>
>> I'm aware, this was just
On Fri, 29 Nov 2024 12:20:02 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Tools area modules. The test is described in this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
>> Th
> Can I please get a review for this PR that add tests to verify the value of
> `@since` tags to the Tools area modules. The test is described in this
> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
> This issue is similar to JDK-8341399, JDK-8331051 and JDK-83434
On Fri, 29 Nov 2024 17:05:45 GMT, Magnus Ihse Bursie wrote:
> Shouldn't we try to promote GNU-style long options? (That is, suggest
> `--version` instead of `-version`.)
I was thinking of that, but shied away from it, because: the current `java`
output prints to stderr; this new concise `java`
On Fri, 29 Nov 2024 09:46:55 GMT, Per Minborg wrote:
>> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods,
>> fixing a bug in the `short_strlen` variant for odd offsets (`offset % 2 !=
>> 0`).
>>
>> This PR also improves performance on modern hardware, as there is no nee
On Fri, 15 Nov 2024 11:53:00 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
On Mon, 7 Oct 2024 17:37:40 GMT, Luca Kellermann wrote:
> Yet I think we can consider promoting Constant Pool tag from byte or char,
> short, or int to represent a u1 in case it goes over 127.
Is there any chance a change like this could make it into JDK 24? I'd imagine
it would be too late af
On Fri, 15 Nov 2024 11:53:00 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
On Fri, 29 Nov 2024 07:25:23 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Fri, 29 Nov 2024 07:25:23 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
On Fri, 29 Nov 2024 12:20:02 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Tools area modules. The test is described in this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
>> Th
On Fri, 29 Nov 2024 12:36:19 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix imports
>
> src/java.base/share/classes/jdk/internal/foreign/StringSupport.java line 187:
>
>> 185:
On Fri, 29 Nov 2024 09:46:55 GMT, Per Minborg wrote:
>> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods,
>> fixing a bug in the `short_strlen` variant for odd offsets (`offset % 2 !=
>> 0`).
>>
>> This PR also improves performance on modern hardware, as there is no nee
On Fri, 29 Nov 2024 09:46:55 GMT, Per Minborg wrote:
>> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods,
>> fixing a bug in the `short_strlen` variant for odd offsets (`offset % 2 !=
>> 0`).
>>
>> This PR also improves performance on modern hardware, as there is no nee
On Fri, 29 Nov 2024 09:46:55 GMT, Per Minborg wrote:
>> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods,
>> fixing a bug in the `short_strlen` variant for odd offsets (`offset % 2 !=
>> 0`).
>>
>> This PR also improves performance on modern hardware, as there is no nee
On Fri, 29 Nov 2024 11:08:57 GMT, Nizar Benalla wrote:
>> test/jdk/tools/sincechecker/modules/jdk.jlink/JdkJlinkCheckSince.java line
>> 29:
>>
>>> 27: * @summary Test for `@since` in jdk.jlink module
>>> 28: * @library /test/lib /test/jdk/tools/sincechecker
>>> 29: * @run main SinceChecker j
> Can I please get a review for this PR that add tests to verify the value of
> `@since` tags to the Tools area modules. The test is described in this
> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
> This issue is similar to JDK-8341399, JDK-8331051 and JDK-83434
On Fri, 29 Nov 2024 12:16:54 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Tools area modules. The test is described in this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
>> Th
On Fri, 29 Nov 2024 09:46:55 GMT, Per Minborg wrote:
>> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods,
>> fixing a bug in the `short_strlen` variant for odd offsets (`offset % 2 !=
>> 0`).
>>
>> This PR also improves performance on modern hardware, as there is no nee
On Thu, 17 Oct 2024 10:10:56 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
On Tue, 26 Nov 2024 18:07:41 GMT, Doug Lea wrote:
> This applies the same kinds of recovery on OOME (by spinning) and JVM
> Exceptions (by cancelling) seen in AQS.
This pull request has now been integrated.
Changeset: ece04010
Author:Doug Lea
URL:
https://git.openjdk.org/jdk/commit
On Fri, 29 Nov 2024 04:48:57 GMT, David Holmes wrote:
> The two new `execute` methods differ only in the Symbol naming the method to
> call. Can we not at least define a static helper in the file so that we don't
> need to duplicate everything?
Okay, esp. as we'll likely add more. At some poin
> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
> that support virtual threads doing blocking network I/O operations.
>
> This is a subset of the diagnostics that we've had in the loom repo for a
> long
On Fri, 29 Nov 2024 11:00:15 GMT, Christian Stein wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add backticks, as they are necessary. Otherwise the `@since` is treated as
>> a jtreg tag
>>
>> Revert "remov
On Thu, 14 Nov 2024 01:28:15 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Tools area modules. The test is described in this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
>> Th
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Fri, 29 Nov 2024 09:01:35 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix imports
>
> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java
> line 400:
>
>> 3
> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods,
> fixing a bug in the `short_strlen` variant for odd offsets (`offset % 2 !=
> 0`).
>
> This PR also improves performance on modern hardware, as there is no need for
> pre-looping alignment. Removing this improves perfo
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods and
> move them to the class `SegmentBulkOperations` where other bulk operations
> reside.
>
> This PR fixes a bug in the `short_strlen` variant for offsets that were odd
> (`offset % 2 != 0`).
>
> This PR also improves
On Thu, 28 Nov 2024 15:22:18 GMT, Jorn Vernee wrote:
>> Allow `captureCallState` and `critical(true)` linker options to be combined.
>> This allows passing a Java array to capture call state.
>>
>> One caveat is that the linker expects the memory to be aligned, which means
>> that at least an
On Wed, 27 Nov 2024 16:27:34 GMT, Per Minborg wrote:
> This PR proposes to check for empty layouts in the fallback linker and then
> prevent them from being forwarded.
>
> Passes tier5 linker tests.
This pull request has now been integrated.
Changeset: f2c0d186
Author:Per Minborg
URL:
On Fri, 29 Nov 2024 07:55:25 GMT, Per Minborg wrote:
> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods and
> move them to the class `SegmentBulkOperations` where other bulk operations
> reside.
>
> This PR fixes a bug in the `short_strlen` variant for offsets that were
On Fri, 29 Nov 2024 07:25:23 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Thu, 28 Nov 2024 12:25:28 GMT, Doug Lea wrote:
>> This applies the same kinds of recovery on OOME (by spinning) and JVM
>> Exceptions (by cancelling) seen in AQS.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes th
On Fri, 29 Nov 2024 07:55:25 GMT, Per Minborg wrote:
> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods and
> move them to the class `SegmentBulkOperations` where other bulk operations
> reside.
>
> This PR fixes a bug in the `short_strlen` variant for offsets that were
This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods and
move them to the class `SegmentBulkOperations` where other bulk operations
reside.
This PR fixes a bug in the `short_strlen` variant for offsets that were odd
(`offset % 2 != 0`).
This PR also improves performance on
52 matches
Mail list logo
