On Fri, 29 Nov 2024 09:01:35 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix imports > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line 400: > >> 398: */ >> 399: @ForceInline >> 400: public static int strlenByte(final AbstractMemorySegmentImpl >> segment, > > Can we put these back in `StringSupport`? It makes it hard to review the > differences side-by-side. (We can maybe decide later whether to move). In > general if we keep the `StringSupport` class it's a bit weird to have the > `strlen` methods not be there -- but I agree there's a similarity between > this and other bulk operations. I've moved back the methods to `StringSupport`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22451#discussion_r1863249968
