On Wed, 27 Nov 2024 10:56:57 GMT, Sergey Chernyshev <schernys...@openjdk.org> wrote:
>>> Version specific code can be had in `set_subsystem_path()` of the >>> corresponding impl (like an earlier version of your patch). `lowest_limit` >>> and `limit_cg_path` fixes are version agnostic and can and should be fixed >>> in `CgroupUtil::adjust_controller`. >> >> Done. Please see the updated PR. > >> Done. Please see the updated PR. > > The metrics part still needs the update - in the cgroup version specific > `setPath()`. Right. I'm still not convinced this extra reduction buys us much. The adjust controller logic will handle it if kept as is in the Metrics version. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21808#discussion_r1860465637
