On Thu, 7 Nov 2024 19:09:46 GMT, Per Minborg wrote:
> This PR fixes some regressions in the FFM benchmarks introduced by
> https://bugs.openjdk.org/browse/JDK-8332744.
This pull request has now been integrated.
Changeset: d0077eec
Author:Per Minborg
URL:
https://git.openjdk.org/jdk
On Wed, 6 Nov 2024 15:21:10 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Fri, 8 Nov 2024 05:26:37 GMT, Julian Waters wrote:
>>> Can someone confirm that use of `__stdcall` has no affect on name
>>> decorations, as there is no mention here about anything being ignored:
>>>
>>> https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names?view=msvc-170
>>>
On Fri, 8 Nov 2024 02:32:42 GMT, Alex Menkov wrote:
> In the page you mentioned:
@alexmenkov that is for C functions, not C++.
-
PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2463796536
On Fri, 8 Nov 2024 02:32:42 GMT, Alex Menkov wrote:
> Can someone confirm that use of `__stdcall` has no affect on name
> decorations, as there is no mention here about anything being ignored:
>
> https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names?view=msvc-170
>
> I would h
On Thu, 7 Nov 2024 23:36:39 GMT, Naoto Sato wrote:
> A small enhancement in the Java launcher. For diagnostic purposes, display
> the default time zone ID with the `-XshowSettings` option.
Hello Naoto, this looks good to me. The test itself could assert that the
printed timezone is indeed the
On Fri, 1 Nov 2024 14:51:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which cleans up a leftover code
>> from the launcher's java_md_macosx.m file?
>>
>> In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the
>> launcher code to remove checks for `/
On Wed, 30 Oct 2024 14:27:03 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up a leftover code from
> the launcher's java_md_macosx.m file?
>
> In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the
> launcher code to remove checks for `/jre/
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Thu, 7 Nov 2024 19:15:50 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
On Fri, 8 Nov 2024 02:13:09 GMT, David Holmes wrote:
> Can someone confirm that use of `__stdcall` has no affect on name
> decorations, as there is no mention here about anything being ignored:
>
> https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names?view=msvc-170
>
> I would
On Wed, 6 Nov 2024 15:21:10 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Thu, 7 Nov 2024 15:12:01 GMT, Maurizio Cimadamore
wrote:
> This small PR fixes a build failure due to usage of sun.misc.Unsafe in a new
> benchmark.
>
> FFM benchmarks appear to be broken -- because of JDK-8332744 -- but we will
> fix that separately.
@mcimadamore Sorry for the failure an
On Thu, 7 Nov 2024 23:36:39 GMT, Naoto Sato wrote:
> A small enhancement in the Java launcher. For diagnostic purposes, display
> the default time zone ID with the `-XshowSettings` option.
Nice RFE.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk/p
A small enhancement in the Java launcher. For diagnostic purposes, display the
default time zone ID with the `-XshowSettings` option.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/21965/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21965&r
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Thu, 7 Nov 2024 19:09:46 GMT, Per Minborg wrote:
> This PR fixes some regressions in the FFM benchmarks introduced by
> https://bugs.openjdk.org/browse/JDK-8332744.
LGTM.
-
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21963#pullrequestre
On Thu, 7 Nov 2024 13:27:41 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Wed, 6 Nov 2024 21:42:36 GMT, Alexey Semenyuk wrote:
> Use internal jdk API instead of parsing JVM properties where appropriate in
> jpackage tests
This pull request has now been integrated.
Changeset: a63f501b
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/a63f5
Add jlink plugins to allow branding change for java.vendor, java.vm.vendor and
java.vendor.url.
The jlink plugin will change the value in java.lang.VersionProps, which will
set those property values. The `java.vm.vendor` was initialized by VM with
value set at build time, and then later be repl
On Wed, 6 Nov 2024 21:42:36 GMT, Alexey Semenyuk wrote:
> Use internal jdk API instead of parsing JVM properties where appropriate in
> jpackage tests
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21940#pullrequestreview-2422
On Thu, 7 Nov 2024 19:09:46 GMT, Per Minborg wrote:
> This PR fixes some regressions in the FFM benchmarks introduced by
> https://bugs.openjdk.org/browse/JDK-8332744.
Marked as reviewed by jvernee (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21963#pullrequestreview-2
On Thu, 7 Nov 2024 18:30:22 GMT, Vladimir Ivanov wrote:
>> The synchronization block may be substituted by the 'volatile' variable
>> smaller synchronization block.
>> It reduce the total blocking time for the specjvm2008::xml.validation
>> workload and improve the reported score.
>> Scores for
On Thu, 7 Nov 2024 09:45:40 GMT, Amit Kumar wrote:
> > I think we can add @requires vm.continuations to this test. It's not useful
> > to run with the alternative virtual thread implementation.
>
> Sure, that sounds ok. Thanks.
>
Added `@requires vm.continuations` to the test.
-
P
On Thu, 7 Nov 2024 18:32:14 GMT, Serguei Spitsyn wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use JvmtiVTMSTransitionDisabler::VTMS_vthread_mount/unmount
>
> src/hotspot/share/prims/jvmtiThreadState.cp
This PR fixes some regressions in the FFM benchmarks introduced by
https://bugs.openjdk.org/browse/JDK-8332744.
-
Commit messages:
- Add imports to FFM benchmarks
Changes: https://git.openjdk.org/jdk/pull/21963/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21963&range=00
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Thu, 7 Nov 2024 00:38:57 GMT, Patricio Chilano Mateo
wrote:
>>> the call to java_lang_Thread::set_is_in_VTMS_transition()is not needed in
>>> JvmtiUnmountBeginMark
>>>
>> Why is not needed? I guess you meant to say we should use
>> `JvmtiVTMSTransitionDisabler::set_is_in_VTMS_transition()`
On Thu, 7 Nov 2024 00:40:26 GMT, Patricio Chilano Mateo
wrote:
>>> So at some point I think we need to figure out how to make them go away ...
>>
>> Yes, the 2 extension events (`VirtualThreadMount` and
>> `VirtualThreadUnmount`) were added for testing purposes. We wanted to get
>> rid of th
On Wed, 6 Nov 2024 15:21:10 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Thu, 7 Nov 2024 04:44:25 GMT, Prasadrao Koppula wrote:
>> Using SharedSecrets, I attempted to expose FileInputStream::path
>> information. After implementing the fix, I validated the startup performance
>> tests. Observed no consistent pattern of performance drops or gains, can
>> disregard
On 11/1/2024 1:19 PM, Eirik Bjørsnøs wrote:
On Fri, Nov 1, 2024 at 8:42 PM Joseph D. Darcy
wrote:
A few releases back, a discussion of "quality, equivalence, and
comparison of floating-point values" was added to java.lang.Double:
https://docs.oracle.com/en/java/javase/23/docs/ap
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Thu, 31 Oct 2024 15:00:25 GMT, Sergey Chernyshev
wrote:
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
On Thu, 7 Nov 2024 00:38:18 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
On Fri, 1 Nov 2024 13:13:07 GMT, Sergey Chernyshev
wrote:
> As they're in fact mounting read-write, the logic picked up `rw` mount option
> and falsely detected "host mode". Also the `--privileged` creates `rw`
> mounts, so the entire approach needs correction.
Yes. See https://bugs.openjdk.o
On Thu, 7 Nov 2024 18:30:22 GMT, Vladimir Ivanov wrote:
>> The synchronization block may be substituted by the 'volatile' variable
>> smaller synchronization block.
>> It reduce the total blocking time for the specjvm2008::xml.validation
>> workload and improve the reported score.
>> Scores for
On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A
> future me chasing
On Thu, 7 Nov 2024 00:38:18 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
> The synchronization block may be substituted by the 'volatile' variable
> smaller synchronization block.
> It reduce the total blocking time for the specjvm2008::xml.validation
> workload and improve the reported score.
> Scores for the 112vCPU on the with 28GB heap increased from 17915.83 to
On Thu, 7 Nov 2024 05:00:46 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 180 commits:
>>
>> - Merge branch 'master' into jdk-8311302-jmodless-link
>> - Make capability in --help huma
On Thu, 7 Nov 2024 16:42:55 GMT, Vladimir Ivanov wrote:
>> The synchronization block may be substituted by the 'volatile' variable
>> smaller synchronization block.
>> It reduce the total blocking time for the specjvm2008::xml.validation
>> workload and improve the reported score.
>> Scores for
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change
> reduces the back and forth between the launcher
On Thu, 7 Nov 2024 13:27:41 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Thu, 7 Nov 2024 16:42:55 GMT, Vladimir Ivanov wrote:
>> The synchronization block may be substituted by the 'volatile' variable
>> smaller synchronization block.
>> It reduce the total blocking time for the specjvm2008::xml.validation
>> workload and improve the reported score.
>> Scores for
On Fri, 14 Jun 2024 06:49:34 GMT, Alan Bateman wrote:
>>> My aim will be to bring this into JDK 24 with a JEP then. Hopefully we can
>>> bring this to a successful conclusion that way.
>>
>> @AlanBateman JEP draft is here:
>> https://openjdk.org/jeps/8333799
>>
>> Could you please help review
This small PR fixes a build failure due to usage of sun.misc.Unsafe in a new
benchmark.
FFM benchmarks appear to be broken -- because of JDK-8332744 -- but we will fix
that separately.
-
Commit messages:
- Initial push
Changes: https://git.openjdk.org/jdk/pull/21958/files
Webre
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
> The synchronization block may be substituted by the 'volatile' variable
> smaller synchronization block.
> It reduce the total blocking time for the specjvm2008::xml.validation
> workload and improve the reported score.
> Scores for the 112vCPU on the with 28GB heap increased from 17915.83 to
On Fri, 1 Nov 2024 14:51:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which cleans up a leftover code
>> from the launcher's java_md_macosx.m file?
>>
>> In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the
>> launcher code to remove checks for `/
On Mon, 4 Nov 2024 18:30:50 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds `@since` checker tests to the
>> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps.
>> The initial test for `java.base` has been integrated in
>> [JDK-8331051](https://b
On Thu, 7 Nov 2024 05:15:09 GMT, Mandy Chung wrote:
> For the test changes, I believe multiple `@test` tags to verify a JDK of
> linkable run-time image and another JDK with packaged modules are not
> necessary. Each test execution can only verify one JDK. The tests can keep
> one single `@tes
> This change optimizes the runtime of `Class.getMethod(String, Class[])` by
> reducing the cost of the existing search logic. Specifically, while
> iterating across each Method to find a match (existing logic) it now compares
> parameter count before checking method name. This check is substa
Use internal jdk API instead of parsing JVM properties where appropriate in
jpackage tests
-
Commit messages:
- 8343396: Use OperatingSystem, Architecture, and OSVersion in jpackage tests
Changes: https://git.openjdk.org/jdk/pull/21940/files
Webrev: https://webrevs.openjdk.org/?r
On Tue, 5 Nov 2024 16:08:20 GMT, Alexey Semenyuk wrote:
> - fix `JPackageCommand.excludeAppLayoutAsserts()`;
> - fix `InOutPath` test case that will make jpackage produce an invalid app
> image on macOS.
This pull request has now been integrated.
Changeset: ac82a8f8
Author:Alexey Semenyuk
On Wed, 6 Nov 2024 17:35:36 GMT, Chen Liang wrote:
>> I don't like the style of a custom loop rather than `Arrays.equals()` but
>> there is a perf benefit to it. Curious what you think?
>
> Sure, moving param count ahead is fine. Note that `Arrays.equals` is subject
> to profile pollution at
On Wed, 6 Nov 2024 21:42:36 GMT, Alexey Semenyuk wrote:
> Use internal jdk API instead of parsing JVM properties where appropriate in
> jpackage tests
@sashamatveev ptal
-
PR Comment: https://git.openjdk.org/jdk/pull/21940#issuecomment-2462120368
On Thu, 7 Nov 2024 15:12:01 GMT, Maurizio Cimadamore
wrote:
> This small PR fixes a build failure due to usage of sun.misc.Unsafe in a new
> benchmark.
>
> FFM benchmarks appear to be broken -- because of JDK-8332744 -- but we will
> fix that separately.
Marked as reviewed by alanb (Reviewer
On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A
> future me chasing
On Thu, 7 Nov 2024 14:28:34 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains nine additional
>> commits s
On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A
> future me chasing
> Javac is not issuing a mandated unchecked cast warning for code like:
>
>
> import java.lang.invoke.VarHandle;
>
> class VarHandleCast {
> VarHandle vh;
> V method(Object obj) {
> return (V)vh.getAndSet(this, obj);
> }
> }
>
>
> according to the spec the return type i
On Thu, 7 Nov 2024 15:12:01 GMT, Maurizio Cimadamore
wrote:
> This small PR fixes a build failure due to usage of sun.misc.Unsafe in a new
> benchmark.
>
> FFM benchmarks appear to be broken -- because of JDK-8332744 -- but we will
> fix that separately.
This pull request has now been integr
On Thu, 31 Oct 2024 15:52:04 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
> check of non-closeable scopes such as the global scope can be elided.
>
> Currently, the `state` field is overloaded with 2 responsibilities, to act as
Hi Alexey,
However, I find it suspicious that other app icons are OK on your
> screenshots and only an icon of the package-created app is blank. If you
> have a reproducible example, please file a bug!
>
I have tried the *same* msi installer on 3 windows machines and only one
shows no app icon.
H
On Wed, 6 Nov 2024 21:42:36 GMT, Alexey Semenyuk wrote:
> Use internal jdk API instead of parsing JVM properties where appropriate in
> jpackage tests
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21940#pullrequestreview-2421175432
On Thu, 7 Nov 2024 14:16:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Thu, 7 Nov 2024 14:16:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Wed, 6 Nov 2024 20:08:54 GMT, Vicente Romero wrote:
>> Javac is not issuing a mandated unchecked cast warning for code like:
>>
>>
>> import java.lang.invoke.VarHandle;
>>
>> class VarHandleCast {
>> VarHandle vh;
>> V method(Object obj) {
>> return (V)vh.getAndSet(this,
On Fri, 1 Nov 2024 14:51:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which cleans up a leftover code
>> from the launcher's java_md_macosx.m file?
>>
>> In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the
>> launcher code to remove checks for `/
On Thu, 7 Nov 2024 13:59:03 GMT, Maurizio Cimadamore
wrote:
> Changes look good. The extra suppress warnings seem to indicate that the
> logic is now working as intended :-)
thanks for the review. As suggested above I created a CSR, could you please
review it too? Thanks!
-
PR C
On Thu, 7 Nov 2024 13:16:19 GMT, Coleen Phillimore wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @DanHeidinga comment -- exit VM when runtimeSetup() fails
>
> src/hotspot/share/cds/aotConstantPoolResolver.cpp line 2:
On Thu, 7 Nov 2024 12:08:50 GMT, Aleksey Shipilev wrote:
>> src/hotspot/os/windows/os_windows.cpp line 510:
>>
>>> 508: // Thread start routine for all newly created threads.
>>> 509: // Called with the associated Thread* as the argument.
>>> 510: static unsigned thread_native_entry(void* t) {
>
On Mon, 4 Nov 2024 23:57:48 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https:
On Tue, 5 Nov 2024 17:02:24 GMT, Severin Gehwolf wrote:
>> test/jtreg-ext/requires/VMProps.java line 743:
>>
>>> 741: // jdk.jlink module has the following resource indicating a
>>> runtime-linkable
>>> 742: // image. It's the diff file for runtime linking of the
>>> java.base
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
Hi Daniel,
Given your description of the issue with blank icons as specific to some
deployments only, it may be a Windows issue.
"missing" .ico files in app image should not be the cause.
However, I find it suspicious that other app icons are OK on your
screenshots and only an icon of the pac
On Wed, 6 Nov 2024 00:56:49 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix: jvm_md.h was included, but not jvm.h...
>
> src/hotspot/os/windows/os_windows.cpp line 510:
>
>> 508: // Thr
On Wed, 6 Nov 2024 00:15:44 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
On Thu, 11 Jul 2024 22:30:45 GMT, Vladimir Ivanov wrote:
> Overall, looks fine.
>
> So, there will be `inline_min_max`, `inline_fp_min_max`, and
> `inline_long_min_max` which slightly vary. I'd prefer to see them unified.
> (Or, at least, enhance `inline_min_max` to cover `minL`/maxL` cases).
On Thu, 7 Nov 2024 09:40:19 GMT, Alan Bateman wrote:
>I think we can add @requires vm.continuations to this test. It's not useful to
>run with the alternative virtual thread implementation.
Sure, that sounds ok. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/21565#issuecom
On Wed, 6 Nov 2024 17:38:59 GMT, Patricio Chilano Mateo
wrote:
>> Good work! I'll approve the GC related changes.
>>
>> There are some simplifications I think can be done in the ObjectMonitor
>> layer, but nothing that should go into this PR.
>>
>> Similarly, (even if some of this is preexist
On Tue, 5 Nov 2024 16:08:20 GMT, Alexey Semenyuk wrote:
> - fix `JPackageCommand.excludeAppLayoutAsserts()`;
> - fix `InOutPath` test case that will make jpackage produce an invalid app
> image on macOS.
Hi Aleksei, with your patch added I see so far no errors any more related to
InOutPathTest
On Wed, 6 Nov 2024 17:38:59 GMT, Patricio Chilano Mateo
wrote:
>> Good work! I'll approve the GC related changes.
>>
>> There are some simplifications I think can be done in the ObjectMonitor
>> layer, but nothing that should go into this PR.
>>
>> Similarly, (even if some of this is preexist
Hi Alexey, all,
Thank you very much for your reply and the pointers you provided.
Honestly I don't mind whether the ico file is part of the exe or not. It
should just work as expected.
Having said that, we are seeing issues that in some cases it doesn't seem
to work (i.e., not showing any icon).
- Original Message -
> From: "Andrey Turbanov"
> To: "core-libs-dev"
> Sent: Thursday, November 7, 2024 9:17:00 AM
> Subject: Can LinkedHashMap(accessOrder=true) be guarded by ReadWriteLock ?
> Hello.
> I've got a question about LinkedHashMap created with accessOrder=true flag.
> Usually
Hello.
I've got a question about LinkedHashMap created with accessOrder=true flag.
Usually this constructor is used when we want to build LRU cache.
https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/LinkedHashMap.html#(int,float,boolean)
LinkedHashMap cache = new Linke
87 matches
Mail list logo
