On Thu, 7 Nov 2024 05:15:09 GMT, Mandy Chung <mch...@openjdk.org> wrote:
> For the test changes, I believe multiple `@test` tags to verify a JDK of
> linkable run-time image and another JDK with packaged modules are not
> necessary. Each test execution can only verify one JDK. The tests can keep
> one single `@test` and the main method has to determine the test JDK
> configuration for test verification.
Done in the latest update. Thanks again for the review!
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JRTArchive.java line 132:
>
>> 130: } catch (RuntimeImageLinkException e) {
>> 131: // populate modified files exception
>> 132: throw e;
>
> It's unchecked exception and this catch clause can be dropped.
Correct. Fixed.
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line
> 126:
>
>> 124: \ and cannot be used to create another image with the jdk.jlink module
>> 125: err.runtime.link.packaged.mods=This JDK has no packaged modules.\
>> 126: \ --keep-packaged-modules is not supported.
>
> Suggestion:
>
> err.runtime.link.packaged.mods=This JDK has no packaged modules.\
> \ --keep-packaged-modules is not supported
Thanks. Fixed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2462230045
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1832665852
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1832659096
