On Fri, 1 Nov 2024 14:51:49 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which cleans up a leftover code >> from the launcher's java_md_macosx.m file? >> >> In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the >> launcher code to remove checks for `<apphome>/jre/lib/` when determining >> the JDK installation root. Those changes were done in the Unix and Windows >> files and the macosx one got left out, likely due to an oversight. >> >> The commit in this PR removes that leftover code. No new tests have been >> added and existing tier1, tier2, tier3 tests continue to pass. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > Roger's suggestion - introduce log message to match unix/windows Looks fine. ------------- Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21789#pullrequestreview-2421491741
